Skip to content
This repository was archived by the owner on Sep 15, 2022. It is now read-only.

Commit af933f9

Browse files
committed
Move the serial_port native code
The latest version of the Dart VM require native code for native extensions to be in the same directory as the Dart file inporting it. Closes #588 BUG= #588 [email protected] BUG= Review URL: https://codereview.chromium.org/2206873004 .
1 parent 3905382 commit af933f9

File tree

7 files changed

+8
-7
lines changed

7 files changed

+8
-7
lines changed

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ packages
8585
/third_party/raspbian/image.tar.gz
8686
/third_party/raspbian/kernel
8787
/third_party/raspbian/kernel.tar.gz
88-
/third_party/serial_port/lib/src/libserial_port.dylib
89-
/third_party/serial_port/lib/src/libserial_port.so
88+
/third_party/serial_port/lib/libserial_port.dylib
89+
/third_party/serial_port/lib/libserial_port.so
9090
/third_party/stm/stm32cube_fw_f4.tar.gz
9191
/third_party/stm/stm32cube_fw_f4/
9292
/third_party/stm/stm32cube_fw_f7.tar.gz

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ hooks = [
226226
'--bucket',
227227
'dartino-dependencies',
228228
'-d',
229-
'sdk/third_party/serial_port/lib/src/',
229+
'sdk/third_party/serial_port/lib/',
230230
],
231231
},
232232
{

pkg/mdns/lib/src/native_extension_api.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ library mdns.src.native_extension_api;
66

77
import 'dart:isolate';
88

9-
import "dart-ext:../mdns_extension_lib";
9+
import "dart-ext:mdns_extension_lib";
1010

1111
SendPort servicePort() native 'MDnsExtension_ServicePort';

third_party/serial_port/README.google

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@ License File: LICENSE
55
Description:
66
SerialPort is a Dart Api to provide access read and write access to serial port.
77
Local Modifications:
8-
Added functionality to write binary data instead of strings.
9-
Throw FileSystemExceptions instead of Strings.
8+
* Added functionality to write binary data instead of strings.
9+
* Throw FileSystemExceptions instead of Strings.
10+
* Moved the native library out to the lib directory

third_party/serial_port/lib/serial_port.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ library serial_port;
1717
import 'dart:async';
1818
import 'dart:isolate';
1919
import 'dart:io';
20-
import 'dart-ext:src/serial_port';
20+
import 'dart-ext:serial_port';
2121
import 'dart:typed_data';
2222

2323
part 'src/serial_port_impl.dart';

0 commit comments

Comments
 (0)