From 6ffda017dbb60b8a2dbb157f6d5d490c2fbc354b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 28 Nov 2024 18:20:34 +0000 Subject: [PATCH 1/3] chore(deps): bump mason in /packages/dart_frog_cli Bumps [mason](https://github.com/felangel/mason) from 0.1.0-dev.60 to 0.1.0. - [Release notes](https://github.com/felangel/mason/releases) - [Commits](https://github.com/felangel/mason/compare/mason-v0.1.0-dev.60...mason-v0.1.0) --- updated-dependencies: - dependency-name: mason dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- packages/dart_frog_cli/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dart_frog_cli/pubspec.yaml b/packages/dart_frog_cli/pubspec.yaml index 4279f8c48..69c5508e1 100644 --- a/packages/dart_frog_cli/pubspec.yaml +++ b/packages/dart_frog_cli/pubspec.yaml @@ -19,7 +19,7 @@ dependencies: cli_completion: ^0.5.1 dart_frog_gen: ^2.0.0 equatable: ^2.0.5 - mason: 0.1.0-dev.60 + mason: 0.1.0 meta: ^1.15.0 path: ^1.9.0 pub_updater: ^0.5.0 From d0b85ee8703c81c933fdae1daba5a6c234f152aa Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 2 Dec 2024 11:31:23 -0600 Subject: [PATCH 2/3] fixing difference in output per OS --- .../dart_frog_cli/test/src/command_runner_test.dart | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/dart_frog_cli/test/src/command_runner_test.dart b/packages/dart_frog_cli/test/src/command_runner_test.dart index 426268fe8..668fb2588 100644 --- a/packages/dart_frog_cli/test/src/command_runner_test.dart +++ b/packages/dart_frog_cli/test/src/command_runner_test.dart @@ -98,12 +98,18 @@ void main() { any( that: predicate((message) { final containsError = message.contains( - 'Could not find an option named "invalid-option".', + 'Could not find an option named ', ); + final contiansInvalidOption = message.contains( + '"invalid-option"', + ) || + message.contains( + '"--invalid-option"', + ); final containsUsage = message.contains( 'Usage: dart_frog [arguments]', ); - return containsError && containsUsage; + return containsError && contiansInvalidOption && containsUsage; }), ), ), From b2efbdb11851d045ef1d07071605163d87fd2d99 Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 2 Dec 2024 11:32:19 -0600 Subject: [PATCH 3/3] mispell and docs --- packages/dart_frog_cli/test/src/command_runner_test.dart | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/dart_frog_cli/test/src/command_runner_test.dart b/packages/dart_frog_cli/test/src/command_runner_test.dart index 668fb2588..dd440435a 100644 --- a/packages/dart_frog_cli/test/src/command_runner_test.dart +++ b/packages/dart_frog_cli/test/src/command_runner_test.dart @@ -100,7 +100,9 @@ void main() { final containsError = message.contains( 'Could not find an option named ', ); - final contiansInvalidOption = message.contains( + // The message should contain the invalid option name but is + // differet based on the platform it's running on. + final containsInvalidOption = message.contains( '"invalid-option"', ) || message.contains( @@ -109,7 +111,7 @@ void main() { final containsUsage = message.contains( 'Usage: dart_frog [arguments]', ); - return containsError && contiansInvalidOption && containsUsage; + return containsError && containsInvalidOption && containsUsage; }), ), ),