From dcc1e4a698751474b78d021751a18a99bf5aafa0 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 21 Aug 2025 13:18:20 -0500 Subject: [PATCH] refactor(dart_frog_lint): define analysis_options inline --- packages/dart_frog_lint/CHANGELOG.md | 4 + packages/dart_frog_lint/README.md | 6 +- packages/dart_frog_lint/lib/recommended.yaml | 224 ++++++++++++++++++- packages/dart_frog_lint/pubspec.yaml | 5 +- 4 files changed, 227 insertions(+), 12 deletions(-) diff --git a/packages/dart_frog_lint/CHANGELOG.md b/packages/dart_frog_lint/CHANGELOG.md index 2d5599a50..7901c3880 100644 --- a/packages/dart_frog_lint/CHANGELOG.md +++ b/packages/dart_frog_lint/CHANGELOG.md @@ -1,3 +1,7 @@ +# 0.1.1 + +- fix: dart sdk compatibility + # 0.1.0 - feat: initial release 🎉 diff --git a/packages/dart_frog_lint/README.md b/packages/dart_frog_lint/README.md index 84917a91a..d9ceaabd5 100644 --- a/packages/dart_frog_lint/README.md +++ b/packages/dart_frog_lint/README.md @@ -10,7 +10,7 @@ [![ci][ci_badge]][ci_link] [![coverage][coverage_badge]][ci_link] [![pub package][pub_badge]][pub_link] -[![style: very good analysis][very_good_analysis_badge]][very_good_analysis_link] +[![style: dart_frog_lint][dart_frog_lint_badge]][dart_frog_lint_link] [![License: MIT][license_badge]][license_link] A collection of lint rules built specifically for [Dart Frog][docs_link]. @@ -36,6 +36,8 @@ For official documentation, please visit [dart-frog.dev][docs_link]. [coverage_badge]: https://raw.githubusercontent.com/dart-frog-dev/dart_frog/main/packages/dart_frog_lint/coverage_badge.svg [dart_badge]: https://img.shields.io/badge/Dart-%230175C2.svg?style=for-the-badge&logo=dart&logoColor=5BB4F0&color=1E2833 [dart_link]: https://dart.dev +[dart_frog_lint_badge]: https://img.shields.io/badge/style-dart_frog_lint-1DF9D2.svg +[dart_frog_lint_link]: https://pub.dev/packages/dart_frog_lint [discord_badge]: https://img.shields.io/discord/1394707782271238184?style=for-the-badge&logo=discord&color=1C2A2E&logoColor=1DF9D2 [discord_link]: https://discord.gg/dart-frog [docs_link]: https://dart-frog.dev @@ -45,5 +47,3 @@ For official documentation, please visit [dart-frog.dev][docs_link]. [logo_white]: https://raw.githubusercontent.com/dart-frog-dev/dart_frog/main/assets/dart_frog_logo_white.png#gh-dark-mode-only [pub_badge]: https://img.shields.io/pub/v/dart_frog_lint.svg [pub_link]: https://pub.dartlang.org/packages/dart_frog_lint -[very_good_analysis_badge]: https://img.shields.io/badge/style-very_good_analysis-B22C89.svg -[very_good_analysis_link]: https://pub.dev/packages/very_good_analysis diff --git a/packages/dart_frog_lint/lib/recommended.yaml b/packages/dart_frog_lint/lib/recommended.yaml index 6afbc1a7f..815bc83c2 100644 --- a/packages/dart_frog_lint/lib/recommended.yaml +++ b/packages/dart_frog_lint/lib/recommended.yaml @@ -1,10 +1,224 @@ -include: package:very_good_analysis/analysis_options.yaml analyzer: exclude: - build/** + + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + record_literal_one_positional_no_trailing_comma: error + +formatter: + page_width: 80 + trailing_commas: preserve + linter: rules: - # Route names are derived from the respective file names - file_names: false - # Experimental and there are lots of false positives - specify_nonobvious_property_types: false + - always_declare_return_types + - always_put_required_named_parameters_first + - always_use_package_imports + - annotate_overrides + - annotate_redeclares + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_final_parameters + - avoid_function_literals_in_foreach_calls + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_multiple_declarations_per_line + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - collection_methods_unrelated_type + - combinators_ordering + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - dangling_library_doc_comments + - depend_on_referenced_packages + - deprecated_consistency + - deprecated_member_use_from_same_package + - directives_ordering + - do_not_use_environment + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - flutter_style_todos + - hash_and_equals + - implementation_imports + - implicit_call_tearoffs + - implicit_reopen + - invalid_case_patterns + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_annotations + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - literal_only_boolean_expressions + - matching_super_parameters + - missing_code_block_language_in_doc_comment + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_literal_bool_comparisons + - no_logic_in_create_state + - no_runtimeType_toString + - no_self_assignments + - no_wildcard_variable_uses + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_mixin + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - strict_top_level_inference + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - type_literal_in_constant_pattern + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_brace_in_string_interps + - unnecessary_breaks + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_library_directive + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_aware_operator_on_extension_on_nullable + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unnecessary_to_list_in_spreads + - unnecessary_underscores + - unreachable_from_main + - unrelated_type_equality_checks + - unsafe_html + - use_build_context_synchronously + - use_colored_box + - use_decorated_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_if_null_to_convert_nulls_to_bools + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_string_in_part_of_directives + - use_super_parameters + - use_test_throws_matchers + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/packages/dart_frog_lint/pubspec.yaml b/packages/dart_frog_lint/pubspec.yaml index 4023dc0eb..03199b55f 100644 --- a/packages/dart_frog_lint/pubspec.yaml +++ b/packages/dart_frog_lint/pubspec.yaml @@ -1,6 +1,6 @@ name: dart_frog_lint description: A collection of lint rules built specifically for the Dart Frog backend framework. -version: 0.1.0 +version: 0.1.1 homepage: https://dart-frog.dev repository: https://github.com/dart-frog-dev/dart_frog issue_tracker: https://github.com/dart-frog-dev/dart_frog/issues @@ -13,6 +13,3 @@ screenshots: environment: sdk: ">=3.0.0 <4.0.0" - -dependencies: - very_good_analysis: ^9.0.0