Skip to content

Commit 10de1d5

Browse files
authored
Use HttpMultiServer loopback (#2265) (#2267)
This should close dart-lang/webdev#375
1 parent a56c940 commit 10de1d5

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

build_daemon/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
`Stream<WatchEvent>`. This allows file change notifications to be sent as
77
batches of simultaneous changes, preventing over-triggering of builds.
88

9+
## 0.6.1
10+
11+
- Use `HttpMultiServer` to better support IPv6 and IPv4 workflows.
12+
913
## 0.6.0
1014

1115
- Add retry logic to the state file helpers `runningVersion` and

build_daemon/lib/src/server.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import 'dart:convert';
77
import 'dart:io';
88

99
import 'package:built_value/serializer.dart';
10+
import 'package:http_multi_server/http_multi_server.dart';
1011
import 'package:pool/pool.dart';
1112
import 'package:shelf/shelf_io.dart';
1213
import 'package:shelf_web_socket/shelf_web_socket.dart';
@@ -79,7 +80,9 @@ class Server {
7980
_removeChannel(channel);
8081
});
8182
});
82-
_server = await serve(handler, 'localhost', 0);
83+
84+
_server = await HttpMultiServer.loopback(0);
85+
serveRequests(_server, handler);
8386
return _server.port;
8487
}
8588

build_daemon/pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ environment:
1010
dependencies:
1111
built_collection: ^4.1.0
1212
built_value: ^6.3.0
13+
http_multi_server: ^2.0.0
1314
logging: ^0.11.0
1415
pedantic: ^1.0.0
1516
package_resolver: ^1.0.6

0 commit comments

Comments
 (0)