Skip to content

Expand analyzer constraints to include 0.33.x versions #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
jcollins-g opened this issue Sep 27, 2018 · 7 comments
Closed
7 tasks done

Expand analyzer constraints to include 0.33.x versions #1869

jcollins-g opened this issue Sep 27, 2018 · 7 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:build_modules package:build_resolvers package:build_web_compilers package:build

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Sep 27, 2018

Dartdoc and other clients of the analyzer that require specific support for the new mixin declarations need to be able to use the 0.33 version, and currently can't if they use build, because of the constraints for analyzer on build.

  • build
  • build_resolvers
  • build_modules
  • build_web_compilers

Blocking

@jakemac53
Copy link
Contributor

It looks like analyzer is still on 0.33.0-alpha.0, can we wait until a real version is published or does this have to happen beforehand?

@bwilkerson
Copy link
Member

If we push a non-alpha version then we would probably need to update a large number of packages. We can do that if you feel strongly enough about not using alpha versions, but I always try to avoid it for as long as possible because of the work it makes for everyone else.

@jakemac53
Copy link
Contributor

There is no difference though if we are being asked to upgrade to the alpha release? Why would only package:build be required to update?

@jakemac53
Copy link
Contributor

(in general if this is for the new mixin declaration support I would expect all users are going to want that anyways, so its worth a major release)

@kevmoo
Copy link
Member

kevmoo commented Oct 8, 2018

0.33.0 was published on Thursday. We're already seeing issues w/ Flutter on json_serializable.

@kevmoo kevmoo added package:build_web_compilers package:build_modules package:build_resolvers P1 A high priority bug; for example, a single project is unusable or has many test failures labels Oct 8, 2018
@jcollins-g
Copy link
Contributor Author

Dartdoc is no longer hard blocked on this.

@jakemac53
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:build_modules package:build_resolvers package:build_web_compilers package:build
Projects
None yet
Development

No branches or pull requests

4 participants