Skip to content

Rebuilds shouldn't hit the file system to get the list of inputs #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue Feb 16, 2016 · 1 comment
Closed
Labels
P3 A lower priority bug or feature request package:build_runner type-enhancement A request for a change that isn't a bug

Comments

@jakemac53
Copy link
Contributor

Today each rebuild will list the file system for all files. We should instead just keep an updated set of valid inputs, based on updates that are seen.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed enhancement labels Sep 14, 2016
@jakemac53 jakemac53 added P3 A lower priority bug or feature request package:build_runner S3 low labels Jan 30, 2017
@natebosch
Copy link
Member

This is fixed now. The only place we call AssetReader.findAssets is in build_definition.dart, and that only happens on the first load. Subsequent builds based on the file changes update the asset graph without listing from disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:build_runner type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants