#932. Some HttpRequest tests fixed to work well with cross origin requests

Author: sgrekhov

LibTest/html/HttpRequest/abort_A01_t01.dart

@@ -8,7 +8,7 @@
  * Stop the current request.
  * The request can only be stopped if readyState is HEADERS_RECIEVED or LOADING.
  * If this method is not in the process of being sent, the method has no effect.
- * @description Checks the state of request at variuos moments of time.
+ * @description Checks the state of request at various moments of time.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";

LibTest/html/HttpRequest/dispatchEvent_A01_t01.dart

@@ -6,7 +6,7 @@
 /**
  * @assertion bool dispatchEvent(Event event)
  * Dispatch an event to this EventTarget.
- * @description Checks that an event is diapatched.
+ * @description Checks that an event is dispatched.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";

LibTest/html/HttpRequest/getAllResponseHeaders_A01_t01.dart

@@ -7,18 +7,20 @@
  * @assertion String getAllResponseHeaders()
  * Retrieve all the response headers from a request.
  * null if no headers have been received. For multipart requests,
- * getAllResponseHeaders will return the response headers for the current part of the request.
+ * getAllResponseHeaders will return the response headers for the current part
+ * of the request.
  * @description Checks that response headers are retrieved.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";
+import "../testcommon.dart";
 
 void check(String allHeaders) {
   List<String> headers = allHeaders.split('\n');
   for (String header in headers) {
     List<String> entry = header.split(':');
     if (entry[0] == "content-type") {
-      Expect.equals("application/dart", entry[1].trim());
+      Expect.isTrue(entry[1].trim().startsWith("text/plain"));
       return;
     }
   }
@@ -27,7 +29,10 @@ void check(String allHeaders) {
 
 main() {
   var request = new HttpRequest();
-  request.open('GET', "http://localhost");
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/LibTest/html/xhr_cross_origin_data.txt';
+  request.open('GET', url);
   asyncStart();
   request.onLoad.listen((event) {
     switch (request.readyState) {

LibTest/html/HttpRequest/getResponseHeader_A01_t01.dart

@@ -10,16 +10,20 @@
  */
 import "dart:html";
 import "../../../Utils/expect.dart";
+import "../testcommon.dart";
 
 main() {
   var request = new HttpRequest();
-  request.open('GET', "test.dart");
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/LibTest/html/xhr_cross_origin_data.txt';
+  request.open('GET', url);
   asyncStart();
   request.onLoad.listen((event) {
     switch (request.readyState) {
       case HttpRequest.DONE:
-        Expect.equals(
-            "application/dart", request.getResponseHeader("content-type"));
+        Expect.isTrue(
+            request.getResponseHeader("content-type")?.startsWith("text/plain"));
         asyncEnd();
         break;
       case HttpRequest.HEADERS_RECEIVED:

LibTest/html/HttpRequest/getString_A01_t01.dart

@@ -4,18 +4,24 @@
  * BSD-style license that can be found in the LICENSE file.
  */
 /**
- * @assertion Future<String> getString(String url, {bool withCredentials, void onProgress(ProgressEvent e)})
+ * @assertion Future<String> getString(String url, {bool withCredentials, void o
+ *  nProgress(ProgressEvent e)})
  * Creates a GET request for the specified url.
  * The server response must be a text/ mime type for this request to succeed.
- * This is similar to request but specialized for HTTP GET requests which return text content.
+ * This is similar to request but specialized for HTTP GET requests which return
+ * text content.
  * @description Checks that readystatechange events are exposed.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";
+import "../testcommon.dart";
 
 main() {
   asyncStart();
-  var f = HttpRequest.getString("test.dart", onProgress: (event) {
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/LibTest/html/xhr_cross_origin_data.txt';
+  var f = HttpRequest.getString(url, onProgress: (event) {
     Expect.equals("progress", event.type, "stream.listen.onData");
   });
   f.then((content) {

LibTest/html/HttpRequest/onAbort_A01_t01.dart

@@ -10,10 +10,14 @@
  */
 import "dart:html";
 import "../../../UtilsHtml/expect.dart";
+import "../testcommon.dart";
 
 main() {
   var request = new HttpRequest();
-  request.open('GET', "test.dart");
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/LibTest/html/xhr_cross_origin_data.txt';
+  request.open('GET', url);
   request.onAbort.listen((event) {
     UtilsHtml.show("request.onAbort.listen: $event");
     asyncEnd();

LibTest/html/HttpRequest/onError_A01_t02.dart

@@ -6,16 +6,20 @@
 /**
  * @assertion Stream<ProgressEvent> get onError
  * Stream of error events handled by this HttpRequestEventTarget.
- * @description Checks that an error events issued when attemt to FET unexistent
- * resourse is made and error 404 returned.
+ * @description Checks that an error events issued when attempt to FET unexistent
+ * resource is made and error 404 returned.
  * @needsreview issue #16757
  */
 import "dart:html";
 import "../../../UtilsHtml/expect.dart";
+import "../testcommon.dart";
 
 main() {
   var request = new HttpRequest();
-  request.open('GET', "IntentionallyMissingFile");
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/IntentionallyMissingFile';
+  request.open('GET', url);
   asyncStart();
   request.onError.listen((event) {
     UtilsHtml.show("request.onError.listen: $event");

LibTest/html/HttpRequest/onLoadEnd_A01_t01.dart

@@ -5,7 +5,7 @@
  */
 /**
  * @assertion Stream<ProgressEvent> get onLoadEnd
- * Stream of loadend events handled by this HttpRequestEventTarget.
+ * Stream of loaded events handled by this HttpRequestEventTarget.
  * @description Checks that only single event is fired.
  */
 import "dart:html";

LibTest/html/HttpRequest/onLoad_A01_t01.dart

@@ -6,7 +6,7 @@
 /**
  * @assertion final Stream<ProgressEvent> onLoad
  * Stream of load events handled by this HttpRequestEventTarget.
- * @description Checks the state of request at variuos moments of time.
+ * @description Checks the state of request at various moments of time.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";
@@ -17,6 +17,7 @@ main() {
   Expect.equals(HttpRequest.OPENED, request.readyState, "after open");
   asyncStart();
   request.onLoad.listen((event) {
+    print(event);
     switch (request.readyState) {
       case HttpRequest.DONE:
         asyncEnd();

LibTest/html/HttpRequest/onReadyStateChange_A01_t01.dart

@@ -6,7 +6,8 @@
 /**
  * @assertion Stream<ProgressEvent> get onReadyStateChange
  * Stream of readystatechange events handled by this HttpRequest.
- * Event listeners to be notified every time the HttpRequest object's readyState changes values.
+ * Event listeners to be notified every time the HttpRequest object's readyState
+ * changes values.
  * @description Checks that readyState is changed every time an event is fired.
  */
 import "dart:html";

LibTest/html/HttpRequest/overrideMimeType_A01_t01.dart

@@ -7,16 +7,20 @@
  * @assertion void overrideMimeType(String override)
  * Specify a particular MIME type (such as text/xml) desired for the response.
  * This value must be set before the request has been sent.
- * @description Checks that MIME type is overriden.
+ * @description Checks that MIME type is overridden.
  */
 import "dart:html";
 import "../../../Utils/expect.dart";
+import "../testcommon.dart";
 
-const desired = "text/plain";
+const desired = "text/plain; charset=utf-8";
 
 main() {
   var request = new HttpRequest();
-  request.open('GET', "test.dart");
+  var port = crossOriginPort;
+  var host = '${window.location.protocol}//${window.location.hostname}:$port';
+  var url = '$host/root_dart/tests/co19/src/LibTest/html/xhr_cross_origin_data.txt';
+  request.open('GET', url);
   request.overrideMimeType(desired);
   asyncStart();
   request.onLoad.listen((event) {

LibTest/html/testcommon.dart

@@ -36,3 +36,13 @@ var XlinkNamespace = "http://www.w3.org/1999/xlink";
 class NullTreeSanitizer implements NodeTreeSanitizer {
   void sanitizeTree(Node node) {}
 }
+
+int get crossOriginPort {
+  var searchUrl = window.location.search!;
+  print("SearchURL=" + searchUrl);
+  var crossOriginStr = 'crossOriginPort=';
+  var index = searchUrl.indexOf(crossOriginStr);
+  var nextArg = searchUrl.indexOf('&', index);
+  return int.parse(searchUrl.substring(index + crossOriginStr.length,
+      nextArg == -1 ? searchUrl.length : nextArg));
+}