#1399. Object member names are not allowed for positional fields names (#1513)

Authored by @sgrekhov.

Adjusting record tests. Object member names are not allowed for positional fields names. Missing parameters names added, run-time types fixed.

Author: sgrekhov

LanguageFeatures/Records/record_type_annotations_A02_t01.dart

@@ -50,7 +50,7 @@ typedef ({required int i, String s}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3(({required int i, String s}));
+typedef void R3(({required int i, String s}) r);
 //                ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -60,7 +60,7 @@ typedef void R3(({required int i, String s}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-  void bar(({required int i, String s})) {}
+  void bar(({required int i, String s}) r) {}
 //           ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A02_t02.dart

@@ -50,7 +50,7 @@ typedef ([int? i, String? s]) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3(([int? i, String? s]));
+typedef void R3(([int? i, String? s]) r);
 //               ^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -60,7 +60,7 @@ typedef void R3(([int? i, String? s]));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-  void bar(([int i, String s])) {}
+  void bar(([int i, String s]) r) {}
 //          ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A02_t10.dart

@@ -53,7 +53,7 @@ typedef ({int i, String s}, int j) R3();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R4(({int i, String s}, int));
+typedef void R4(({int i, String s}, int) r);
 //                                ^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -63,7 +63,7 @@ typedef void R4(({int i, String s}, int));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-  void bar(({int i, String s}, int j,)) {}
+  void bar(({int i, String s}, int j,) r) {}
 //                           ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A02_t12.dart

@@ -46,7 +46,7 @@ typedef void R5((int? i, {String? s})? r);
 
 (int? i, {String? s})? foo() => null;
 
-void bar((int? i, {String? s})?) {}
+void bar((int? i, {String? s})? r) {}
 
 main() {
   (int? i, String? s)? r1 = null;

LanguageFeatures/Records/record_type_annotations_A02_t13.dart

@@ -53,7 +53,7 @@ typedef (var i,) R3();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R5(({var s}));
+typedef void R5(({var s}) r);
 //                ^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -63,7 +63,7 @@ typedef void R5(({var s}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar(({var s})) {}
+void bar(({var s}) r) {}
 //         ^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A03_t01.dart

@@ -38,7 +38,7 @@ typedef ({int i, String s, int i}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3(({int i, String s, int i}));
+typedef void R3(({int i, String s, int i}) r);
 //                                     ^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -48,7 +48,7 @@ typedef void R3(({int i, String s, int i}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar(({int i, String s, String i})) {}
+void bar(({int i, String s, String i}) r) {}
 //                                 ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A03_t02.dart

@@ -48,12 +48,12 @@ typedef (int i, int i, {String s}) R4();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R5((int i, {String s, int i}));
+typedef void R5((int i, {String s, int i}) r);
 //                                     ^
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R6((int i, int i, {String s}));
+typedef void R6((int i, int i, {String s}) r);
 //                          ^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -68,12 +68,12 @@ typedef void R6((int i, int i, {String s}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar1((int i, {String s, String i})) {}
+void bar1((int i, {String s, String i}) r) {}
 //                                  ^
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar2((int i, String i, {String s})) {}
+void bar2((int i, String i, {String s}) r) {}
 //                                  ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A04_t01.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -38,7 +38,7 @@ typedef (int) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s));
+typedef void R3((String s) r);
 //              ^^^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A04_t02.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///

LanguageFeatures/Records/record_type_annotations_A04_t03.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -37,7 +37,7 @@ typedef R4 = (int i, {String s,});
 
 typedef (int, {String s,}) R5();
 
-typedef void R6(({String s, int i,}));
+typedef void R6(({String s, int i,}) r);
 
 (int, bool,) foo1() => (42, true);
 
@@ -71,6 +71,8 @@ main() {
   }
 
   d as (int, int j,);
+  d = (1, j: 2);
   d as (int, {int j,});
+  d = (i: 1, j: 2);
   d as ({int i, int j,});
 }

LanguageFeatures/Records/record_type_annotations_A04_t04.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -38,7 +38,7 @@ typedef (int, String s,,) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s, int,,));
+typedef void R3((String s, int,,) r);
 //                             ^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -53,7 +53,7 @@ typedef (int, {String s,,}) R5();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R6(({String s, int i,,}));
+typedef void R6(({String s, int i,,}) r);
 //                                ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A04_t05.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -38,7 +38,7 @@ typedef (int, {String s},) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3(({String s, int i},));
+typedef void R3(({String s, int i},) r);
 //                                ^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A04_t06.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///

LanguageFeatures/Records/record_type_annotations_A05_t01.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -23,7 +23,7 @@
 /// the getter for the first positional field.
 ///
 /// @description Checks that it is a compile-time error if a record type has a
-/// field named `hashCode`
+/// named field named `hashCode`
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records
@@ -38,7 +38,7 @@ typedef (int, {int hashCode}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s, {String hashCode}));
+typedef void R3((String s, {String hashCode}) r);
 //                                 ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -48,7 +48,7 @@ typedef void R3((String s, {String hashCode}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar((int i, {bool hashCode})) {}
+void bar((int i, {bool hashCode}) r) {}
 //                     ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A05_t02.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -23,7 +23,7 @@
 /// the getter for the first positional field.
 ///
 /// @description Checks that it is a compile-time error if a record type has a
-/// field named `runtimeType`
+/// named field named `runtimeType`
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records
@@ -38,7 +38,7 @@ typedef (int, {Type runtimeType}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s, {String runtimeType}));
+typedef void R3((String s, {String runtimeType}) r);
 //                                 ^^^^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -48,7 +48,7 @@ typedef void R3((String s, {String runtimeType}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar((int i, {Type runtimeType})) {}
+void bar((int i, {Type runtimeType}) r) {}
 //                     ^^^^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A05_t03.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -23,7 +23,7 @@
 /// the getter for the first positional field.
 ///
 /// @description Checks that it is a compile-time error if a record type has a
-/// field named `noSuchMethod`
+/// named field named `noSuchMethod`
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records
@@ -38,7 +38,7 @@ typedef (int, {Function noSuchMethod}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s, {String noSuchMethod}));
+typedef void R3((String s, {String noSuchMethod}) r);
 //                                 ^^^^^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -48,7 +48,7 @@ typedef void R3((String s, {String noSuchMethod}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar((int i, {Function noSuchMethod})) {}
+void bar((int i, {Function noSuchMethod}) r) {}
 //                         ^^^^^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified

LanguageFeatures/Records/record_type_annotations_A05_t04.dart

@@ -14,7 +14,7 @@
 /// symmetric with record expressions and leaves the potential for later support
 /// for parentheses for grouping in type expressions.
 ///
-/// A named field named hashCode, runtimeType, noSuchMethod, or toString.
+/// A field named hashCode, runtimeType, noSuchMethod, or toString.
 ///
 /// A field name that starts with an underscore.
 ///
@@ -23,7 +23,7 @@
 /// the getter for the first positional field.
 ///
 /// @description Checks that it is a compile-time error if a record type has a
-/// field named `toString`
+/// named field named `toString`
 /// @author [email protected]
 
 // SharedOptions=--enable-experiment=records
@@ -38,7 +38,7 @@ typedef (int, {int toString}) R2();
 // [analyzer] unspecified
 // [cfe] unspecified
 
-typedef void R3((String s, {String toString}));
+typedef void R3((String s, {String toString}) r);
 //                                 ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified
@@ -48,7 +48,7 @@ typedef void R3((String s, {String toString}));
 // [analyzer] unspecified
 // [cfe] unspecified
 
-void bar((int i, {bool toString})) {}
+void bar((int i, {bool toString}) r) {}
 //                     ^^^^^^^^
 // [analyzer] unspecified
 // [cfe] unspecified