Skip to content

A extension-types test expecting an error on implementing Object should be corrected #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chloestefantsova opened this issue Oct 31, 2023 · 2 comments
Closed

A extension-types test expecting an error on implementing Object should be corrected #2338

chloestefantsova opened this issue Oct 31, 2023 · 2 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@chloestefantsova
Copy link
Contributor

The following test expects a compile-time error on extension types implementing Object.

co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A10_t03.dart

Lines 35 to 38 in b1935e5

extension type ET4(Object id) implements Object {}
// ^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified

According to dart-lang/sdk#53840, an extension type can implement Object. After landing https://dart-review.googlesource.com/c/sdk/+/333000 the CFE will stop the emit the error, and the test should be updated.
@sgrekhov sgrekhov self-assigned this Nov 1, 2023
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Nov 1, 2023
@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 1, 2023

This issue is addressed by #2328. Please review

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 3, 2023

Fixed by #2328

@sgrekhov sgrekhov closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @sgrekhov