Skip to content

Update exhaustiveness tests according to the language#3524 #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgrekhov opened this issue Dec 18, 2023 · 2 comments
Closed

Update exhaustiveness tests according to the language#3524 #2439

sgrekhov opened this issue Dec 18, 2023 · 2 comments
Assignees
@sgrekhov

Comments

@sgrekhov
Copy link
Contributor

Update exhaustiveness tests according to the dart-lang/language#3524
List of the tests that should be updated can be found here https://github.com/dart-lang/co19/pull/2437/files
@sgrekhov sgrekhov added the needs-info Additional information needed from the issue author label Dec 18, 2023
@sgrekhov sgrekhov self-assigned this Dec 18, 2023
@eernstg
Copy link
Member

eernstg commented Dec 18, 2023

Thanks! The info needed is whether the language team wishes to have that always-exhaustive status propagate from an extension type erasure to the corresponding extension type. dart-lang/language#3524 should answer that question.

@eernstg eernstg mentioned this issue Dec 18, 2023
Merged
@sgrekhov sgrekhov removed the needs-info Additional information needed from the issue author label Jan 5, 2024
@sgrekhov
Copy link
Contributor Author

Closing this issue. All of the tests mentioned in #2437 works on the latest SDK. Some of the tests were failing but they now are fixed by #2450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg