Skip to content

Add test for part with multiple owners #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgrekhov opened this issue Feb 6, 2024 · 1 comment
Closed

Add test for part with multiple owners #2521

sgrekhov opened this issue Feb 6, 2024 · 1 comment
Assignees
Labels
area-test closed-obsolete Closed as the reported issue is no longer relevant

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Feb 6, 2024

Add test for part with multiple owners. Like

// multiple_owners_part.dart
part of multiple_owners_lib;
final definedInPart = "Lily was here";

// multiple_owners_owner_t01.dart
library multiple_owners_lib;
part 'multiple_owners_part.dart';

var definedInPart = "";

main() {
}

// multiple_owners_owner_t02.dart
library multiple_owners_lib;
part 'multiple_owners_part.dart';

main() {
  print(definedInPart);
}

Waiting for dart-lang/sdk#54661 and dart-lang/sdk#54836 to figure our correct error expectations

@sgrekhov sgrekhov added the status-blocked Blocked from making progress by another (referenced) issue label Feb 6, 2024
@sgrekhov sgrekhov self-assigned this Feb 6, 2024
@sgrekhov sgrekhov added area-test and removed status-blocked Blocked from making progress by another (referenced) issue labels Feb 20, 2024
@sgrekhov sgrekhov added the closed-obsolete Closed as the reported issue is no longer relevant label Oct 7, 2024
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Oct 7, 2024

Parts with import removed "< dottedIdentifier >" from a "< partHeader >", retaining only "< uri >". It's also a syntax error to have multiple "part of" directives. Therefore with "Parts with imports" feature it is not possible to have a part file with multiple owners. Closing this issue.

@sgrekhov sgrekhov closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

1 participant