Skip to content

Commit 848e384

Browse files
Address comments
1 parent 1587984 commit 848e384

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

pkgs/jnigen/test/simple_package_test/runtime_test_registrant.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -646,12 +646,12 @@ void registerTests(String groupName, TestRunnerCallback test) {
646646
final manyPrimitives = await manyPrimitivesResult.future;
647647
expect(manyPrimitives, -1 + 3 + 3.14.toInt() + 1);
648648

649+
// Running garbage collection does not work on Android. Skipping this
650+
// test on Android.
649651
// Currently we have one implementation of the interface.
650652
expect(MyInterface.$impls, hasLength(1), skip: Platform.isAndroid);
651653
myInterface.release();
652654
if (!Platform.isAndroid) {
653-
// Running garbage collection does not work on Android. Skipping this
654-
// test for android.
655655
_runJavaGC();
656656
await _waitUntil(() => MyInterface.$impls.isEmpty);
657657
expect(MyInterface.$impls, isEmpty);
@@ -691,12 +691,12 @@ void registerTests(String groupName, TestRunnerCallback test) {
691691
);
692692
expect(myInterface.manyPrimitives(1, true, 3, 4), 42);
693693

694+
// Running garbage collection does not work on Android. Skipping this
695+
// test on Android.
694696
expect(MyInterface.$impls, hasLength(1), skip: Platform.isAndroid);
695697
expect(MyRunnable.$impls, hasLength(1), skip: Platform.isAndroid);
696698
myInterface.release();
697699
if (!Platform.isAndroid) {
698-
// Running garbage collection does not work on Android. Skipping this
699-
// test for android.
700700
_runJavaGC();
701701
await _waitUntil(() => MyInterface.$impls.isEmpty);
702702
// Since the interface is now deleted, the cleaner must signal to Dart
@@ -742,12 +742,12 @@ void registerTests(String groupName, TestRunnerCallback test) {
742742
// listener, it will work.
743743
runner.runOnAnotherThreadAndJoin();
744744
await completer.future;
745+
// Running garbage collection does not work on Android. Skipping
746+
// this test on Android.
745747
expect(MyRunnable.$impls, hasLength(1), skip: Platform.isAndroid);
746748
runnable.release();
747749
runner.release();
748750
if (!Platform.isAndroid) {
749-
// Running garbage collection does not work on Android. Skipping
750-
// this test for android.
751751
_runJavaGC();
752752
await _waitUntil(() => MyInterface.$impls.isEmpty);
753753
// Since the interface is now deleted, the cleaner must signal to
@@ -762,11 +762,11 @@ void registerTests(String groupName, TestRunnerCallback test) {
762762
expect(runnable != runnable, false);
763763
expect(runnable.hashCode, runnable.hashCode);
764764
expect(runnable.toString(), runnable.toString());
765+
// Running garbage collection does not work on Android. Skipping
766+
// this test on Android.
765767
expect(MyRunnable.$impls, hasLength(1), skip: Platform.isAndroid);
766768
runnable.release();
767769
if (!Platform.isAndroid) {
768-
// Running garbage collection does not work on Android. Skipping
769-
// this test for android.
770770
_runJavaGC();
771771
await _waitUntil(() => MyInterface.$impls.isEmpty);
772772
expect(MyRunnable.$impls, isEmpty);

0 commit comments

Comments
 (0)