Skip to content

Commit d6c129e

Browse files
committed
Disable dart test in example/build/native_dynamic_linking on windows
1 parent 7e93fc5 commit d6c129e

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/native.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,10 @@ jobs:
142142

143143
- run: dart --enable-experiment=native-assets test
144144
working-directory: pkgs/${{ matrix.package }}/example/build/native_dynamic_linking/
145-
if: ${{ matrix.package == 'native_assets_cli' && matrix.sdk == 'dev' && !matrix.breaking-change }}
145+
# TODO(https://github.com/dart-lang/native/issues/190): Enable on windows once
146+
# https://github.com/dart-lang/sdk/commit/903eea6bfb8ee405587f0866a1d1e92eea45d29e
147+
# has landed in dev channel.
148+
if: ${{ matrix.package == 'native_assets_cli' && matrix.sdk == 'dev' && !matrix.breaking-change && matrix.os != 'windows' }}
146149

147150
- run: dart --enable-experiment=native-assets test
148151
working-directory: pkgs/${{ matrix.package }}/example/build/native_add_app/

pkgs/native_assets_cli/test/example/native_dynamic_linking_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
'mac-os': Timeout.factor(2),
77
'windows': Timeout.factor(10),
88
})
9-
// TODO(https://github.com/dart-lang/native/issues/190): Enable once
9+
// TODO(https://github.com/dart-lang/native/issues/190): Enable on windows once
1010
// https://github.com/dart-lang/sdk/commit/903eea6bfb8ee405587f0866a1d1e92eea45d29e
1111
// has landed in dev channel.
1212
@TestOn('!windows')

0 commit comments

Comments
 (0)