Skip to content

Commit d819b13

Browse files
committed
add tests
1 parent ceb2bec commit d819b13

File tree

2 files changed

+33
-18
lines changed

2 files changed

+33
-18
lines changed

pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart

+9-10
Original file line numberDiff line numberDiff line change
@@ -514,20 +514,18 @@ ${e.message}
514514
await dependenciesHashes.findOutdatedFileSystemEntity();
515515
if (outdatedFile == null) {
516516
logger.info(
517-
[
518-
'Skipping ${hook.name} for ${config.packageName} in $outDir.',
519-
'Last build on ${output.timestamp}.',
520-
].join(' '),
517+
'Skipping ${hook.name} for ${config.packageName}'
518+
' in ${outDir.toFilePath()}.'
519+
' Last build on ${output.timestamp}.',
521520
);
522521
// All build flags go into [outDir]. Therefore we do not have to
523522
// check here whether the config is equal.
524523
return output;
525524
}
526525
logger.info(
527-
[
528-
'Running ${hook.name} for ${config.packageName} in $outDir.',
529-
'${outdatedFile.toFilePath()} changed.',
530-
].join(' '),
526+
'Rerunning ${hook.name} for ${config.packageName}'
527+
' in ${outDir.toFilePath()}.'
528+
' ${outdatedFile.toFilePath()} changed.',
531529
);
532530
}
533531

@@ -708,7 +706,7 @@ ${e.message}
708706
if (previousDartExecutable != dartExecutable) {
709707
mustCompile = true;
710708
logger.info(
711-
'Recompiling $scriptUri, Dart executable changed.',
709+
'Recompiling ${scriptUri.toFilePath()}, Dart executable changed.',
712710
);
713711
}
714712

@@ -717,7 +715,8 @@ ${e.message}
717715
if (outdatedFile != null) {
718716
mustCompile = true;
719717
logger.info(
720-
'Recompiling $scriptUri, ${outdatedFile.toFilePath()} changed.',
718+
'Recompiling ${scriptUri.toFilePath()}, '
719+
'${outdatedFile.toFilePath()} changed.',
721720
);
722721
}
723722
}

pkgs/native_assets_builder/test/build_runner/build_runner_caching_test.dart

+24-8
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,14 @@ void main() async {
8787
await copyTestProjects(targetUri: tempUri);
8888
final packageUri = tempUri.resolve('native_add/');
8989

90+
final logMessages = <String>[];
91+
final logger = createCapturingLogger(logMessages);
92+
9093
await runPubGet(
9194
workingDirectory: packageUri,
9295
logger: logger,
9396
);
97+
logMessages.clear();
9498

9599
{
96100
final result = (await build(
@@ -105,6 +109,7 @@ void main() async {
105109
await expectSymbols(
106110
asset: CodeAsset.fromEncoded(result.encodedAssets.single),
107111
symbols: ['add']);
112+
logMessages.clear();
108113
}
109114

110115
await copyTestProjects(
@@ -122,6 +127,18 @@ void main() async {
122127
buildValidator: validateCodeAssetBuildOutput,
123128
applicationAssetValidator: validateCodeAssetInApplication,
124129
))!;
130+
131+
final cUri = packageUri.resolve('src/').resolve('native_add.c');
132+
expect(
133+
logMessages.join('\n'),
134+
stringContainsInOrder(
135+
[
136+
'Rerunning build for native_add in',
137+
'${cUri.toFilePath()} changed.'
138+
],
139+
),
140+
);
141+
125142
await expectSymbols(
126143
asset: CodeAsset.fromEncoded(result.encodedAssets.single),
127144
symbols: ['add', 'subtract'],
@@ -181,14 +198,13 @@ void main() async {
181198
buildValidator: validateCodeAssetBuildOutput,
182199
applicationAssetValidator: validateCodeAssetInApplication,
183200
))!;
184-
{
185-
final compiledHook = logMessages
186-
.where((m) =>
187-
m.contains('dart compile kernel') ||
188-
m.contains('dart.exe compile kernel'))
189-
.isNotEmpty;
190-
expect(compiledHook, isTrue);
191-
}
201+
202+
final hookUri = packageUri.resolve('hook/').resolve('build.dart');
203+
expect(
204+
logMessages.join('\n'),
205+
contains('Recompiling ${hookUri.toFilePath()}'),
206+
);
207+
192208
logMessages.clear();
193209
await expectSymbols(
194210
asset: CodeAsset.fromEncoded(result.encodedAssets.single),

0 commit comments

Comments
 (0)