[native_assets_cli] BuildOutput
behaves like a sink, should it behave like a bag?
#1167
Labels
BuildOutput
behaves like a sink, should it behave like a bag?
#1167
Currently, our
BuildOutput
behaves like aSink
. One calls add methods on it and never inspects it. This is how thebuild
method is set up as well. It constructs one sink at the start and all builders stream assets and dependencies to it. It was modeled this way because the Rust build system streams lines to stdout. (Which inherently works like a sink.)An alternative design would be to have it behave like a bag (or collection). In this case instead of passing in a
BuildOutput
to builders, they should return aBuildOutput
. And thenBuildOutput
should have a+
operator that takes anotherBuildOutput
to combine two build outputs.The text was updated successfully, but these errors were encountered: