Skip to content

Commit 9453c2d

Browse files
isoosisoos
committed
Code review updates
1 parent 3a4ddda commit 9453c2d

File tree

8 files changed

+36
-21
lines changed

8 files changed

+36
-21
lines changed

‎app/lib/frontend/color.dart

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
/// Represents an RGBA color code.
56
class Color {
67
static const black = const Color(0, 0, 0);
78
static const blue = const Color(0, 0, 255);
@@ -44,6 +45,7 @@ class Color {
4445
: 'rgba($r, $g, $b, ${a.toStringAsFixed(4)})';
4546
}
4647

48+
/// Represents the selection of colors that will be used to draw a specific shape.
4749
class Brush {
4850
final Color background;
4951
final Color color;
@@ -67,15 +69,26 @@ class Brush {
6769
}
6870
}
6971

72+
/// A semi-transparent black for using as a non-intrusive shadow.
7073
final _blackShadow = Color.black.change(a: 0.5);
74+
75+
/// Color to use when the analysis/score is missing (skipped or not done yet).
7176
final _scoreBoxMissing = new Color(204, 204, 204);
77+
78+
/// Color to use when the analysis result was top of the range (70+).
7279
final _scoreBoxSolid = new Color(1, 117, 194);
80+
81+
/// Color to use when the analysis result was in the middle of the range (40-70)
7382
final _scoreBoxGood = new Color(0, 196, 179);
83+
84+
/// Color to use when the analysis result was in the lower range (0-40)
7485
final _scoreBoxRotten = new Color(187, 36, 0);
7586

87+
/// The default set of colors to use.
7688
final _defaultBrush = new Brush(
7789
background: _scoreBoxMissing, color: Color.white, shadow: _blackShadow);
7890

91+
/// Get the [Brush] that will be used to render the overall score progress bar.
7992
Brush overallScoreBrush(double score) {
8093
if (score == null) {
8194
return _defaultBrush;
@@ -89,6 +102,8 @@ Brush overallScoreBrush(double score) {
89102
return _defaultBrush.change(background: _scoreBoxSolid);
90103
}
91104

105+
/// Get the [Brush] that will be used to render the generic score progress bars
106+
/// (e.g. popularity or health score).
92107
Brush genericScoreBrush(double score) {
93108
if (score == null) {
94109
return _defaultBrush;

‎app/test/frontend/golden/analysis_tab_aborted.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<td class="score-value">
1313

1414
<div class="score-percent-row">
15-
<div class="score-percent" style="left: 0%;">0</div>
15+
<div class="score-percent" style="left: 0%;">--</div>
1616
</div>
1717

1818
<div class="score-progress-row">
@@ -35,7 +35,7 @@
3535
</td>
3636
<td class="score-value">
3737
<div class="score-percent-row">
38-
<div class="score-percent" style="left: 0%;">0</div>
38+
<div class="score-percent" style="left: 0%;">--</div>
3939
</div>
4040

4141
<div class="score-progress-row">
@@ -57,7 +57,7 @@
5757
</td>
5858
<td class="score-value">
5959
<div class="score-percent-row">
60-
<div class="score-percent" style="left: 0%;">0</div>
60+
<div class="score-percent" style="left: 0%;">--</div>
6161
</div>
6262

6363
<div class="score-progress-row">

‎app/test/frontend/golden/analysis_tab_outdated.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<td class="score-value">
1313

1414
<div class="score-percent-row">
15-
<div class="score-percent" style="left: 0%;">0</div>
15+
<div class="score-percent" style="left: 0%;">--</div>
1616
</div>
1717

1818
<div class="score-progress-row">
@@ -35,7 +35,7 @@
3535
</td>
3636
<td class="score-value">
3737
<div class="score-percent-row">
38-
<div class="score-percent" style="left: 0%;">0</div>
38+
<div class="score-percent" style="left: 0%;">--</div>
3939
</div>
4040

4141
<div class="score-progress-row">
@@ -57,7 +57,7 @@
5757
</td>
5858
<td class="score-value">
5959
<div class="score-percent-row">
60-
<div class="score-percent" style="left: 0%;">0</div>
60+
<div class="score-percent" style="left: 0%;">--</div>
6161
</div>
6262

6363
<div class="score-progress-row">

‎app/test/frontend/golden/pkg_show_page.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ <h3>3. Import it</h3>
191191
<td class="score-value">
192192

193193
<div class="score-percent-row">
194-
<div class="score-percent" style="left: 0%;">0</div>
194+
<div class="score-percent" style="left: 0%;">--</div>
195195
</div>
196196

197197
<div class="score-progress-row">
@@ -214,7 +214,7 @@ <h3>3. Import it</h3>
214214
</td>
215215
<td class="score-value">
216216
<div class="score-percent-row">
217-
<div class="score-percent" style="left: 0%;">0</div>
217+
<div class="score-percent" style="left: 0%;">--</div>
218218
</div>
219219

220220
<div class="score-progress-row">
@@ -236,7 +236,7 @@ <h3>3. Import it</h3>
236236
</td>
237237
<td class="score-value">
238238
<div class="score-percent-row">
239-
<div class="score-percent" style="left: 0%;">0</div>
239+
<div class="score-percent" style="left: 0%;">--</div>
240240
</div>
241241

242242
<div class="score-progress-row">

‎app/test/frontend/golden/pkg_show_page_discontinued.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ <h3>3. Import it</h3>
188188
<td class="score-value">
189189

190190
<div class="score-percent-row">
191-
<div class="score-percent" style="left: 0%;">0</div>
191+
<div class="score-percent" style="left: 0%;">--</div>
192192
</div>
193193

194194
<div class="score-progress-row">
@@ -211,7 +211,7 @@ <h3>3. Import it</h3>
211211
</td>
212212
<td class="score-value">
213213
<div class="score-percent-row">
214-
<div class="score-percent" style="left: 0%;">0</div>
214+
<div class="score-percent" style="left: 0%;">--</div>
215215
</div>
216216

217217
<div class="score-progress-row">
@@ -233,7 +233,7 @@ <h3>3. Import it</h3>
233233
</td>
234234
<td class="score-value">
235235
<div class="score-percent-row">
236-
<div class="score-percent" style="left: 0%;">0</div>
236+
<div class="score-percent" style="left: 0%;">--</div>
237237
</div>
238238

239239
<div class="score-progress-row">
@@ -255,7 +255,7 @@ <h3>3. Import it</h3>
255255
</td>
256256
<td>
257257
<div class="score-percent-row">
258-
<div class="score-percent" style="left: 0%;">0</div>
258+
<div class="score-percent" style="left: 0%;">--</div>
259259
</div>
260260

261261
<div class="score-progress-row">

‎app/test/frontend/golden/pkg_show_page_outdated.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ <h3>3. Import it</h3>
189189
<td class="score-value">
190190

191191
<div class="score-percent-row">
192-
<div class="score-percent" style="left: 0%;">0</div>
192+
<div class="score-percent" style="left: 0%;">--</div>
193193
</div>
194194

195195
<div class="score-progress-row">
@@ -212,7 +212,7 @@ <h3>3. Import it</h3>
212212
</td>
213213
<td class="score-value">
214214
<div class="score-percent-row">
215-
<div class="score-percent" style="left: 0%;">0</div>
215+
<div class="score-percent" style="left: 0%;">--</div>
216216
</div>
217217

218218
<div class="score-progress-row">
@@ -234,7 +234,7 @@ <h3>3. Import it</h3>
234234
</td>
235235
<td class="score-value">
236236
<div class="score-percent-row">
237-
<div class="score-percent" style="left: 0%;">0</div>
237+
<div class="score-percent" style="left: 0%;">--</div>
238238
</div>
239239

240240
<div class="score-progress-row">
@@ -256,7 +256,7 @@ <h3>3. Import it</h3>
256256
</td>
257257
<td>
258258
<div class="score-percent-row">
259-
<div class="score-percent" style="left: 0%;">0</div>
259+
<div class="score-percent" style="left: 0%;">--</div>
260260
</div>
261261

262262
<div class="score-progress-row">

‎app/test/frontend/golden/pkg_show_version_page.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ <h3>3. Import it</h3>
193193
<td class="score-value">
194194

195195
<div class="score-percent-row">
196-
<div class="score-percent" style="left: 0%;">0</div>
196+
<div class="score-percent" style="left: 0%;">--</div>
197197
</div>
198198

199199
<div class="score-progress-row">
@@ -216,7 +216,7 @@ <h3>3. Import it</h3>
216216
</td>
217217
<td class="score-value">
218218
<div class="score-percent-row">
219-
<div class="score-percent" style="left: 0%;">0</div>
219+
<div class="score-percent" style="left: 0%;">--</div>
220220
</div>
221221

222222
<div class="score-progress-row">
@@ -238,7 +238,7 @@ <h3>3. Import it</h3>
238238
</td>
239239
<td class="score-value">
240240
<div class="score-percent-row">
241-
<div class="score-percent" style="left: 0%;">0</div>
241+
<div class="score-percent" style="left: 0%;">--</div>
242242
</div>
243243

244244
<div class="score-progress-row">

‎app/views/pkg/score_bar.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
BSD-style license that can be found in the LICENSE file. }}
44

55
<div class="score-percent-row">
6-
<div class="score-percent" style="left: {{& percent}}%;">{{percent}}</div>
6+
<div class="score-percent" style="left: {{& percent}}%;">{{score}}</div>
77
</div>
88

99
<div class="score-progress-row">

0 commit comments

Comments
 (0)