Add types to public functions (#370)

Author: kevmoo

app/lib/frontend/handlers.dart

@@ -378,7 +378,7 @@ Future<shelf.Response> packageVersionsHandler(
 
 /// Handles requests for /packages/<package>/versions/<version>
 Future<shelf.Response> packageVersionHandlerHtml(
-    request, String packageName, String versionName) async {
+    shelf.Request request, String packageName, String versionName) async {
   final Stopwatch sw = new Stopwatch()..start();
   String cachedPage;
   if (backend.uiPackageCache != null) {
@@ -455,7 +455,7 @@ Future<shelf.Response> packageVersionHandlerHtml(
 
 /// Handles requests for /packages/<package>/versions/<version>.yaml
 Future<shelf.Response> packageVersionHandlerYaml(
-    request, String package, String version) async {
+    shelf.Request request, String package, String version) async {
   final packageVersion = await backend.lookupPackageVersion(package, version);
   if (packageVersion == null) {
     return _formattedNotFoundHandler(request);
@@ -562,7 +562,7 @@ Future<shelf.Response> flutterPackagesHandler(shelf.Request request) async {
   );
 }
 
-shelf.Response _formattedNotFoundHandler(request) {
+shelf.Response _formattedNotFoundHandler(shelf.Request request) {
   final message = 'The path \'${request.requestedUri.path}\' was not found.';
   return htmlResponse(
     templateService.renderErrorPage(default404NotFound, message, null),

app/lib/frontend/service_utils.dart

@@ -43,7 +43,7 @@ void initOAuth2Service() {
   registerScopeExitCallback(client.close);
 }
 
-void initStorage(String projectId, authClient) {
+void initStorage(String projectId, http.Client authClient) {
   registerStorageService(new Storage(authClient, projectId));
 }
 

app/lib/frontend/templates.dart

@@ -159,7 +159,7 @@ class TemplateService {
       String analysisTabContent) {
     assert(versions.length == versionDownloadUrls.length);
 
-    var importExamples;
+    List importExamples;
     if (selectedVersion.libraries.contains('${package.id}.dart')) {
       importExamples = [
         {
@@ -212,16 +212,16 @@ class TemplateService {
       return null;
     }
 
-    var readmeFilename;
-    var renderedReadme;
+    String readmeFilename;
+    String renderedReadme;
     if (selectedVersion.readme != null) {
       readmeFilename = selectedVersion.readme.filename;
       renderedReadme =
           renderFile(selectedVersion.readme, selectedVersion.homepage);
     }
 
-    var changelogFilename;
-    var renderedChangelog;
+    String changelogFilename;
+    String renderedChangelog;
     if (selectedVersion.changelog != null) {
       changelogFilename = selectedVersion.changelog.filename;
       renderedChangelog =

app/lib/shared/handlers.dart

@@ -56,7 +56,8 @@ shelf.Response htmlResponse(String content, {int status: 200}) =>
       headers: {'content-type': 'text/html; charset="utf-8"'},
     );
 
-shelf.Response notFoundHandler(request, {body: default404NotFound}) =>
+shelf.Response notFoundHandler(shelf.Request request,
+        {String body: default404NotFound}) =>
     htmlResponse(body, status: 404);
 
 void logPubHeaders(shelf.Request request) {

app/lib/shared/utils.dart

@@ -77,7 +77,7 @@ String canonicalizeVersion(String version) {
 /// order "0.9.0-dev.1 < 0.8.0").  Otherwise it will use semantic version
 /// sorting (e.g. it will order "0.8.0 < 0.9.0-dev.1").
 int compareSemanticVersionsDesc(
-    semver.Version a, semver.Version b, bool decreasing, pubSorted) {
+    semver.Version a, semver.Version b, bool decreasing, bool pubSorted) {
   if (pubSorted) {
     if (decreasing) {
       return semver.Version.prioritize(b, a);