Skip to content

Pub searches should include corelibs #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Jun 22, 2017 · 6 comments
Closed

Pub searches should include corelibs #181

mit-mit opened this issue Jun 22, 2017 · 6 comments

Comments

@mit-mit
Copy link
Member

mit-mit commented Jun 22, 2017

New developers will not know if any given Dart library they are looking for is considered a core library included with the Dart SDK, or a package on pub. For example, if you need JSON parsing, is that a corelib or package?

To help with this, we propose searches on Pub also return results for corelibs.

This bug tracks a short-term solution where the searches only are based on the main Dartdoc comment (e.g. dart:convert dartdoc).

A separate bug tracks a longer term fix to search the whole API surface.

@mit-mit mit-mit added this to the M3 milestone Jun 22, 2017
@kevmoo kevmoo changed the title Pub searches should include core library main DartDoc content Pub searches should include SDK library main DartDoc content Jun 23, 2017
@kevmoo kevmoo modified the milestones: M3, M4 Oct 24, 2017
@kevmoo
Copy link
Member

kevmoo commented Oct 24, 2017

@mit-mit – punting to next release

@filiph
Copy link

filiph commented Nov 30, 2017

For the record, I think this is an important issue from the user journey perspective. We don't want the Dart ecosystem to be reinventing .groupBy, .padLeft, .reversed, UnmodifiableListView, Point or even Stream or Future/Promise. Many users are coming from ecosystems where these things are expected to be outside the core libraries.

@kevmoo
Copy link
Member

kevmoo commented Nov 30, 2017

Absolutely agree.

@mit-mit mit-mit modified the milestones: M4, Backlog Jan 15, 2018
@mit-mit mit-mit modified the milestones: Backlog, M6 Apr 9, 2018
@mit-mit mit-mit changed the title Pub searches should include SDK library main DartDoc content Pub searches should include corelibs Apr 9, 2018
@mit-mit
Copy link
Member Author

mit-mit commented Apr 9, 2018

Dartdoc search is now tracked in #1179

@jakobr-google jakobr-google modified the milestones: M6, M7 May 2, 2018
@mit-mit mit-mit modified the milestones: M7, M8 Jul 3, 2018
@isoos
Copy link
Collaborator

isoos commented Aug 29, 2018

Did some experimenting, and the current pkg/pub_dartdoc is able to output the pub-data.json the same way we are doing for normal packages. However: it takes about 4 minutes to do that, and we need to split the indexing at least by libraries, and probably store the cached values alongside the current search snapshot.

@isoos
Copy link
Collaborator

isoos commented Sep 13, 2018

This is now deployed, ranking issues should be filed separately.

@isoos isoos closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants