-
Notifications
You must be signed in to change notification settings - Fork 229
pub's binstubs should set #!/bin/bash explicitly #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Not everyone uses bash, though? Removed Type-Defect label. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 We could also just use [ ] rather than [[ ]], right? |
<img src="https://avatars.githubusercontent.com/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan They don't have to use it though, just have to have it installed, so that |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Fixed in dart-lang/sdk@86de424. Added Fixed label. |
<img src="https://avatars.githubusercontent.com/u/405837?v=3" align="left" width="48" height="48"hspace="10"> Comment by zoechi Great! Works fine now. |
<img src="https://avatars.githubusercontent.com/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan Thanks! Looks like the pub executable also uses [[, but it has #!/bin/bash. Should that be changed to be consistent with the binstubs? Not sure if the pub executable uses any other bash-specific features. Cygwin is also not properly supported by the binstubs and the pub executable, see issue #1120. This means you have to call |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3
Feel free to file an issue for this, although it's much less urgent since it's not actually breaking anyone.
I believe Cygwin is not an officially supported platform right now. |
<img src="https://avatars.githubusercontent.com/u/444270?v=3" align="left" width="96" height="96"hspace="10"> Issue by seaneagan
Originally opened as dart-lang/sdk#21854
From seaneagan/den#7:
This seems to be the culprit http://stackoverflow.com/a/17753098/217408 (/bin/sh -> dash) and dash seems not to support [[ according to the SO answer.
Do you consider changing the first line in /home/myuser/.pub-cache/bin/den to #!/bin/bash, which fixes the issue for me?
[[ is bash specific and according to http://lwn.net/Articles/343924/ the script file should set #!/bin/bash explicitly in this case. Contains some other interesting background I wasn't aware of.
The text was updated successfully, but these errors were encountered: