Skip to content

Pub can fail to load transformers necessary for local development #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 4, 2015 · 1 comment
Closed
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#23084


If a package "foo" uses a transformer from package "bar" and restricts that transformer to only run on files in "test", "bar"'s transformer won't be loaded at all. This is due to a flaw in Pub's logic for determining necessary transformers: because "bar" only runs on non-public file and isn't from the root package, pub assumes that it's not necessary. Instead, pub should check whether it's used in the root package.

This is a serious issue for the test runner: it needs to expose a transformer for its users to use, but that transformer will only be run on tests.

@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Fixed by dart-lang/sdk@fb830b7.


Added Fixed label.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Fixed labels Jun 4, 2015
@DartBot DartBot closed this as completed Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants