[cfe] Report an error on optional positional or named parameters in extension type declarations

Part of #49731

Change-Id: I49e813f9573b2b66950e8aae572591b65b62e2ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331260
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -10365,6 +10365,16 @@ Message _withArgumentsNamedMixinOverride(String name, String name2) {
       arguments: {'name': name, 'name2': name2});
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeNamedParametersInExtensionTypeDeclaration =
+    messageNamedParametersInExtensionTypeDeclaration;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageNamedParametersInExtensionTypeDeclaration =
+    const MessageCode("NamedParametersInExtensionTypeDeclaration",
+        problemMessage:
+            r"""Extension type declarations can't have named parameters.""");
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeNativeClauseShouldBeAnnotation =
     messageNativeClauseShouldBeAnnotation;
@@ -11593,6 +11603,16 @@ const MessageCode messageOperatorWithTypeParameters = const MessageCode(
         r"""Types parameters aren't allowed when defining an operator.""",
     correctionMessage: r"""Try removing the type parameters.""");
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<Null> codeOptionalParametersInExtensionTypeDeclaration =
+    messageOptionalParametersInExtensionTypeDeclaration;
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const MessageCode messageOptionalParametersInExtensionTypeDeclaration =
+    const MessageCode("OptionalParametersInExtensionTypeDeclaration",
+        problemMessage:
+            r"""Extension type declarations can't have optional parameters.""");
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<
     Message Function(

pkg/front_end/lib/src/fasta/modifier.dart

@@ -136,13 +136,18 @@ class Modifier {
   /// Method [maskContainsActualModifiers] returns `true` if the mask has any of
   /// the actual modifier bits set, and `false` otherwise.
   static bool maskContainsActualModifiers(int mask) {
-    mask &= ~(1 << mixinDeclarationMask);
-    mask &= ~(1 << hasInitializerMask);
-    mask &= ~(1 << initializingFormalMask);
-    mask &= ~(1 << declaresConstConstructorMask);
-    mask &= ~(1 << superInitializingFormalMask);
-    mask &= ~(1 << varMask);
+    mask &= ~(mixinDeclarationMask |
+        hasInitializerMask |
+        initializingFormalMask |
+        declaresConstConstructorMask |
+        superInitializingFormalMask |
+        varMask);
 
     return mask != 0;
   }
+
+  /// Sets the bit in [mask] corresponding to [requiredMask] to 0.
+  static int removeRequiredMask(int mask) {
+    return mask & ~requiredMask;
+  }
 }

pkg/front_end/lib/src/fasta/source/outline_builder.dart

@@ -1627,25 +1627,31 @@ class OutlineBuilder extends StackListenerImpl {
     bool inExtensionType =
         declarationContext == DeclarationContext.ExtensionType;
     if (formals != null) {
-      if (inExtensionType && formals.isEmpty) {
-        libraryBuilder.addProblem(
-            messageExpectedRepresentationField, charOffset, 1, uri);
-      }
-      if (inExtensionType && formals.length > 1) {
-        libraryBuilder.addProblem(
-            messageMultipleRepresentationFields, charOffset, 1, uri);
-      }
+      int requiredPositionalCount = 0;
+      int? firstNamedParameterOffset;
+      int? firstOptionalPositionalParameterOffset;
       for (int i = 0; i < formals.length; i++) {
         FormalParameterBuilder formal = formals[i];
         if (inExtensionType && formal.type is ImplicitTypeBuilder) {
           libraryBuilder.addProblem(messageExpectedRepresentationType,
               formal.charOffset, formal.name.length, formal.fileUri);
         }
         if (inExtensionType &&
-            Modifier.maskContainsActualModifiers(formal.modifiers)) {
+            Modifier.maskContainsActualModifiers(
+                Modifier.removeRequiredMask(formal.modifiers))) {
           libraryBuilder.addProblem(messageRepresentationFieldModifier,
               formal.charOffset, formal.name.length, formal.fileUri);
         }
+        if (formal.isPositional) {
+          if (formal.isOptionalPositional) {
+            firstOptionalPositionalParameterOffset = formal.charOffset;
+          } else {
+            requiredPositionalCount++;
+          }
+        }
+        if (formal.isNamed) {
+          firstNamedParameterOffset = formal.charOffset;
+        }
         libraryBuilder.addPrimaryConstructorField(
             // TODO(johnniwinther): Support annotations on annotations on fields
             // defined through a primary constructor. This is not needed for
@@ -1657,6 +1663,27 @@ class OutlineBuilder extends StackListenerImpl {
             charOffset: formal.charOffset);
         formals[i] = formal.forPrimaryConstructor(libraryBuilder);
       }
+      if (inExtensionType) {
+        if (firstOptionalPositionalParameterOffset != null) {
+          libraryBuilder.addProblem(
+              messageOptionalParametersInExtensionTypeDeclaration,
+              firstOptionalPositionalParameterOffset,
+              1,
+              uri);
+        } else if (firstNamedParameterOffset != null) {
+          libraryBuilder.addProblem(
+              messageNamedParametersInExtensionTypeDeclaration,
+              firstNamedParameterOffset,
+              1,
+              uri);
+        } else if (requiredPositionalCount == 0) {
+          libraryBuilder.addProblem(
+              messageExpectedRepresentationField, charOffset, 1, uri);
+        } else if (inExtensionType && formals.length > 1) {
+          libraryBuilder.addProblem(
+              messageMultipleRepresentationFields, charOffset, 1, uri);
+        }
+      }
     }
 
     libraryBuilder.beginNestedDeclaration(

pkg/front_end/messages.status

@@ -378,8 +378,8 @@ FastaUsageShort/analyzerCode: Fail
 FastaUsageShort/example: Fail
 FfiAbiSpecificIntegerInvalid/analyzerCode: Fail
 FfiAbiSpecificIntegerMappingInvalid/analyzerCode: Fail
-FfiCreateOfStructOrUnion/analyzerCode: Fail
 FfiCompoundImplementsFinalizable/analyzerCode: Fail
+FfiCreateOfStructOrUnion/analyzerCode: Fail
 FfiDartTypeMismatch/analyzerCode: Fail
 FfiEmptyStruct/analyzerCode: Fail
 FfiExceptionalReturnNull/analyzerCode: Fail
@@ -395,14 +395,14 @@ FfiFieldNoAnnotation/analyzerCode: Fail
 FfiFieldNull/analyzerCode: Fail
 FfiLeafCallMustNotReturnHandle/analyzerCode: Fail
 FfiLeafCallMustNotTakeHandle/analyzerCode: Fail
+FfiNativeCallableListenerReturnVoid/analyzerCode: Fail
 FfiNativeMustBeExternal/analyzerCode: Fail
 FfiNativeOnlyNativeFieldWrapperClassCanBePointer/analyzerCode: Fail
 FfiNativeUnexpectedNumberOfParameters/analyzerCode: Fail
 FfiNativeUnexpectedNumberOfParametersWithReceiver/analyzerCode: Fail
 FfiNotStatic/analyzerCode: Fail
 FfiPackedAnnotation/analyzerCode: Fail
 FfiPackedAnnotationAlignment/analyzerCode: Fail
-FfiNativeCallableListenerReturnVoid/analyzerCode: Fail
 FfiSizeAnnotation/analyzerCode: Fail
 FfiSizeAnnotationDimensions/analyzerCode: Fail
 FfiStructAnnotation/analyzerCode: Fail
@@ -616,10 +616,10 @@ JsInteropExportMemberCollision/analyzerCode: Fail # Web compiler specific
 JsInteropExportMemberCollision/example: Fail # Web compiler specific
 JsInteropExportNoExportableMembers/analyzerCode: Fail # Web compiler specific
 JsInteropExportNoExportableMembers/example: Fail # Web compiler specific
-JsInteropExtensionTypeNotInterop/analyzerCode: Fail # Web compiler specific
-JsInteropExtensionTypeNotInterop/example: Fail # Web compiler specific
 JsInteropExtensionTypeMemberNotInterop/analyzerCode: Fail # Web compiler specific
 JsInteropExtensionTypeMemberNotInterop/example: Fail # Web compiler specific
+JsInteropExtensionTypeNotInterop/analyzerCode: Fail # Web compiler specific
+JsInteropExtensionTypeNotInterop/example: Fail # Web compiler specific
 JsInteropExtensionTypeUsedWithWrongJsAnnotation/analyzerCode: Fail # Web compiler specific
 JsInteropExtensionTypeUsedWithWrongJsAnnotation/example: Fail # Web compiler specific
 JsInteropExternalExtensionMemberOnTypeInvalid/analyzerCode: Fail # Web compiler specific
@@ -628,6 +628,8 @@ JsInteropExternalExtensionMemberWithStaticDisallowed/analyzerCode: Fail # Web co
 JsInteropExternalExtensionMemberWithStaticDisallowed/example: Fail # Web compiler specific
 JsInteropExternalMemberNotJSAnnotated/analyzerCode: Fail # Web compiler specific
 JsInteropExternalMemberNotJSAnnotated/example: Fail # Web compiler specific
+JsInteropFunctionToJSRequiresStaticType/analyzerCode: Fail # Web compiler specific
+JsInteropFunctionToJSRequiresStaticType/example: Fail # Web compiler specific
 JsInteropInvalidStaticClassMemberName/analyzerCode: Fail
 JsInteropInvalidStaticClassMemberName/example: Fail
 JsInteropJSClassExtendsDartClass/analyzerCode: Fail # Web compiler specific
@@ -642,12 +644,12 @@ JsInteropNonExternalMember/analyzerCode: Fail # Web compiler specific
 JsInteropNonExternalMember/example: Fail # Web compiler specific
 JsInteropNonStaticWithStaticInteropSupertype/analyzerCode: Fail # Web compiler specific
 JsInteropNonStaticWithStaticInteropSupertype/example: Fail # Web compiler specific
+JsInteropObjectLiteralConstructorPositionalParameters/analyzerCode: Fail # Web compiler specific
+JsInteropObjectLiteralConstructorPositionalParameters/example: Fail # Web compiler specific
 JsInteropOperatorCannotBeRenamed/analyzerCode: Fail # Web compiler specific
 JsInteropOperatorCannotBeRenamed/example: Fail # Web compiler specific
 JsInteropOperatorsNotSupported/analyzerCode: Fail # Web compiler specific
 JsInteropOperatorsNotSupported/example: Fail # Web compiler specific
-JsInteropObjectLiteralConstructorPositionalParameters/analyzerCode: Fail # Web compiler specific
-JsInteropObjectLiteralConstructorPositionalParameters/example: Fail # Web compiler specific
 JsInteropStaticInteropExternalMemberWithInvalidTypeParameters/analyzerCode: Fail # Web compiler specific
 JsInteropStaticInteropExternalMemberWithInvalidTypeParameters/example: Fail # Web compiler specific
 JsInteropStaticInteropExternalTypeViolation/analyzerCode: Fail # Web compiler specific
@@ -680,8 +682,6 @@ JsInteropStaticInteropWithInvalidJsTypesSupertype/analyzerCode: Fail # Web compi
 JsInteropStaticInteropWithInvalidJsTypesSupertype/example: Fail # Web compiler specific
 JsInteropStaticInteropWithNonStaticSupertype/analyzerCode: Fail # Web compiler specific
 JsInteropStaticInteropWithNonStaticSupertype/example: Fail # Web compiler specific
-JsInteropFunctionToJSRequiresStaticType/analyzerCode: Fail # Web compiler specific
-JsInteropFunctionToJSRequiresStaticType/example: Fail # Web compiler specific
 JsInteropStrictModeForbiddenLibrary/analyzerCode: Fail # Web compiler specific
 JsInteropStrictModeForbiddenLibrary/example: Fail # Web compiler specific
 LanguageVersionInvalidInDotPackages/analyzerCode: Fail
@@ -748,6 +748,7 @@ NameNotFoundInRecordNameGet/example: Fail
 NamedFunctionExpression/example: Fail
 NamedMixinOverride/analyzerCode: Fail
 NamedMixinOverride/example: Fail
+NamedParametersInExtensionTypeDeclaration/analyzerCode: Fail
 NativeClauseShouldBeAnnotation/example: Fail
 NeverReachableSwitchDefaultError/analyzerCode: Fail
 NeverReachableSwitchDefaultError/example: Fail
@@ -868,6 +869,7 @@ OperatorParameterMismatch1/example: Fail
 OperatorParameterMismatch2/example: Fail
 OperatorWithOptionalFormals/analyzerCode: Fail
 OperatorWithOptionalFormals/example: Fail
+OptionalParametersInExtensionTypeDeclaration/analyzerCode: Fail
 OptionalSuperParameterWithoutInitializer/analyzerCode: Fail
 OptionalSuperParameterWithoutInitializer/example: Fail
 OverrideFewerNamedArguments/example: Fail

pkg/front_end/messages.yaml

@@ -7468,3 +7468,15 @@ AwaitOfExtensionTypeNotFuture:
   script: |
     extension type E(num foo) { test(E e) async { await e; } }
   analyzerCode: AWAIT_OF_EXTENSION_TYPE_NOT_FUTURE
+
+NamedParametersInExtensionTypeDeclaration:
+  problemMessage: "Extension type declarations can't have named parameters."
+  experiments: inline-class
+  script: |
+    extension type E(int foo, {dynamic bar}) {}
+
+OptionalParametersInExtensionTypeDeclaration:
+  problemMessage: "Extension type declarations can't have optional parameters."
+  experiments: inline-class
+  script: |
+    extension type E(int foo, [dynamic bar]) {}

pkg/front_end/testcases/extension_types/issue52119.dart.strong.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 // pkg/front_end/testcases/extension_types/issue52119.dart:12:26: Error: Couldn't find constructor 'Foo.unresolved'.
 //   Foo.erroneous() : this.unresolved(); // Error
 //                          ^^^^^^^^^^

pkg/front_end/testcases/extension_types/issue52119.dart.strong.transformed.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 // pkg/front_end/testcases/extension_types/issue52119.dart:12:26: Error: Couldn't find constructor 'Foo.unresolved'.
 //   Foo.erroneous() : this.unresolved(); // Error
 //                          ^^^^^^^^^^

pkg/front_end/testcases/extension_types/issue52119.dart.weak.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 // pkg/front_end/testcases/extension_types/issue52119.dart:12:26: Error: Couldn't find constructor 'Foo.unresolved'.
 //   Foo.erroneous() : this.unresolved(); // Error
 //                          ^^^^^^^^^^

pkg/front_end/testcases/extension_types/issue52119.dart.weak.modular.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 // pkg/front_end/testcases/extension_types/issue52119.dart:12:26: Error: Couldn't find constructor 'Foo.unresolved'.
 //   Foo.erroneous() : this.unresolved(); // Error
 //                          ^^^^^^^^^^

pkg/front_end/testcases/extension_types/issue52119.dart.weak.outline.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 import self as self;
 import "dart:core" as core;
 

pkg/front_end/testcases/extension_types/issue52119.dart.weak.transformed.expect

@@ -6,10 +6,6 @@ library;
 // extension type Bar<T>._(this.i) {
 //                              ^
 //
-// pkg/front_end/testcases/extension_types/issue52119.dart:15:30: Error: Representation fields can't have modifiers.
-// extension type Bar<T>._(this.i) {
-//                              ^
-//
 // pkg/front_end/testcases/extension_types/issue52119.dart:12:26: Error: Couldn't find constructor 'Foo.unresolved'.
 //   Foo.erroneous() : this.unresolved(); // Error
 //                          ^^^^^^^^^^

pkg/front_end/testcases/extension_types/representation.dart.strong.expect

@@ -17,17 +17,17 @@ library;
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
-// extension type Duplicate(bool instanceField, int instanceField) {} // Error
-//                         ^
-//
 // pkg/front_end/testcases/extension_types/representation.dart:9:50: Error: 'instanceField' is already declared in this scope.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                                                  ^^^^^^^^^^^^^
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Context: Previous declaration of 'instanceField'.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
+// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
+// extension type Duplicate(bool instanceField, int instanceField) {} // Error
+//                         ^
+//
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Error: Can't use 'instanceField' because it is declared more than once.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^

pkg/front_end/testcases/extension_types/representation.dart.strong.transformed.expect

@@ -17,17 +17,17 @@ library;
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
-// extension type Duplicate(bool instanceField, int instanceField) {} // Error
-//                         ^
-//
 // pkg/front_end/testcases/extension_types/representation.dart:9:50: Error: 'instanceField' is already declared in this scope.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                                                  ^^^^^^^^^^^^^
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Context: Previous declaration of 'instanceField'.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
+// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
+// extension type Duplicate(bool instanceField, int instanceField) {} // Error
+//                         ^
+//
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Error: Can't use 'instanceField' because it is declared more than once.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^

pkg/front_end/testcases/extension_types/representation.dart.weak.expect

@@ -17,17 +17,17 @@ library;
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
-// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
-// extension type Duplicate(bool instanceField, int instanceField) {} // Error
-//                         ^
-//
 // pkg/front_end/testcases/extension_types/representation.dart:9:50: Error: 'instanceField' is already declared in this scope.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                                                  ^^^^^^^^^^^^^
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Context: Previous declaration of 'instanceField'.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^
 //
+// pkg/front_end/testcases/extension_types/representation.dart:9:25: Error: Each extension type should have exactly one representation field.
+// extension type Duplicate(bool instanceField, int instanceField) {} // Error
+//                         ^
+//
 // pkg/front_end/testcases/extension_types/representation.dart:9:31: Error: Can't use 'instanceField' because it is declared more than once.
 // extension type Duplicate(bool instanceField, int instanceField) {} // Error
 //                               ^^^^^^^^^^^^^