[ package:vm_service ] Raise an RPCError exception instead of a String exception for in-flight requests that have been canceled via VmService.dispose

Fixes #39183

Change-Id: Iae6c40f4daa1f1315ada1a1aa7128918e557d030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126609
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

Author: bkonyi

pkg/vm_service/CHANGELOG.md

@@ -1,4 +1,8 @@
 # Changelog
+## 2.1.2
+- Requests which have not yet completed when `VmService.dispose` is invoked will
+  now complete with an `RPCError` exception rather than a `String` exception.
+
 ## 2.1.1
 - Added `getLineNumberFromTokenPos` and `getColumnNumberFromTokenPos` methods
   to `Script`.

pkg/vm_service/lib/vm_service.dart

@@ -1749,7 +1749,11 @@ class VmService implements VmServiceInterface {
 
   void dispose() {
     _streamSub.cancel();
-    _completers.values.forEach((c) => c.completeError('disposed'));
+    _completers.forEach((id, c) {
+      final method = _methodCalls[id];
+      return c.completeError(
+          RPCError(method, -32000, 'Service connection disposed'));
+    });
     _completers.clear();
     if (_disposeHandler != null) {
       _disposeHandler();

pkg/vm_service/pubspec.yaml

@@ -2,7 +2,7 @@ name: vm_service
 description: >-
   A library to communicate with a service implementing the Dart VM
   service protocol.
-version: 2.1.1
+version: 2.1.2
 
 author: Dart Team <[email protected]>
 homepage: https://github.com/dart-lang/sdk/tree/master/pkg/vm_service

pkg/vm_service/tool/dart/generate_dart.dart

@@ -103,7 +103,11 @@ final String _implCode = r'''
 
   void dispose() {
     _streamSub.cancel();
-    _completers.values.forEach((c) => c.completeError('disposed'));
+    _completers.forEach((id, c) {
+      final method = _methodCalls[id];
+      return c.completeError(
+          RPCError(method, -32000, 'Service connection disposed'));
+    });
     _completers.clear();
     if (_disposeHandler != null) {
       _disposeHandler();