Skip to content

Commit 227e218

Browse files
scheglovCommit Queue
authored and
Commit Queue
committed
Replace assertTypeAliasRef() with textual dumps.
Change-Id: Ib46a2a63ef2c6ae1429cc3e761ee7c03d29f54e0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293086 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
1 parent 3bd715f commit 227e218

File tree

3 files changed

+15
-26
lines changed

3 files changed

+15
-26
lines changed

pkg/analyzer/test/src/dart/resolution/function_reference_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3263,7 +3263,6 @@ bar() {
32633263
}
32643264
''');
32653265

3266-
assertTypeAliasRef(findNode.simple('TA.'), findElement.typeAlias('TA'));
32673266
var reference = findNode.functionReference('foo<int>;');
32683267
assertResolvedNodeText(reference, r'''
32693268
FunctionReference

pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,22 +133,21 @@ void f() {
133133
}
134134
''');
135135

136-
assertPrefixedIdentifier(
137-
findNode.prefixed('B.foo'),
138-
element: findElement.getter('foo'),
139-
type: 'int',
140-
);
141-
142-
assertTypeAliasRef(
143-
findNode.simple('B.foo'),
144-
findElement.typeAlias('B'),
145-
);
146-
147-
assertSimpleIdentifier(
148-
findNode.simple('foo;'),
149-
element: findElement.getter('foo'),
150-
type: 'int',
151-
);
136+
final node = findNode.prefixed('B.foo');
137+
assertResolvedNodeText(node, r'''
138+
PrefixedIdentifier
139+
prefix: SimpleIdentifier
140+
token: B
141+
staticElement: self::@typeAlias::B
142+
staticType: null
143+
period: .
144+
identifier: SimpleIdentifier
145+
token: foo
146+
staticElement: self::@class::A::@getter::foo
147+
staticType: int
148+
staticElement: self::@class::A::@getter::foo
149+
staticType: int
150+
''');
152151
}
153152

154153
test_implicitCall_tearOff_nullable() async {

pkg/analyzer/test/src/dart/resolution/resolution.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -528,15 +528,6 @@ mixin ResolutionTest implements ResourceProviderMixin {
528528
}
529529
}
530530

531-
/// Assert that the given [identifier] is a reference to a type alias, in the
532-
/// form that is not a separate expression, e.g. in a static method
533-
/// invocation like `C.staticMethod()`, or a type annotation `C c = null`.
534-
void assertTypeAliasRef(
535-
SimpleIdentifier identifier, TypeAliasElement expected) {
536-
assertElement(identifier, expected);
537-
assertTypeNull(identifier);
538-
}
539-
540531
void assertTypeDynamic(Object? typeOrExpression) {
541532
DartType? actual;
542533
if (typeOrExpression is DartType?) {

0 commit comments

Comments
 (0)