[analysis_server] Move CodeActions tests to shared mixins

The next CL will make CodeActions a shared handler (so it can run for both LSP and legacy servers). This moves the tests to a shared mixin (without any changes) to keep that change smaller and easier to review if the tests do end up requiring changes.

Not all tests are moved yet - plugins are not (because the plugin code is not the same across server types), not "Fix All" (because it will require some additional changes to not be LSP-specific compared to others).

Change-Id: Ib4727ef1b1cc5b96d98cdbd6e17bf4b7b2791e3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428003
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/test/lsp/code_actions_assists_test.dart

@@ -11,7 +11,7 @@ import 'package:linter/src/rules.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
-import '../tool/lsp_spec/matchers.dart';
+import '../shared/shared_code_actions_source_tests.dart';
 import 'code_actions_mixin.dart';
 import 'server_abstract.dart';
 
@@ -360,308 +360,13 @@ int? a;
 }
 
 @reflectiveTest
-class OrganizeImportsSourceCodeActionsTest
-    extends AbstractSourceCodeActionsTest {
-  Future<void> test_appliesCorrectEdits_withDocumentChangesSupport() async {
-    const content = '''
-import 'dart:math';
-import 'dart:async';
-import 'dart:convert';
-
-Completer? foo;
-int minified(int x, int y) => min(x, y);
-''';
-    const expectedContent = '''
-import 'dart:async';
-import 'dart:math';
-
-Completer? foo;
-int minified(int x, int y) => min(x, y);
-''';
-
-    await verifyCodeActionLiteralEdits(
-      content,
-      expectedContent,
-      command: Commands.organizeImports,
-    );
-  }
-
-  Future<void> test_appliesCorrectEdits_withoutDocumentChangesSupport() async {
-    const content = '''
-import 'dart:math';
-import 'dart:async';
-import 'dart:convert';
-
-Completer? foo;
-int minified(int x, int y) => min(x, y);
-''';
-    const expectedContent = '''
-import 'dart:async';
-import 'dart:math';
-
-Completer? foo;
-int minified(int x, int y) => min(x, y);
-''';
-
-    setDocumentChangesSupport(false);
-    await verifyCodeActionLiteralEdits(
-      content,
-      expectedContent,
-      command: Commands.organizeImports,
-    );
-  }
-
-  Future<void> test_availableAsCodeActionLiteral() async {
-    const content = '';
-
-    await expectCodeActionLiteral(content, command: Commands.organizeImports);
-  }
-
-  Future<void> test_availableAsCommand() async {
-    createFile(testFilePath, '');
-    setSupportedCodeActionKinds(null); // no codeActionLiteralSupport
-    await initializeServer();
-
-    var actions = await getCodeActions(testFileUri);
-    var action = findCommand(actions, Commands.organizeImports)!;
-    action.map(
-      (codeActionLiteral) => throw 'Expected command, got codeActionLiteral',
-      (command) {},
-    );
-  }
-
-  Future<void> test_fileHasErrors_failsSilentlyForAutomatic() async {
-    failTestOnErrorDiagnostic = false;
-    var content = 'invalid dart code';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.organizeImports,
-      triggerKind: CodeActionTriggerKind.Automatic,
-    );
-    var command = codeAction.command!;
-
-    // Expect a valid null result.
-    var response = await executeCommand(command);
-    expect(response, isNull);
-  }
-
-  Future<void> test_fileHasErrors_failsWithErrorForManual() async {
-    failTestOnErrorDiagnostic = false;
-    var content = 'invalid dart code';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.organizeImports,
-    );
-    var command = codeAction.command!;
-
-    // Ensure the request returned an error (error responses are thrown by
-    // the test helper to make consuming success results simpler).
-    await expectLater(
-      executeCommand(command),
-      throwsA(isResponseError(ServerErrorCodes.FileHasErrors)),
-    );
-  }
-
-  Future<void> test_filtersCorrectly() async {
-    createFile(testFilePath, '');
-    await initializeServer();
-
-    ofKind(CodeActionKind kind) => getCodeActions(testFileUri, kinds: [kind]);
-
-    expect(await ofKind(CodeActionKind.Source), hasLength(3));
-    expect(await ofKind(CodeActionKind.SourceOrganizeImports), hasLength(1));
-    expect(await ofKind(DartCodeActionKind.SortMembers), hasLength(1));
-    expect(await ofKind(DartCodeActionKind.FixAll), hasLength(1));
-    expect(await ofKind(CodeActionKind('source.foo')), isEmpty);
-    expect(await ofKind(CodeActionKind.Refactor), isEmpty);
-  }
-
-  Future<void> test_noEdits() async {
-    const content = '''
-import 'dart:async';
-import 'dart:math';
-
-Completer? foo;
-int minified(int x, int y) => min(x, y);
-''';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.organizeImports,
-    );
-    var command = codeAction.command!;
-
-    // Execute the command and it should return without needing us to process
-    // a workspace/applyEdit command because there were no edits.
-    var commandResponse = await executeCommand(command);
-    // Successful edits return an empty success() response.
-    expect(commandResponse, isNull);
-  }
-
-  Future<void> test_unavailableWhenNotRequested() async {
-    var content = '';
-
-    setSupportedCodeActionKinds([CodeActionKind.Refactor]); // not Source
-    await expectNoAction(content, command: Commands.organizeImports);
-  }
-
-  Future<void> test_unavailableWithoutApplyEditSupport() async {
-    var content = '';
-
-    setApplyEditSupport(false);
-    await expectNoAction(content, command: Commands.organizeImports);
-  }
-}
+class OrganizeImportsSourceCodeActionsTest extends AbstractSourceCodeActionsTest
+    with
+        // Most tests are defined in a shared mixin.
+        SharedOrganizeImportsSourceCodeActionsTests {}
 
 @reflectiveTest
-class SortMembersSourceCodeActionsTest extends AbstractSourceCodeActionsTest {
-  Future<void> test_appliesCorrectEdits_withDocumentChangesSupport() async {
-    const content = '''
-String? b;
-String? a;
-''';
-    const expectedContent = '''
-String? a;
-String? b;
-''';
-
-    await verifyCodeActionLiteralEdits(
-      content,
-      expectedContent,
-      command: Commands.sortMembers,
-    );
-  }
-
-  Future<void> test_appliesCorrectEdits_withoutDocumentChangesSupport() async {
-    const content = '''
-String? b;
-String? a;
-''';
-    const expectedContent = '''
-String? a;
-String? b;
-''';
-
-    setDocumentChangesSupport(false);
-    await verifyCodeActionLiteralEdits(
-      content,
-      expectedContent,
-      command: Commands.sortMembers,
-    );
-  }
-
-  Future<void> test_availableAsCodeActionLiteral() async {
-    const content = '';
-
-    await expectCodeActionLiteral(content, command: Commands.sortMembers);
-  }
-
-  Future<void> test_availableAsCommand() async {
-    createFile(testFilePath, '');
-    setSupportedCodeActionKinds(null); // no codeActionLiteralSupport
-    await initializeServer();
-
-    var actions = await getCodeActions(testFileUri);
-    var action = findCommand(actions, Commands.sortMembers)!;
-    action.map(
-      (codeActionLiteral) => throw 'Expected command, got codeActionLiteral',
-      (command) {},
-    );
-  }
-
-  Future<void> test_failsIfClientDoesntApplyEdits() async {
-    const content = '''
-String? b;
-String? a;
-''';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.sortMembers,
-    );
-    var command = codeAction.command!;
-
-    var commandResponse = handleExpectedRequest<
-      Object?,
-      ApplyWorkspaceEditParams,
-      ApplyWorkspaceEditResult
-    >(
-      Method.workspace_applyEdit,
-      ApplyWorkspaceEditParams.fromJson,
-      () => executeCommand(command),
-      // Claim that we failed tpo apply the edits. This is what the client
-      // would do if the edits provided were for an old version of the
-      // document.
-      handler:
-          (edit) => ApplyWorkspaceEditResult(
-            applied: false,
-            failureReason: 'Document changed',
-          ),
-    );
-
-    // Ensure the request returned an error (error responses are thrown by
-    // the test helper to make consuming success results simpler).
-    await expectLater(
-      commandResponse,
-      throwsA(isResponseError(ServerErrorCodes.ClientFailedToApplyEdit)),
-    );
-  }
-
-  Future<void> test_fileHasErrors_failsSilentlyForAutomatic() async {
-    failTestOnErrorDiagnostic = false;
-    var content = 'invalid dart code';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.sortMembers,
-      triggerKind: CodeActionTriggerKind.Automatic,
-    );
-    var command = codeAction.command!;
-
-    // Expect a valid null result.
-    var response = await executeCommand(command);
-    expect(response, isNull);
-  }
-
-  Future<void> test_fileHasErrors_failsWithErrorForManual() async {
-    failTestOnErrorDiagnostic = false;
-    var content = 'invalid dart code';
-
-    var codeAction = await expectCodeActionLiteral(
-      content,
-      command: Commands.sortMembers,
-    );
-    var command = codeAction.command!;
-
-    // Ensure the request returned an error (error responses are thrown by
-    // the test helper to make consuming success results simpler).
-    await expectLater(
-      executeCommand(command),
-      throwsA(isResponseError(ServerErrorCodes.FileHasErrors)),
-    );
-  }
-
-  Future<void> test_nonDartFile() async {
-    await expectNoAction(
-      filePath: pubspecFilePath,
-      simplePubspecContent,
-      command: Commands.sortMembers,
-    );
-  }
-
-  Future<void> test_unavailableWhenNotRequested() async {
-    var content = '';
-
-    setSupportedCodeActionKinds([CodeActionKind.Refactor]); // not Source
-    await expectNoAction(content, command: Commands.sortMembers);
-  }
-
-  Future<void> test_unavailableWithoutApplyEditSupport() async {
-    var content = '';
-
-    setApplyEditSupport(false);
-    await expectNoAction(content, command: Commands.sortMembers);
-  }
-}
+class SortMembersSourceCodeActionsTest extends AbstractSourceCodeActionsTest
+    with
+        // Most tests are defined in a shared mixin.
+        SharedSortMembersSourceCodeActionsTests {}