Skip to content

Commit 3b243a0

Browse files
DanTupcommit-bot@chromium.org
authored andcommitted
Recurse through lists/maps when generating hash codes in LSP types
Change-Id: I06117fe33c7bfb8553e9930afbf7e3bdc86c6032 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151230 Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 48f2d10 commit 3b243a0

File tree

5 files changed

+95
-66
lines changed

5 files changed

+95
-66
lines changed

pkg/analysis_server/lib/lsp_protocol/protocol_custom_generated.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -846,11 +846,11 @@ class FlutterOutline implements ToJsonable {
846846
hash = JenkinsSmiHash.combine(hash, label.hashCode);
847847
hash = JenkinsSmiHash.combine(hash, className.hashCode);
848848
hash = JenkinsSmiHash.combine(hash, variableName.hashCode);
849-
hash = JenkinsSmiHash.combine(hash, attributes.hashCode);
849+
hash = JenkinsSmiHash.combine(hash, lspHashCode(attributes));
850850
hash = JenkinsSmiHash.combine(hash, dartElement.hashCode);
851851
hash = JenkinsSmiHash.combine(hash, range.hashCode);
852852
hash = JenkinsSmiHash.combine(hash, codeRange.hashCode);
853-
hash = JenkinsSmiHash.combine(hash, children.hashCode);
853+
hash = JenkinsSmiHash.combine(hash, lspHashCode(children));
854854
return JenkinsSmiHash.finish(hash);
855855
}
856856

@@ -1106,7 +1106,7 @@ class Outline implements ToJsonable {
11061106
hash = JenkinsSmiHash.combine(hash, element.hashCode);
11071107
hash = JenkinsSmiHash.combine(hash, range.hashCode);
11081108
hash = JenkinsSmiHash.combine(hash, codeRange.hashCode);
1109-
hash = JenkinsSmiHash.combine(hash, children.hashCode);
1109+
hash = JenkinsSmiHash.combine(hash, lspHashCode(children));
11101110
return JenkinsSmiHash.finish(hash);
11111111
}
11121112

@@ -1206,7 +1206,7 @@ class PublishClosingLabelsParams implements ToJsonable {
12061206
int get hashCode {
12071207
var hash = 0;
12081208
hash = JenkinsSmiHash.combine(hash, uri.hashCode);
1209-
hash = JenkinsSmiHash.combine(hash, labels.hashCode);
1209+
hash = JenkinsSmiHash.combine(hash, lspHashCode(labels));
12101210
return JenkinsSmiHash.finish(hash);
12111211
}
12121212

0 commit comments

Comments
 (0)