Registration-based approach to cross frame support.

This approach installs all Dart extension types onto a window whenever
that window is accessed.

See #28326

[email protected]

Review-Url: https://codereview.chromium.org/2980853002 .

Author: vsmenon

pkg/dev_compiler/lib/js/amd/dart_sdk.js

@@ -1785,11 +1785,8 @@ class CodeGenerator extends Object
   void _registerExtensionType(
       ClassElement classElem, String jsPeerName, List<JS.Statement> body) {
     if (jsPeerName != null) {
-      body.add(_callHelperStatement('registerExtension(#.global.#, #);', [
-        _runtimeModule,
-        _propertyName(jsPeerName),
-        _emitTopLevelName(classElem)
-      ]));
+      body.add(_callHelperStatement('registerExtension(#, #);',
+          [js.string(jsPeerName), _emitTopLevelName(classElem)]));
     }
   }
 

pkg/dev_compiler/lib/js/amd/dart_sdk.js.map

@@ -63,7 +63,8 @@ import 'dart:_js_helper'
         ForceInline,
         findDispatchTagForInterceptorClass,
         setNativeSubclassDispatchRecord,
-        makeLeafDispatchRecord;
+        makeLeafDispatchRecord,
+        registerGlobalObject;
 import 'dart:_interceptors'
     show
         Interceptor,
@@ -4301,15 +4302,11 @@ class CssStyleDeclaration extends Interceptor with CssStyleDeclarationBase {
   /// Please note the property name uses camelCase, not-hyphens.
   String getPropertyValue(String propertyName) {
     var propValue = _getPropertyValueHelper(propertyName);
-    return propValue != null ? propValue : '';
+    return propValue ?? '';
   }
 
   String _getPropertyValueHelper(String propertyName) {
-    if (_supportsProperty(_camelCase(propertyName))) {
-      return _getPropertyValue(propertyName);
-    } else {
-      return _getPropertyValue(Device.cssPrefix + propertyName);
-    }
+    return _getPropertyValue(_browserPropertyName(propertyName));
   }
 
   /**
@@ -4322,7 +4319,7 @@ class CssStyleDeclaration extends Interceptor with CssStyleDeclarationBase {
    */
   bool supportsProperty(String propertyName) {
     return _supportsProperty(propertyName) ||
-        _supportsProperty(_camelCase(Device.cssPrefix + propertyName));
+        _supportsProperty(_camelCase("${Device.cssPrefix}$propertyName"));
   }
 
   bool _supportsProperty(String propertyName) {
@@ -4338,15 +4335,23 @@ class CssStyleDeclaration extends Interceptor with CssStyleDeclarationBase {
   String _browserPropertyName(String propertyName) {
     String name = _readCache(propertyName);
     if (name is String) return name;
-    if (_supportsProperty(_camelCase(propertyName))) {
-      name = propertyName;
-    } else {
-      name = Device.cssPrefix + propertyName;
-    }
+    name = _supportedBrowserPropertyName(propertyName);
     _writeCache(propertyName, name);
     return name;
   }
 
+  String _supportedBrowserPropertyName(String propertyName) {
+    if (_supportsProperty(_camelCase(propertyName))) {
+      return propertyName;
+    }
+    var prefixed = "${Device.cssPrefix}$propertyName";
+    if (_supportsProperty(prefixed)) {
+      return prefixed;
+    }
+    // May be a CSS variable, just use it as provided.
+    return propertyName;
+  }
+
   static final _propertyCache = JS('', '{}');
   static String _readCache(String key) =>
       JS('String|Null', '#[#]', _propertyCache, key);
@@ -45868,6 +45873,7 @@ class _DOMWindowCrossFrame implements WindowBase {
       return w;
     } else {
       // TODO(vsm): Cache or implement equality.
+      registerGlobalObject(w);
       return new _DOMWindowCrossFrame(w);
     }
   }

pkg/dev_compiler/lib/js/common/dart_sdk.js

@@ -439,14 +439,13 @@ void _installPropertiesForObject(jsProto) {
   }
 }
 
-/// Copy symbols from the prototype of the source to destination.
-/// These are the only properties safe to copy onto an existing public
-/// JavaScript class.
-registerExtension(jsType, dartExtType) => JS(
+final _extensionMap = JS('', 'new Map()');
+
+_applyExtension(jsType, dartExtType) => JS(
     '',
     '''(() => {
   // TODO(vsm): Not all registered js types are real.
-  if (!jsType) return;
+  if (!$jsType) return;
 
   let jsProto = $jsType.prototype;
 
@@ -471,6 +470,22 @@ registerExtension(jsType, dartExtType) => JS(
   updateSig($_setterSig);
 })()''');
 
+/// Apply all registered extensions to a window.  This is intended for
+/// different frames, where registrations need to be reapplied.
+applyAllExtensions(global) {
+  JS('', '#.forEach((dartExtType, name) => #(#[name], dartExtType))',
+      _extensionMap, _applyExtension, global);
+}
+
+/// Copy symbols from the prototype of the source to destination.
+/// These are the only properties safe to copy onto an existing public
+/// JavaScript class.
+registerExtension(name, dartExtType) {
+  JS('', '#.set(#, #)', _extensionMap, name, dartExtType);
+  var jsType = JS('', '#[#]', global_, name);
+  _applyExtension(jsType, dartExtType);
+}
+
 ///
 /// Mark a concrete type as implementing extension methods.
 /// For example: `class MyIter implements Iterable`.

pkg/dev_compiler/lib/js/common/dart_sdk.js.map

@@ -36,69 +36,79 @@ part 'utils.dart';
 // TODO(vsm): Move polyfill code to dart:html.
 // Note, native extensions are registered onto types in dart.global.
 // This polyfill needs to run before the corresponding dart:html code is run.
-@JSExportName('global')
-final global_ = JS(
+final polyfill = JS(
     '',
     '''
-  function () {
-    if (typeof NodeList !== "undefined") {
-      // TODO(vsm): Do we still need these?
-      NodeList.prototype.get = function(i) { return this[i]; };
-      NamedNodeMap.prototype.get = function(i) { return this[i]; };
-      DOMTokenList.prototype.get = function(i) { return this[i]; };
-      HTMLCollection.prototype.get = function(i) { return this[i]; };
+function (window) {
+  if (typeof window.NodeList !== "undefined") {
+    // TODO(vsm): Do we still need these?
+    window.NodeList.prototype.get = function(i) { return this[i]; };
+    window.NamedNodeMap.prototype.get = function(i) { return this[i]; };
+    window.DOMTokenList.prototype.get = function(i) { return this[i]; };
+    window.HTMLCollection.prototype.get = function(i) { return this[i]; };
 
-      // Expose constructors for DOM types dart:html needs to assume are
-      // available on window.
-      if (typeof PannerNode == "undefined") {
-        let audioContext;
-        if (typeof AudioContext == "undefined" &&
-            (typeof webkitAudioContext != "undefined")) {
-          audioContext = new webkitAudioContext();
-        } else {
-          audioContext = new AudioContext();
-          window.StereoPannerNode =
-              audioContext.createStereoPanner().constructor;
-        }
-        window.PannerNode = audioContext.createPanner().constructor;
-      }
-      if (typeof AudioSourceNode == "undefined") {
-        window.AudioSourceNode = MediaElementAudioSourceNode.__proto__;
-      }
-      if (typeof FontFaceSet == "undefined") {
-        // CSS Font Loading is not supported on Edge.
-        if (typeof document.fonts != "undefined") {
-          window.FontFaceSet = document.fonts.__proto__.constructor;
-        }
-      }
-      if (typeof MemoryInfo == "undefined") {
-        if (typeof window.performance.memory != "undefined") {
-          window.MemoryInfo = window.performance.memory.constructor;
-        }
+    // Expose constructors for DOM types dart:html needs to assume are
+    // available on window.
+    if (typeof window.PannerNode == "undefined") {
+      let audioContext;
+      if (typeof window.AudioContext == "undefined" &&
+          (typeof window.webkitAudioContext != "undefined")) {
+        audioContext = new window.webkitAudioContext();
+      } else {
+        audioContext = new window.AudioContext();
+        window.StereoPannerNode =
+            audioContext.createStereoPanner().constructor;
       }
-      if (typeof Geolocation == "undefined") {
-        navigator.geolocation.constructor;
-      }
-      if (typeof Animation == "undefined") {
-        let d = document.createElement('div');
-        if (typeof d.animate != "undefined") {
-          window.Animation = d.animate(d).constructor;
-        }
+      window.PannerNode = audioContext.createPanner().constructor;
+    }
+    if (typeof window.AudioSourceNode == "undefined") {
+      window.AudioSourceNode = MediaElementAudioSourceNode.__proto__;
+    }
+    if (typeof window.FontFaceSet == "undefined") {
+      // CSS Font Loading is not supported on Edge.
+      if (typeof window.document.fonts != "undefined") {
+        window.FontFaceSet = window.document.fonts.__proto__.constructor;
       }
-      if (typeof SourceBufferList == "undefined") {
-        window.SourceBufferList = new MediaSource().sourceBuffers.constructor;
+    }
+    if (typeof window.MemoryInfo == "undefined") {
+      if (typeof window.performance.memory != "undefined") {
+        window.MemoryInfo = window.performance.memory.constructor;
       }
-      if (typeof SpeechRecognition == "undefined") {
-        window.SpeechRecognition = window.webkitSpeechRecognition;
-        window.SpeechRecognitionError = window.webkitSpeechRecognitionError;
-        window.SpeechRecognitionEvent = window.webkitSpeechRecognitionEvent;
+    }
+    if (typeof window.Geolocation == "undefined") {
+      window.Geolocation == window.navigator.geolocation.constructor;
+    }
+    if (typeof window.Animation == "undefined") {
+      let d = window.document.createElement('div');
+      if (typeof d.animate != "undefined") {
+        window.Animation = d.animate(d).constructor;
       }
     }
+    if (typeof window.SourceBufferList == "undefined") {
+      window.SourceBufferList =
+        new window.MediaSource().sourceBuffers.constructor;
+    }
+    if (typeof window.SpeechRecognition == "undefined") {
+      window.SpeechRecognition = window.webkitSpeechRecognition;
+      window.SpeechRecognitionError = window.webkitSpeechRecognitionError;
+      window.SpeechRecognitionEvent = window.webkitSpeechRecognitionEvent;
+    }
+  }
+}
+''');
 
+@JSExportName('global')
+final global_ = JS(
+    '',
+    '''
+  function () {
+    // Find global object.
     var globalState = (typeof window != "undefined") ? window
       : (typeof global != "undefined") ? global
       : (typeof self != "undefined") ? self : {};
 
+    $polyfill(globalState);
+
     // These settings must be configured before the application starts so that
     // user code runs with the correct configuration.
     let settings = 'ddcSettings' in globalState ? globalState.ddcSettings : {};

pkg/dev_compiler/lib/js/es6/dart_sdk.js

@@ -907,5 +907,9 @@ class BooleanConversionAssertionError extends AssertionError {
   toString() => 'Failed assertion: boolean expression must not be null';
 }
 
-// Hook to register new global object.
-void registerGlobalObject(object) {}
+// Hook to register new global object.  This is invoked from dart:html
+// whenever a new window is accessed for the first time.
+void registerGlobalObject(object) {
+  dart.polyfill(object);
+  dart.applyAllExtensions(object);
+}

pkg/dev_compiler/lib/js/es6/dart_sdk.js.map

@@ -1,36 +1,36 @@
-[warning] The final variable 'origin' must be initialized. (dart:html, line 192, col 3)
-[warning] The final variable 'origin' must be initialized. (dart:html, line 862, col 3)
-[warning] The final variables 'form', 'labels' and '3' more must be initialized. (dart:html, line 1678, col 3)
-[warning] The final variable 'options' must be initialized. (dart:html, line 8974, col 3)
-[warning] The final variables '_attributes', '_childElementCount' and '19' more must be initialized. (dart:html, line 13234, col 3)
-[warning] The final variables 'elements', 'form' and '4' more must be initialized. (dart:html, line 17110, col 3)
-[warning] The final variable 'length' must be initialized. (dart:html, line 18060, col 3)
-[warning] The final variables '_get_contentWindow' and 'sandbox' must be initialized. (dart:html, line 20772, col 3)
-[warning] The final variables 'complete', 'currentSrc' and '2' more must be initialized. (dart:html, line 20979, col 3)
-[warning] The final variables '_get_valueAsDate', 'entries' and '6' more must be initialized. (dart:html, line 21144, col 3)
-[warning] The final variables 'form', 'labels' and '4' more must be initialized. (dart:html, line 22354, col 3)
-[warning] The final variables 'control' and 'form' must be initialized. (dart:html, line 22501, col 3)
-[warning] The final variable 'form' must be initialized. (dart:html, line 22540, col 3)
-[warning] The final variables 'import', 'relList' and '2' more must be initialized. (dart:html, line 22629, col 3)
-[warning] The final variable 'areas' must be initialized. (dart:html, line 22792, col 3)
-[warning] The final variables 'audioDecodedByteCount', 'audioTracks' and '16' more must be initialized. (dart:html, line 23093, col 3)
-[warning] The final variable 'labels' must be initialized. (dart:html, line 24687, col 3)
-[warning] The final variables 'baseUri', 'childNodes' and '11' more must be initialized. (dart:html, line 26231, col 3)
-[warning] The final variables 'form', 'validationMessage' and '2' more must be initialized. (dart:html, line 27183, col 3)
-[warning] The final variables 'form' and 'index' must be initialized. (dart:html, line 27365, col 3)
-[warning] The final variables 'form', 'htmlFor' and '5' more must be initialized. (dart:html, line 27419, col 3)
-[warning] The final variables 'labels' and 'position' must be initialized. (dart:html, line 28981, col 3)
-[warning] The final variables 'form', 'labels' and '4' more must be initialized. (dart:html, line 30910, col 3)
-[warning] The final variable 'sheet' must be initialized. (dart:html, line 33385, col 3)
-[warning] The final variable 'cellIndex' must be initialized. (dart:html, line 33650, col 3)
-[warning] The final variables '_rows' and '_tBodies' must be initialized. (dart:html, line 33769, col 3)
-[warning] The final variables '_cells', 'rowIndex' and '1' more must be initialized. (dart:html, line 33886, col 3)
-[warning] The final variable '_rows' must be initialized. (dart:html, line 33955, col 3)
-[warning] The final variable 'content' must be initialized. (dart:html, line 33999, col 3)
-[warning] The final variables 'form', 'labels' and '5' more must be initialized. (dart:html, line 34088, col 3)
-[warning] The final variables 'readyState' and 'track' must be initialized. (dart:html, line 35148, col 3)
-[warning] The final variables 'decodedFrameCount', 'droppedFrameCount' and '2' more must be initialized. (dart:html, line 36055, col 3)
-[warning] The final variable 'sourceCapabilities' must be initialized. (dart:html, line 46032, col 3)
+[warning] The final variable 'origin' must be initialized. (dart:html, line 193, col 3)
+[warning] The final variable 'origin' must be initialized. (dart:html, line 863, col 3)
+[warning] The final variables 'form', 'labels' and '3' more must be initialized. (dart:html, line 1679, col 3)
+[warning] The final variable 'options' must be initialized. (dart:html, line 8979, col 3)
+[warning] The final variables '_attributes', '_childElementCount' and '19' more must be initialized. (dart:html, line 13239, col 3)
+[warning] The final variables 'elements', 'form' and '4' more must be initialized. (dart:html, line 17115, col 3)
+[warning] The final variable 'length' must be initialized. (dart:html, line 18065, col 3)
+[warning] The final variables '_get_contentWindow' and 'sandbox' must be initialized. (dart:html, line 20777, col 3)
+[warning] The final variables 'complete', 'currentSrc' and '2' more must be initialized. (dart:html, line 20984, col 3)
+[warning] The final variables '_get_valueAsDate', 'entries' and '6' more must be initialized. (dart:html, line 21149, col 3)
+[warning] The final variables 'form', 'labels' and '4' more must be initialized. (dart:html, line 22359, col 3)
+[warning] The final variables 'control' and 'form' must be initialized. (dart:html, line 22506, col 3)
+[warning] The final variable 'form' must be initialized. (dart:html, line 22545, col 3)
+[warning] The final variables 'import', 'relList' and '2' more must be initialized. (dart:html, line 22634, col 3)
+[warning] The final variable 'areas' must be initialized. (dart:html, line 22797, col 3)
+[warning] The final variables 'audioDecodedByteCount', 'audioTracks' and '16' more must be initialized. (dart:html, line 23098, col 3)
+[warning] The final variable 'labels' must be initialized. (dart:html, line 24692, col 3)
+[warning] The final variables 'baseUri', 'childNodes' and '11' more must be initialized. (dart:html, line 26236, col 3)
+[warning] The final variables 'form', 'validationMessage' and '2' more must be initialized. (dart:html, line 27188, col 3)
+[warning] The final variables 'form' and 'index' must be initialized. (dart:html, line 27370, col 3)
+[warning] The final variables 'form', 'htmlFor' and '5' more must be initialized. (dart:html, line 27424, col 3)
+[warning] The final variables 'labels' and 'position' must be initialized. (dart:html, line 28986, col 3)
+[warning] The final variables 'form', 'labels' and '4' more must be initialized. (dart:html, line 30915, col 3)
+[warning] The final variable 'sheet' must be initialized. (dart:html, line 33390, col 3)
+[warning] The final variable 'cellIndex' must be initialized. (dart:html, line 33655, col 3)
+[warning] The final variables '_rows' and '_tBodies' must be initialized. (dart:html, line 33774, col 3)
+[warning] The final variables '_cells', 'rowIndex' and '1' more must be initialized. (dart:html, line 33891, col 3)
+[warning] The final variable '_rows' must be initialized. (dart:html, line 33960, col 3)
+[warning] The final variable 'content' must be initialized. (dart:html, line 34004, col 3)
+[warning] The final variables 'form', 'labels' and '5' more must be initialized. (dart:html, line 34093, col 3)
+[warning] The final variables 'readyState' and 'track' must be initialized. (dart:html, line 35153, col 3)
+[warning] The final variables 'decodedFrameCount', 'droppedFrameCount' and '2' more must be initialized. (dart:html, line 36060, col 3)
+[warning] The final variable 'sourceCapabilities' must be initialized. (dart:html, line 46038, col 3)
 [warning] The final variables 'href' and 'target' must be initialized. (dart:svg, line 56, col 3)
 [warning] The final variables 'requiredExtensions', 'requiredFeatures' and '2' more must be initialized. (dart:svg, line 512, col 3)
 [warning] The final variables 'cx', 'cy' and '1' more must be initialized. (dart:svg, line 583, col 3)