Skip to content

Commit 5619ec5

Browse files
pqcommit-bot@chromium.org
authored andcommitted
prefer “exclude” language for excluded entities
See for example: * https://9to5google.com/2020/06/12/google-android-chrome-blacklist-blocklist-more-inclusive/ * https://thenextweb.com/dd/2020/06/15/github-plans-to-replace-racially-insensitive-terms-like-master-and-whitelist/ Change-Id: I51fe56bb7a09c5cc3280119e2c121aac86e44f8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151303 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
1 parent cf1681e commit 5619ec5

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

runtime/tools/dartfuzz/gen_api_table.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ void addToTable(String ret, String name, List<String> proto,
609609
}
610610
// Avoid the exit function and other functions that give false divergences.
611611
// Note: to prevent certain constructors from being emitted, update the
612-
// blacklist in `shouldFilterConstructor` in gen_type_table.dart and
612+
// exclude list in `shouldFilterConstructor` in gen_type_table.dart and
613613
// regenerate the type table.
614614
if (name == 'exit' ||
615615
name == 'pid' ||

runtime/tools/dartfuzz/gen_type_table.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -866,11 +866,11 @@ void filterOperators(Set<InterfaceType> allTypes) {
866866
}
867867
}
868868

869-
// Filters methods based on a manually maintained blacklist.
869+
// Filters methods based on a manually maintained exclude list.
870870
//
871-
// Blacklisted methods should be associated with an issue number so they can be
871+
// Excluded methods should be associated with an issue number so they can be
872872
// re-enabled after the issue is resolved.
873-
bool isBlacklistedMethod(InterfaceType tp, MethodElement method) {
873+
bool isExcludedMethod(InterfaceType tp, MethodElement method) {
874874
// TODO(bkonyi): Enable operator / for these types after we resolve
875875
// https://github.com/dart-lang/sdk/issues/39890
876876
if (((tp.displayName == 'Float32x4') && (method.name == '/')) ||
@@ -888,8 +888,8 @@ bool isBlacklistedMethod(InterfaceType tp, MethodElement method) {
888888
// Does not recurse into interfaces and superclasses of tp.
889889
void getOperatorsForTyp(String typName, InterfaceType tp, fromLiteral) {
890890
for (MethodElement method in tp.methods) {
891-
// If the method is manually blacklisted, skip it.
892-
if (isBlacklistedMethod(tp, method)) continue;
891+
// If the method is manually excluded, skip it.
892+
if (isExcludedMethod(tp, method)) continue;
893893

894894
// Detect whether tp can be parsed from a literal (dartfuzz.dart can
895895
// already handle that).
@@ -1035,7 +1035,7 @@ bool shouldFilterConstructor(InterfaceType tp, ConstructorElement cons) {
10351035
if (cons.name.startsWith('_')) {
10361036
return true;
10371037
}
1038-
// Constructor blacklist
1038+
// Constructor exclude list
10391039
// TODO(bkonyi): Enable Float32x4.fromInt32x4Bits after we resolve
10401040
// https://github.com/dart-lang/sdk/issues/39890
10411041
if ((tp.displayName == 'Float32x4') && (cons.name == 'fromInt32x4Bits')) {

0 commit comments

Comments
 (0)