=> Dart 3.0! (#4267)

* dart 3.0 migration

* fixed dangling library

Author: pq

analysis_options.yaml

@@ -39,6 +39,7 @@ linter:
 #    - combinators_ordering
 #    - close_sinks # https://github.com/dart-lang/linter/issues/268
     - comment_references
+    - dangling_library_doc_comments
     - directives_ordering
     - discarded_futures
     - join_return_with_assignment
@@ -71,6 +72,7 @@ linter:
     - throw_in_finally
 #    - type_annotate_public_apis
     - unawaited_futures # pedantic
+    - unnecessary_breaks
     - unnecessary_final
     - unnecessary_lambdas
     - unnecessary_null_checks

lib/src/ast.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 /// Common AST helpers.
+library;
+
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';

lib/src/rules/prefer_contains.dart

@@ -140,25 +140,6 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 
-  TokenType _invertedTokenType(TokenType type) {
-    switch (type) {
-      case TokenType.LT_EQ:
-        return TokenType.GT_EQ;
-
-      case TokenType.LT:
-        return TokenType.GT;
-
-      case TokenType.GT:
-        return TokenType.LT;
-
-      case TokenType.GT_EQ:
-        return TokenType.LT_EQ;
-
-      default:
-        return type;
-    }
-  }
-
   /// Returns whether [expression] is an invocation of `Iterable.indexOf` or
   /// `String.indexOf`, which is not assigned to a value.
   bool _isUnassignedIndexOf(Expression expression) {
@@ -193,4 +174,12 @@ class _Visitor extends SimpleAstVisitor<void> {
 
     return true;
   }
+
+  static TokenType _invertedTokenType(TokenType type) => switch (type) {
+        TokenType.LT_EQ => TokenType.GT_EQ,
+        TokenType.LT => TokenType.GT,
+        TokenType.GT => TokenType.LT,
+        TokenType.GT_EQ => TokenType.LT_EQ,
+        _ => type
+      };
 }

lib/src/util/unrelated_types_visitor.dart

@@ -127,7 +127,6 @@ abstract class UnrelatedTypesProcessors extends SimpleAstVisitor<void> {
             typeArgument.getDisplayString(withNullability: true),
           ]);
         }
-        break;
 
       case ExpectedArgumentKind.assignableToCollection:
         if (!typeSystem.isAssignableTo(argumentType, collectionType)) {
@@ -136,7 +135,6 @@ abstract class UnrelatedTypesProcessors extends SimpleAstVisitor<void> {
             collectionType.getDisplayString(withNullability: true),
           ]);
         }
-        break;
 
       case ExpectedArgumentKind.assignableToIterableOfTypeArgument:
         var iterableType =

pubspec.yaml

@@ -9,7 +9,7 @@ repository: https://github.com/dart-lang/linter
 documentation: https://dart-lang.github.io/linter/lints
 
 environment:
-  sdk: '>=2.17.0 <3.0.0'
+  sdk: ^3.0.0-0
 
 dependencies:
   analyzer: ^5.10.0

tool/canonical/scorecard.dart

@@ -197,25 +197,20 @@ class LintScore {
         case Detail.rule:
           sb.write(
               ' [`$name`](https://dart-lang.github.io/linter/lints/$name.html) |');
-          break;
         case Detail.fix:
           var status = unfixableLints.contains(name)
               ? skip
               : (hasFix ? checkMark : consider);
           sb.write(' $status |');
-          break;
         case Detail.bulk:
           var status = unfixableLints.contains(name)
               ? skip
               : (hasBulkFix ? checkMark : consider);
           sb.write(' $status |');
-          break;
         case Detail.status:
           sb.write('${!state.isStable ? ' **${state.label}** ' : ""} |');
-          break;
         case Detail.bugs:
           sb.write(' ${bugReferences.join(", ")} |');
-          break;
       }
     }
     return sb.toString();

tool/scorecard.dart

@@ -151,29 +151,21 @@ class LintScore {
         case Detail.rule:
           sb.write(
               ' [$name](https://dart-lang.github.io/linter/lints/$name.html) |');
-          break;
         case Detail.linter:
           sb.write(' ${since!.sinceLinter} |');
-          break;
         case Detail.sdk:
           sb.write(' ${since!.sinceDartSdk} |');
-          break;
         case Detail.fix:
           sb.write('${hasFix ? " $bulb" : ""} |');
-          break;
         case Detail.flutterUser:
           sb.write('${ruleSets.contains('flutter') ? " $checkMark" : ""} |');
-          break;
         case Detail.flutterRepo:
           sb.write(
               '${ruleSets.contains('flutter_repo') ? " $checkMark" : ""} |');
-          break;
         case Detail.status:
           sb.write('${!state.isStable ? ' **${state.label}** ' : ""} |');
-          break;
         case Detail.bugs:
           sb.write(' ${bugReferences.join(", ")} |');
-          break;
       }
     }
     return sb.toString();