Skip to content

Commit 738d9f9

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
Avoid non-web integer literal in language2/list_test
Change-Id: I926dc7b9e9eabd098c4561ea95e1e3568522902f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107922 Commit-Queue: Stephen Adams <[email protected]> Auto-Submit: Stephen Adams <[email protected]> Reviewed-by: Leaf Petersen <[email protected]>
1 parent b5aeaa6 commit 738d9f9

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

tests/language_2/language_2_dart2js.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const_constructor3_test/04: MissingCompileTimeError # OK - Subtype check uses JS
3636
const_constructor_nonconst_param_test/01: MissingCompileTimeError
3737
const_dynamic_type_literal_test/03: Pass # but it shouldn't until we fix issue 17207
3838
const_evaluation_test/01: RuntimeError
39-
const_list_test: RuntimeError
4039
const_map2_test/00: MissingCompileTimeError
4140
const_map3_test/00: MissingCompileTimeError
4241
const_switch_test/02: RuntimeError, OK # constant identity based on JS constants
@@ -116,7 +115,6 @@ library_env_test/has_mirror_support: RuntimeError
116115
library_env_test/has_mirror_support: Fail # mirrors not supported on web
117116
library_env_test/has_no_html_support: RuntimeError, OK
118117
library_env_test/has_no_mirror_support: Pass # fails for the wrong reason.
119-
list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
120118
local_function2_test/none: RuntimeError
121119
local_function3_test/none: RuntimeError
122120
local_function_test/none: RuntimeError

tests/language_2/language_2_dartdevc.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,6 @@ left_shift_test: RuntimeError # Ints and doubles are unified.; Expect.equals(exp
355355
library_env_test/has_io_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false
356356
library_env_test/has_mirror_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false
357357
library_env_test/has_no_html_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false
358-
list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
359358
local_function2_test/none: RuntimeError # ReferenceError: TToNull is not defined
360359
local_function3_test/none: RuntimeError # Expect.equals(expected: <true>, actual: <false>) fails.
361360
local_function_test/none: RuntimeError # Expect.equals(expected: <true>, actual: <false>) fails.

tests/language_2/list_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class ListTest {
118118
Expect.equals(9, element);
119119

120120
Expect.throws(() => new List(-1));
121-
Expect.throws(() => new List(0x7fffffffffffffff));
121+
Expect.throws(() => new List(0x7ffffffffffff000));
122122

123123
List list = new List();
124124
Expect.throwsRangeError(list.removeLast);

0 commit comments

Comments
 (0)