Add '--benchmarking-x' flag

Change-Id: Iae541ae11431ccb86b74ca44b280e5bb6636d5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108300
Commit-Queue: Stephen Adams <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: rakudrama

pkg/compiler/lib/src/commandline_options.dart

@@ -100,8 +100,8 @@ class Flags {
   /// Flag for a combination of flags for 'production' mode.
   static const String benchmarkingProduction = '--benchmarking-production';
 
-  /// Flag for a combination of flags for golem experiment mode.
-  static const String golemExperiment = '--golem-x';
+  /// Flag for a combination of flags for benchmarking 'experiment' mode.
+  static const String benchmarkingExperiment = '--benchmarking-x';
 
   static const String conditionalDirectives = '--conditional-directives';
 

pkg/compiler/lib/src/dart2js.dart

@@ -456,7 +456,7 @@ Future<api.CompilationResult> compile(List<String> argv,
     new OptionHandler(Flags.omitAsCasts, passThrough),
     new OptionHandler(Flags.laxRuntimeTypeToString, passThrough),
     new OptionHandler(Flags.benchmarkingProduction, passThrough),
-    new OptionHandler(Flags.golemExperiment, passThrough),
+    new OptionHandler(Flags.benchmarkingExperiment, passThrough),
 
     // TODO(floitsch): remove conditional directives flag.
     // We don't provide the info-message yet, since we haven't publicly

pkg/compiler/lib/src/options.dart

@@ -120,8 +120,8 @@ class CompilerOptions implements DiagnosticOptions {
   /// Sets a combination of flags for benchmarking 'production' mode.
   bool benchmarkingProduction = false;
 
-  /// Sets a combination of flags for golem experiment benchmarking mode.
-  bool golemExperiment = false;
+  /// Sets a combination of flags for benchmarking 'experiment' mode.
+  bool benchmarkingExperiment = false;
 
   /// ID associated with this sdk build.
   String buildId = _UNDETERMINED_BUILD_ID;
@@ -362,7 +362,8 @@ class CompilerOptions implements DiagnosticOptions {
       ..allowMockCompilation = _hasOption(options, Flags.allowMockCompilation)
       ..benchmarkingProduction =
           _hasOption(options, Flags.benchmarkingProduction)
-      ..golemExperiment = _hasOption(options, Flags.golemExperiment)
+      ..benchmarkingExperiment =
+          _hasOption(options, Flags.benchmarkingExperiment)
       ..buildId =
           _extractStringOption(options, '--build-id=', _UNDETERMINED_BUILD_ID)
       ..compileForServer = _hasOption(options, Flags.serverMode)
@@ -466,9 +467,9 @@ class CompilerOptions implements DiagnosticOptions {
       omitImplicitChecks = true;
     }
 
-    if (golemExperiment) {
-      // TODO(sra): Set flags implied by '--golem-x'. Initially this will be
-      // --experiment-new-rti, and later NNBD.
+    if (benchmarkingExperiment) {
+      // TODO(sra): Set flags implied by '--benchmarking-x'. Initially this will
+      // be --experiment-new-rti, and later NNBD.
     }
 
     if (optimizationLevel != null) {