Skip to content

Commit 798123d

Browse files
pqcommit-bot@chromium.org
authored andcommitted
add lint associations
Change-Id: I1ceb6b45f07feff8b5f9d34c071e4a3c7d7c7f4a Reviewed-on: https://dart-review.googlesource.com/c/91941 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent b59d5a2 commit 798123d

File tree

1 file changed

+20
-7
lines changed
  • pkg/analysis_server/lib/src/services/correction

1 file changed

+20
-7
lines changed

pkg/analysis_server/lib/src/services/correction/assist.dart

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ class DartAssistKind {
4848
static const CONVERT_DOCUMENTATION_INTO_LINE = const AssistKind(
4949
'dart.assist.convert.lineComment',
5050
30,
51-
"Convert to line documentation comment");
51+
"Convert to line documentation comment",
52+
associatedErrorCodes: <String>['slash_for_doc_comments']);
5253
static const CONVERT_INTO_ASYNC_BODY = const AssistKind(
5354
'dart.assist.convert.bodyToAsync', 30, "Convert to async function body");
5455
static const CONVERT_INTO_BLOCK_BODY = const AssistKind(
@@ -57,7 +58,8 @@ class DartAssistKind {
5758
'dart.assist.convert.bodyToExpression', 30, "Convert to expression body",
5859
associatedErrorCodes: <String>['prefer_expression_function_bodies']);
5960
static const CONVERT_INTO_FINAL_FIELD = const AssistKind(
60-
'dart.assist.convert.getterToFinalField', 30, "Convert to final field");
61+
'dart.assist.convert.getterToFinalField', 30, "Convert to final field",
62+
associatedErrorCodes: <String>['prefer_final_fields']);
6163
static const CONVERT_INTO_FOR_INDEX = const AssistKind(
6264
'dart.assist.convert.forEachToForIndex', 30, "Convert to for-index loop");
6365
static const CONVERT_INTO_GENERIC_FUNCTION_SYNTAX = const AssistKind(
@@ -84,11 +86,16 @@ class DartAssistKind {
8486
static const CONVERT_TO_IF_ELEMENT = const AssistKind(
8587
'dart.assist.convertToIfElement', 30, "Convert to an 'if' element");
8688
static const CONVERT_TO_INT_LITERAL = const AssistKind(
87-
'dart.assist.convert.toIntLiteral', 30, "Convert to an int literal");
89+
'dart.assist.convert.toIntLiteral', 30, "Convert to an int literal",
90+
associatedErrorCodes: <String>['prefer_int_literals']);
8891
static const CONVERT_TO_LIST_LITERAL = const AssistKind(
89-
'dart.assist.convert.toListLiteral', 30, "Convert to list literal");
92+
'dart.assist.convert.toListLiteral', 30, "Convert to list literal",
93+
// todo (brianwilkerson): unify w/ fix
94+
associatedErrorCodes: <String>['prefer_collection_literals']);
9095
static const CONVERT_TO_MAP_LITERAL = const AssistKind(
91-
'dart.assist.convert.toMapLiteral', 30, "Convert to map literal");
96+
'dart.assist.convert.toMapLiteral', 30, "Convert to map literal",
97+
// todo (brianwilkerson): unify w/ fix
98+
associatedErrorCodes: <String>['prefer_collection_literals']);
9299
static const CONVERT_TO_MULTILINE_STRING = const AssistKind(
93100
'dart.assist.convert.toMultilineString',
94101
30,
@@ -98,7 +105,9 @@ class DartAssistKind {
98105
30,
99106
"Convert to normal parameter");
100107
static const CONVERT_TO_SET_LITERAL = const AssistKind(
101-
'dart.assist.convert.toSetLiteral', 30, "Convert to set literal");
108+
'dart.assist.convert.toSetLiteral', 30, "Convert to set literal",
109+
// todo (brianwilkerson): unify w/ fix
110+
associatedErrorCodes: <String>['prefer_collection_literals']);
102111
static const CONVERT_TO_SINGLE_QUOTED_STRING = const AssistKind(
103112
'dart.assist.convert.toSingleQuotedString',
104113
30,
@@ -161,7 +170,11 @@ class DartAssistKind {
161170
static const JOIN_VARIABLE_DECLARATION = const AssistKind(
162171
'dart.assist.joinVariableDeclaration', 30, "Join variable declaration");
163172
static const REMOVE_TYPE_ANNOTATION = const AssistKind(
164-
'dart.assist.removeTypeAnnotation', 29, "Remove type annotation");
173+
'dart.assist.removeTypeAnnotation', 29, "Remove type annotation",
174+
associatedErrorCodes: <String>[
175+
'avoid_return_types_on_setters',
176+
'type_init_formals'
177+
]);
165178
static const REPLACE_CONDITIONAL_WITH_IF_ELSE = const AssistKind(
166179
'dart.assist.convert.conditionalToIfElse',
167180
30,

0 commit comments

Comments
 (0)