Skip to content

Commit 7adcf94

Browse files
Adjust expectations of library_env_test to take into account noopt, precompiled and product mode.
[email protected] Review URL: https://codereview.chromium.org/1748153003 .
1 parent cd1112a commit 7adcf94

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

tests/language/language.status

+9-3
Original file line numberDiff line numberDiff line change
@@ -181,14 +181,20 @@ regress_22443_test: Skip
181181
[ $runtime == vm && $mode == product ]
182182
vm/type_vm_test: Fail,OK # Expects exact type name.
183183

184-
[ $compiler == none && $browser ]
184+
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) && $browser ]
185185
# The following tests are supposed to fail.
186186
library_env_test/has_io_support: RuntimeError, OK
187187
library_env_test/has_no_html_support: RuntimeError, OK
188-
library_env_test/has_no_mirror_support: RuntimeError, OK
189188

190-
[ $compiler == none && $browser != true ]
189+
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) && $browser != true ]
191190
# The following tests are supposed to fail.
192191
library_env_test/has_html_support: RuntimeError, OK
193192
library_env_test/has_no_io_support: RuntimeError, OK
193+
194+
[ $compiler == none && $noopt == false && $mode != product ]
195+
# The following tests are supposed to fail.
194196
library_env_test/has_no_mirror_support: RuntimeError, OK
197+
198+
[ $noopt || $compiler == precompiler || $mode == product ]
199+
# The following tests are supposed to fail.
200+
library_env_test/has_mirror_support: RuntimeError, OK

tests/language/library_env_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'package:expect/expect.dart';
66

77
main() {
8-
const NOT_PRESENT = null;
8+
const NOT_PRESENT = false;
99

1010
Expect.isTrue(const bool.fromEnvironment("dart.library.async"));
1111
Expect.isTrue(const bool.fromEnvironment("dart.library.collection"));

0 commit comments

Comments
 (0)