Enable read-only access to initializing formals (issue 27895)

[email protected]

Review URL: https://codereview.chromium.org/2532953004 .

Author: bwilkerson

pkg/analyzer/lib/src/command_line/arguments.dart

@@ -46,8 +46,6 @@ ContextBuilderOptions createContextBuilderOptions(ArgResults args) {
   // Analysis options.
   //
   AnalysisOptionsImpl defaultOptions = new AnalysisOptionsImpl();
-  defaultOptions.enableInitializingFormalAccess =
-      args[enableInitializingFormalAccessFlag];
   defaultOptions.enableStrictCallChecks = args[enableStrictCallChecksFlag];
   defaultOptions.enableSuperMixins = args[enableSuperInMixinFlag];
   defaultOptions.implicitCasts = !args[noImplicitCastsFlag];

pkg/analyzer/lib/src/context/context.dart

@@ -283,8 +283,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
         this._options.enableAssertInitializer !=
             options.enableAssertInitializer ||
         this._options.enableAssertMessage != options.enableAssertMessage ||
-        this._options.enableInitializingFormalAccess !=
-            options.enableInitializingFormalAccess ||
         this._options.enableLazyAssignmentOperators !=
             options.enableLazyAssignmentOperators ||
         ((options is AnalysisOptionsImpl)
@@ -311,8 +309,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
     this._options.enableAssertInitializer = options.enableAssertInitializer;
     this._options.enableAssertMessage = options.enableAssertMessage;
     this._options.enableStrictCallChecks = options.enableStrictCallChecks;
-    this._options.enableInitializingFormalAccess =
-        options.enableInitializingFormalAccess;
     this._options.enableLazyAssignmentOperators =
         options.enableLazyAssignmentOperators;
     this._options.enableSuperMixins = options.enableSuperMixins;

pkg/analyzer/lib/src/generated/engine.dart

@@ -1129,6 +1129,7 @@ abstract class AnalysisOptions {
    * Return `true` if access to field formal parameters should be allowed in a
    * constructor's initializer list.
    */
+  @deprecated
   bool get enableInitializingFormalAccess;
 
   /**
@@ -1329,9 +1330,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @override
   bool enableAssertMessage = false;
 
-  @override
-  bool enableInitializingFormalAccess = false;
-
   @override
   bool enableLazyAssignmentOperators = false;
 
@@ -1453,7 +1451,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
     enableAssertInitializer = options.enableAssertInitializer;
     enableAssertMessage = options.enableAssertMessage;
     enableStrictCallChecks = options.enableStrictCallChecks;
-    enableInitializingFormalAccess = options.enableInitializingFormalAccess;
     enableLazyAssignmentOperators = options.enableLazyAssignmentOperators;
     enableSuperMixins = options.enableSuperMixins;
     enableTiming = options.enableTiming;
@@ -1533,6 +1530,13 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @deprecated
   void set enableGenericMethods(bool enable) {}
 
+  @deprecated
+  @override
+  bool get enableInitializingFormalAccess => true;
+
+  @deprecated
+  void set enableInitializingFormalAccess(bool enable) {}
+
   @override
   List<ErrorProcessor> get errorProcessors =>
       _errorProcessors ??= const <ErrorProcessor>[];

pkg/analyzer/lib/src/generated/resolver.dart

@@ -7168,12 +7168,6 @@ abstract class ScopedVisitor extends UnifyingAstVisitor<Object> {
    */
   LabelScope labelScope;
 
-  /**
-   * A flag indicating whether to enable support for allowing access to field
-   * formal parameters in a constructor's initializer list.
-   */
-  bool enableInitializingFormalAccess = false;
-
   /**
    * The class containing the AST nodes being visited,
    * or `null` if we are not in the scope of a class.
@@ -7205,8 +7199,6 @@ abstract class ScopedVisitor extends UnifyingAstVisitor<Object> {
     } else {
       this.nameScope = nameScope;
     }
-    enableInitializingFormalAccess =
-        definingLibrary.context.analysisOptions.enableInitializingFormalAccess;
   }
 
   /**
@@ -7368,7 +7360,7 @@ abstract class ScopedVisitor extends UnifyingAstVisitor<Object> {
       node.parameters?.accept(this);
       Scope functionScope = nameScope;
       try {
-        if (constructorElement != null && enableInitializingFormalAccess) {
+        if (constructorElement != null) {
           nameScope =
               new ConstructorInitializerScope(nameScope, constructorElement);
         }

pkg/analyzer/lib/src/task/options.dart

@@ -635,8 +635,6 @@ class _OptionsProcessor {
     if (boolValue != null) {
       if (feature == AnalyzerOptions.enableAssertInitializer) {
         options.enableAssertInitializer = boolValue;
-      } else if (feature == AnalyzerOptions.enableInitializingFormalAccess) {
-        options.enableInitializingFormalAccess = boolValue;
       } else if (feature == AnalyzerOptions.enableSuperMixins) {
         options.enableSuperMixins = boolValue;
       }

pkg/analyzer/test/generated/simple_resolver_test.dart

@@ -656,9 +656,6 @@ class A {
   }
 
   void test_fieldFormalParameter() {
-    AnalysisOptionsImpl options = new AnalysisOptionsImpl();
-    options.enableInitializingFormalAccess = true;
-    resetWithOptions(options);
     Source source = addSource(r'''
 class A {
   int x;

pkg/analyzer/test/src/command_line/arguments_test.dart

@@ -35,7 +35,6 @@ class ArgumentsTest {
       '-Dfoo=1',
       '-Dbar=2',
       '--enable-strict-call-checks',
-      '--initializing-formal-access',
       '--no-implicit-casts',
       '--no-implicit-dynamic',
       '--options=$defaultAnalysisOptionsFilePath',
@@ -58,7 +57,6 @@ class ArgumentsTest {
     expect(options.defaultPackagesDirectoryPath, defaultPackagesDirectoryPath);
     AnalysisOptionsImpl defaultOptions = options.defaultOptions;
     expect(defaultOptions, isNotNull);
-    expect(defaultOptions.enableInitializingFormalAccess, true);
     expect(defaultOptions.enableStrictCallChecks, true);
     expect(defaultOptions.strongMode, true);
     expect(defaultOptions.implicitCasts, false);
@@ -81,7 +79,6 @@ class ArgumentsTest {
     expect(options.defaultPackagesDirectoryPath, isNull);
     AnalysisOptionsImpl defaultOptions = options.defaultOptions;
     expect(defaultOptions, isNotNull);
-    expect(defaultOptions.enableInitializingFormalAccess, false);
     expect(defaultOptions.enableStrictCallChecks, false);
     expect(defaultOptions.strongMode, false);
     expect(defaultOptions.implicitCasts, true);

pkg/analyzer_cli/lib/src/driver.dart

@@ -280,10 +280,6 @@ class Driver implements CommandLineStarter {
     if (options.disableHints != _previousOptions.disableHints) {
       return false;
     }
-    if (options.enableInitializingFormalAccess !=
-        _previousOptions.enableInitializingFormalAccess) {
-      return false;
-    }
     if (options.enableStrictCallChecks !=
         _previousOptions.enableStrictCallChecks) {
       return false;
@@ -671,8 +667,6 @@ class Driver implements CommandLineStarter {
     contextOptions.trackCacheDependencies = false;
     contextOptions.disableCacheFlushing = options.disableCacheFlushing;
     contextOptions.hint = !options.disableHints;
-    contextOptions.enableInitializingFormalAccess =
-        options.enableInitializingFormalAccess;
     contextOptions.enableStrictCallChecks = options.enableStrictCallChecks;
     contextOptions.enableSuperMixins = options.enableSuperMixins;
     contextOptions.generateImplicitErrors = options.showPackageWarnings;

pkg/analyzer_cli/lib/src/options.dart

@@ -85,10 +85,6 @@ class CommandLineOptions {
   /// Whether to display version information
   final bool displayVersion;
 
-  /// A flag indicating whether access to field formal parameters should be
-  /// allowed in a constructor's initializer list.
-  final bool enableInitializingFormalAccess;
-
   /// Whether to enable null-aware operators (DEP 9).
   final bool enableNullAwareOperators;
 
@@ -179,7 +175,6 @@ class CommandLineOptions {
         disableCacheFlushing = args['disable-cache-flushing'],
         disableHints = args['no-hints'],
         displayVersion = args['version'],
-        enableInitializingFormalAccess = args['initializing-formal-access'],
         enableNullAwareOperators = args['enable-null-aware-operators'],
         enableStrictCallChecks = args['enable-strict-call-checks'],
         enableSuperMixins = args['supermixin'],