Issue 52387. Report an error for !super

Bug: #52387
Change-Id: I9893315b988c3096ea2d103f6a46f00ff0450afe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303446
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fasta/ast_builder.dart

@@ -5509,10 +5509,16 @@ class AstBuilder extends StackListener {
     assert(operator.type.isUnaryPrefixOperator);
     debugEvent("UnaryPrefixExpression");
 
+    final operand = pop() as ExpressionImpl;
+    if (!(operator.type == TokenType.MINUS ||
+        operator.type == TokenType.TILDE)) {
+      reportErrorIfSuper(operand);
+    }
+
     push(
       PrefixExpressionImpl(
         operator: operator,
-        operand: pop() as ExpressionImpl,
+        operand: operand,
       ),
     );
   }

pkg/analyzer/test/generated/expression_parser_test.dart

@@ -2509,7 +2509,9 @@ class ExpressionParserTest extends FastaParserTestCase {
   void test_parseUnaryExpression_not_super() {
     PrefixExpression expression = parseUnaryExpression('!super');
     expect(expression, isNotNull);
-    assertNoErrors();
+    assertErrors(errors: [
+      error(ParserErrorCode.MISSING_ASSIGNABLE_SELECTOR, 1, 5),
+    ]);
     expect(expression.operator, isNotNull);
     expect(expression.operator.type, TokenType.BANG);
     expect(expression.operand, isNotNull);

pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart

@@ -51,6 +51,30 @@ PrefixExpression
 ''');
   }
 
+  test_bang_super() async {
+    await assertErrorsInCode(r'''
+class A {
+  void f() {
+    !super;
+  }
+}
+''', [
+      error(ParserErrorCode.MISSING_ASSIGNABLE_SELECTOR, 28, 5),
+      error(CompileTimeErrorCode.NON_BOOL_NEGATION_EXPRESSION, 28, 5),
+    ]);
+
+    final node = findNode.singlePrefixExpression;
+    assertResolvedNodeText(node, r'''
+PrefixExpression
+  operator: !
+  operand: SuperExpression
+    superKeyword: super
+    staticType: A
+  staticElement: <null>
+  staticType: bool
+''');
+  }
+
   test_formalParameter_inc_inc() async {
     await assertErrorsInCode(r'''
 void f(int x) {