Skip to content

Commit 8bbe6fb

Browse files
scheglovCommit Queue
authored and
Commit Queue
committed
Elements. Report analyzer_use_new_elements without any txt file, add file ignores.
Change-Id: I13125f93a6633563ed6853a622bd9fec045bfc0c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403923 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent dc37a77 commit 8bbe6fb

File tree

209 files changed

+393
-310
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

209 files changed

+393
-310
lines changed

pkg/analysis_server/analyzer_use_new_elements.txt

Lines changed: 0 additions & 15 deletions
This file was deleted.

pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
/// Utilities for converting Dart entities into analysis server's protocol
68
/// entities.
79
library;

pkg/analysis_server/lib/src/analysis_server.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'dart:async';
68
import 'dart:io' as io;
79
import 'dart:io';

pkg/analysis_server/lib/src/cider/rename.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/protocol_server.dart' hide Element;
68
import 'package:analysis_server/src/services/correction/status.dart';
79
import 'package:analysis_server/src/services/correction/util.dart';

pkg/analysis_server/lib/src/handler/legacy/search_find_element_references.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'dart:async';
68

79
import 'package:analysis_server/plugin/protocol/protocol_dart.dart' as protocol;

pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/lsp_protocol/protocol.dart' hide MessageType;
68
import 'package:analysis_server/src/analysis_server.dart' show MessageType;
79
import 'package:analysis_server/src/lsp/client_capabilities.dart';

pkg/analysis_server/lib/src/protocol_server.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/plugin/protocol/protocol_dart.dart';
68
import 'package:analysis_server/protocol/protocol_generated.dart';
79
import 'package:analysis_server/src/computer/computer_color.dart';

pkg/analysis_server/lib/src/services/correction/namespace.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analyzer/dart/ast/ast.dart';
68
import 'package:analyzer/dart/element/element.dart';
79
import 'package:analyzer/dart/element/element2.dart';

pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analyzer/dart/element/element.dart';
68
import 'package:analyzer/dart/element/visitor.dart';
79
import 'package:analyzer/file_system/file_system.dart';

pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/protocol_server.dart' hide Element;
68
import 'package:analysis_server/src/services/correction/name_suggestion.dart';
79
import 'package:analysis_server/src/services/correction/selection_analyzer.dart';

pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/services/correction/status.dart';
68
import 'package:analysis_server/src/services/refactoring/legacy/convert_getter_to_method.dart';
79
import 'package:analysis_server/src/services/refactoring/legacy/convert_method_to_getter.dart';

pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'dart:async';
68

79
import 'package:analysis_server/src/collections.dart';

pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/protocol_server.dart' hide Element;
68
import 'package:analysis_server/src/services/correction/status.dart';
79
import 'package:analysis_server/src/services/correction/util.dart';

pkg/analysis_server/lib/src/services/refactoring/legacy/rename_import.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/protocol_server.dart';
68
import 'package:analysis_server/src/services/correction/status.dart';
79
import 'package:analysis_server/src/services/refactoring/legacy/naming_conventions.dart';

pkg/analysis_server/lib/src/services/search/element_visitors.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analyzer/dart/element/element.dart';
68
import 'package:analyzer/dart/element/element2.dart';
79
import 'package:analyzer/dart/element/visitor.dart';

pkg/analysis_server/lib/src/status/element_writer.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ class ElementWriter with TreeWriter {
163163
properties['imports'] = {
164164
for (var import in fragment.libraryImports2)
165165
{
166-
// ignore: analyzer_use_new_elements
167166
'combinators': import.combinators,
168167
if (import.prefix2 != null) 'prefix': import.prefix2?.name2,
169168
'isDeferred': import.prefix2?.isDeferred ?? false,
@@ -173,7 +172,6 @@ class ElementWriter with TreeWriter {
173172
properties['imports'] = {
174173
for (var export in fragment.libraryExports2)
175174
{
176-
// ignore: analyzer_use_new_elements
177175
'combinators': export.combinators,
178176
'library': export.exportedLibrary2,
179177
},

pkg/analysis_server/test/services/refactoring/legacy/abstract_rename.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
import 'package:analysis_server/src/services/correction/namespace.dart';
68
import 'package:analysis_server/src/services/refactoring/legacy/refactoring.dart';
79
import 'package:analyzer/dart/ast/ast.dart';

pkg/analysis_server_client/analyzer_use_new_elements.txt

Whitespace-only changes.

pkg/analysis_server_plugin/analyzer_use_new_elements.txt

Whitespace-only changes.

pkg/analyzer/analyzer_use_new_elements.txt

Lines changed: 0 additions & 184 deletions
This file was deleted.

pkg/analyzer/lib/dart/analysis/results.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
56
import 'package:analyzer/dart/analysis/analysis_options.dart';
67
import 'package:analyzer/dart/analysis/session.dart';
78
import 'package:analyzer/dart/ast/ast.dart';

pkg/analyzer/lib/dart/analysis/session.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
56
import 'package:analyzer/dart/analysis/analysis_context.dart';
67
import 'package:analyzer/dart/analysis/declared_variables.dart';
78
import 'package:analyzer/dart/analysis/results.dart';

pkg/analyzer/lib/dart/constant/value.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
/// [element model](../element/element.dart).
1313
library;
1414

15+
// ignore_for_file: analyzer_use_new_elements
1516
import 'package:analyzer/dart/element/element.dart';
1617
import 'package:analyzer/dart/element/element2.dart';
1718
import 'package:analyzer/dart/element/type.dart';

pkg/analyzer/lib/dart/element/element.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
/// Defines the element model. The element model describes the semantic (as
68
/// opposed to syntactic) structure of Dart code. The syntactic structure of the
79
/// code is modeled by the [AST

pkg/analyzer/lib/dart/element/element2.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: analyzer_use_new_elements
6+
57
/// Defines the elements and fragments that are part of the element model.
68
///
79
/// The element model describes the semantic (as opposed to syntactic) structure

0 commit comments

Comments
 (0)