[analyzer] Dot shorthands: Check for required parameters in invocations.

Added an additional check in the analyzer to make sure required parameters are given.

Unit test added.

Bug: #59835
Change-Id: I887a46294c961136bd0a1a3999978fe2db99b315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428221
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/error/required_parameters_verifier.dart

@@ -34,6 +34,29 @@ class RequiredParametersVerifier extends SimpleAstVisitor<void> {
     }
   }
 
+  @override
+  void visitDotShorthandConstructorInvocation(
+    DotShorthandConstructorInvocation node,
+  ) {
+    var constructorElement = node.constructorName.element;
+    if (constructorElement is ConstructorElement) {
+      _check(
+        parameters: constructorElement.formalParameters,
+        arguments: node.argumentList.arguments,
+        errorEntity: node.constructorName,
+      );
+    }
+  }
+
+  @override
+  void visitDotShorthandInvocation(DotShorthandInvocation node) {
+    _check(
+      parameters: _executableElement(node.memberName.element)?.formalParameters,
+      arguments: node.argumentList.arguments,
+      errorEntity: node.memberName,
+    );
+  }
+
   @override
   void visitEnumConstantDeclaration(EnumConstantDeclaration node) {
     _check(

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -657,9 +657,16 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
         node.constKeyword,
       );
     }
+    _requiredParametersVerifier.visitDotShorthandConstructorInvocation(node);
     super.visitDotShorthandConstructorInvocation(node);
   }
 
+  @override
+  void visitDotShorthandInvocation(DotShorthandInvocation node) {
+    _requiredParametersVerifier.visitDotShorthandInvocation(node);
+    super.visitDotShorthandInvocation(node);
+  }
+
   @override
   void visitEnumConstantDeclaration(
     covariant EnumConstantDeclarationImpl node,

pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart

@@ -566,6 +566,23 @@ DotShorthandConstructorInvocation
 ''');
   }
 
+  test_requiredParameters_missing() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  int x;
+  C({required this.x});
+}
+
+void main() {
+  C c = .new();
+  print(c);
+}
+''',
+      [error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 69, 3)],
+    );
+  }
+
   test_typeParameters() async {
     await assertErrorsInCode(
       r'''

pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart

@@ -619,6 +619,24 @@ DotShorthandInvocation
 ''');
   }
 
+  test_requiredParameters_missing() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  static C member({required int x}) => C(x);
+  int x;
+  C(this.x);
+}
+
+void main() {
+  C c = .member();
+  print(c);
+}
+''',
+      [error(CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT, 103, 6)],
+    );
+  }
+
   test_typeParameters_inference() async {
     await assertNoErrorsInCode(r'''
 class C<T> {