Skip to content

Commit 9aee504

Browse files
committed
Remove unnecessary imports to tree.dart
[email protected] Review URL: https://codereview.chromium.org/2203013003 .
1 parent 6a23dda commit 9aee504

File tree

11 files changed

+19
-19
lines changed

11 files changed

+19
-19
lines changed

pkg/compiler/lib/src/constant_system_dart.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'compiler.dart' show Compiler;
88
import 'constants/constant_system.dart';
99
import 'constants/values.dart';
1010
import 'dart_types.dart';
11-
import 'tree/tree.dart' show DartString;
11+
import 'tree/dartstring.dart' show DartString;
1212

1313
const DART_CONSTANT_SYSTEM = const DartConstantSystem();
1414

pkg/compiler/lib/src/constants/constant_system.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ library dart2js.constant_system;
77
import '../dart_types.dart';
88
import '../compiler.dart' show Compiler;
99
import '../resolution/operators.dart';
10-
import '../tree/tree.dart' show DartString;
10+
import '../tree/dartstring.dart' show DartString;
1111
import 'values.dart';
1212

1313
abstract class Operation {

pkg/compiler/lib/src/constants/expressions.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import '../elements/elements.dart'
1616
PrefixElement,
1717
VariableElement;
1818
import '../resolution/operators.dart';
19-
import '../tree/tree.dart' show DartString;
19+
import '../tree/dartstring.dart' show DartString;
2020
import '../universe/call_structure.dart' show CallStructure;
2121
import 'evaluation.dart';
2222
import 'values.dart';

pkg/compiler/lib/src/constants/values.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import '../core_types.dart';
99
import '../dart_types.dart';
1010
import '../elements/elements.dart'
1111
show FieldElement, FunctionElement, PrefixElement;
12-
import '../tree/tree.dart' hide unparse;
12+
import '../tree/dartstring.dart';
1313
import '../util/util.dart' show Hashing;
1414

1515
abstract class ConstantValueVisitor<R, A> {

pkg/compiler/lib/src/deferred_load.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import 'js_backend/js_backend.dart' show JavaScriptBackend;
3636
import 'resolution/resolution.dart' show AnalyzableElementX;
3737
import 'resolution/tree_elements.dart' show TreeElements;
3838
import 'tree/tree.dart' as ast;
39-
import 'tree/tree.dart' show Import, Node;
4039
import 'universe/use.dart' show StaticUse, TypeUse, TypeUseKind;
4140
import 'universe/world_impact.dart'
4241
show ImpactUseCase, WorldImpact, WorldImpactVisitorImpl;
@@ -93,8 +92,7 @@ class DeferredLoadTask extends CompilerTask {
9392
/// DeferredLibrary from dart:async
9493
ClassElement get deferredLibraryClass => compiler.deferredLibraryClass;
9594

96-
/// A synthetic [Import] representing the loading of the main
97-
/// program.
95+
/// A synthetic import representing the loading of the main program.
9896
final _DeferredImport _fakeMainImport = const _DeferredImport();
9997

10098
/// The OutputUnit that will be loaded when the program starts.
@@ -235,7 +233,7 @@ class DeferredLoadTask extends CompilerTask {
235233
return imports.every((ImportElement import) => import.isDeferred);
236234
}
237235

238-
/// Returns a [Link] of every [Import] that imports [element] into [library].
236+
/// Returns every [ImportElement] that imports [element] into [library].
239237
Iterable<ImportElement> _getImports(Element element, LibraryElement library) {
240238
if (element.isClassMember) {
241239
element = element.enclosingClass;
@@ -347,8 +345,8 @@ class DeferredLoadTask extends CompilerTask {
347345
// implicit constant expression are seen that we should be able to add
348346
// (like primitive constant literals like `true`, `"foo"` and `0`).
349347
// See dartbug.com/26406 for context.
350-
treeElements
351-
.forEachConstantNode((Node node, ConstantExpression expression) {
348+
treeElements.forEachConstantNode(
349+
(ast.Node node, ConstantExpression expression) {
352350
if (compiler.serialization.isDeserialized(analyzableElement)) {
353351
if (!expression.isImplicit && !expression.isPotential) {
354352
// Enforce evaluation of [expression].

pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import '../dart_types.dart' show DartType;
1515
import '../elements/elements.dart';
1616
import '../js_backend/js_backend.dart' show Annotations, JavaScriptBackend;
1717
import '../resolution/tree_elements.dart' show TreeElementMapping;
18-
import '../tree/tree.dart' as ast
19-
show DartString, Node, LiteralBool, TryStatement;
18+
import '../tree/tree.dart' as ast show Node, LiteralBool, TryStatement;
19+
import '../tree/dartstring.dart' show DartString;
2020
import '../types/constants.dart' show computeTypeMask;
2121
import '../types/types.dart'
2222
show ContainerTypeMask, MapTypeMask, TypeMask, TypesInferrer;
@@ -227,7 +227,7 @@ class TypeInformationSystem extends TypeSystem<TypeInformation> {
227227

228228
TypeInformation nonNullEmptyType;
229229

230-
TypeInformation stringLiteralType(ast.DartString value) {
230+
TypeInformation stringLiteralType(DartString value) {
231231
return new StringLiteralTypeInformation(
232232
value, compiler.typesTask.stringType);
233233
}

pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ import '../cps_ir/cps_ir_nodes.dart' as cps_ir show Node;
1414
import '../dart_types.dart' show DartType, FunctionType, TypeKind;
1515
import '../elements/elements.dart';
1616
import '../native/native.dart' as native;
17-
import '../tree/tree.dart' as ast show DartString, Node, LiteralBool, Send;
17+
import '../tree/tree.dart' as ast show Node, LiteralBool, Send;
18+
import '../tree/dartstring.dart' show DartString;
1819
import '../types/types.dart'
1920
show
2021
ContainerTypeMask,
@@ -1209,7 +1210,7 @@ class ConcreteTypeInformation extends TypeInformation {
12091210
}
12101211

12111212
class StringLiteralTypeInformation extends ConcreteTypeInformation {
1212-
final ast.DartString value;
1213+
final DartString value;
12131214

12141215
StringLiteralTypeInformation(value, TypeMask mask)
12151216
: super(new ValueTypeMask(mask, new StringConstantValue(value))),

pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import '../constant_system_dart.dart';
1111
import '../core_types.dart' show CoreTypes;
1212
import '../dart_types.dart';
1313
import '../elements/elements.dart' show ClassElement, FieldElement;
14-
import '../tree/tree.dart' show DartString, LiteralDartString;
14+
import '../tree/dartstring.dart' show DartString, LiteralDartString;
1515
import 'js_backend.dart';
1616

1717
const JAVA_SCRIPT_CONSTANT_SYSTEM = const JavaScriptConstantSystem();

pkg/compiler/lib/src/js_emitter/constant_ordering.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import '../constants/values.dart';
88

99
import '../dart_types.dart';
1010
import '../elements/elements.dart' show Element, Elements, FieldElement;
11-
import '../tree/tree.dart' show DartString;
11+
import '../tree/dartstring.dart' show DartString;
1212
import '../js_backend/js_backend.dart' show SyntheticConstantKind;
1313

1414
/// A canonical but arbrary ordering of constants. The ordering is 'stable'

pkg/compiler/lib/src/ssa/optimize.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import '../js/js.dart' as js;
1414
import '../js_backend/backend_helpers.dart' show BackendHelpers;
1515
import '../js_backend/js_backend.dart';
1616
import '../native/native.dart' as native;
17-
import '../tree/tree.dart' as ast;
17+
import '../tree/dartstring.dart' as ast;
1818
import '../types/types.dart';
1919
import '../universe/selector.dart' show Selector;
2020
import '../universe/side_effects.dart' show SideEffects;

pkg/compiler/lib/src/string_validator.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import 'dart:collection';
1010

1111
import 'common.dart';
1212
import 'tokens/token.dart' show Token;
13-
import 'tree/tree.dart';
13+
import 'tree/nodes.dart' show StringQuoting;
14+
import 'tree/dartstring.dart' show DartString;
1415
import 'util/characters.dart';
1516

1617
class StringValidator {

0 commit comments

Comments
 (0)