Skip to content

Commit 9f0c408

Browse files
srawlinscommit-bot@chromium.org
authored andcommitted
Remove redundant imports from front_end
Very often there were two imports of the same URI, one of which also had a `show` combinator. I opted to remove the other one. Bug: #44569 Change-Id: I1263c892f94f0645fda6dee371dfc1fcddcd2344 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213846 Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent 8d04e49 commit 9f0c408

13 files changed

+0
-14
lines changed

pkg/front_end/lib/src/fasta/incremental_compiler.dart

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import 'package:_fe_analyzer_shared/src/scanner/abstract_scanner.dart'
1010
show ScannerConfiguration;
1111

1212
import 'package:front_end/src/api_prototype/experimental_flags.dart';
13-
import 'package:front_end/src/api_prototype/front_end.dart';
1413

1514
import 'package:front_end/src/api_prototype/lowering_predicates.dart'
1615
show isExtensionThisName;

pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import 'package:kernel/ast.dart';
2424
import 'package:kernel/class_hierarchy.dart';
2525
import 'package:kernel/clone.dart';
2626
import 'package:kernel/core_types.dart';
27-
import 'package:kernel/kernel.dart';
2827
import 'package:kernel/src/const_canonical_type.dart';
2928
import 'package:kernel/src/legacy_erasure.dart';
3029
import 'package:kernel/src/norm.dart';

pkg/front_end/test/id_testing/id_testing_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
88
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
99
show DataInterpreter, StringDataInterpreter, runTests;
10-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1110
import 'dart:io' show Directory, Platform;
1211
import 'package:front_end/src/fasta/messages.dart' show FormattedMessage;
1312
import 'package:front_end/src/testing/id_testing_helper.dart'

pkg/front_end/test/id_tests/assigned_variables_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'package:_fe_analyzer_shared/src/testing/id.dart'
1111
show ActualData, Id, IdKind;
1212
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1313
show DataInterpreter, runTests;
14-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1514
import 'package:front_end/src/fasta/builder/member_builder.dart';
1615
import 'package:front_end/src/fasta/source/source_loader.dart';
1716

pkg/front_end/test/id_tests/constant_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, StringDataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:front_end/src/testing/id_testing_helper.dart'
1312
show
1413
CfeDataExtractor,

pkg/front_end/test/id_tests/inferred_type_arguments_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:front_end/src/fasta/builder/member_builder.dart';
1312
import 'package:front_end/src/fasta/type_inference/type_inference_engine.dart';
1413
import 'package:front_end/src/testing/id_testing_helper.dart';

pkg/front_end/test/id_tests/inferred_variable_types_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:front_end/src/fasta/builder/member_builder.dart';
1312
import 'package:front_end/src/fasta/type_inference/type_inference_engine.dart';
1413
import 'package:front_end/src/testing/id_testing_helper.dart';

pkg/front_end/test/id_tests/reachability_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:front_end/src/testing/id_testing_helper.dart';
1312
import 'package:front_end/src/fasta/builder/member_builder.dart';
1413
import 'package:front_end/src/fasta/source/source_loader.dart';

pkg/front_end/test/id_tests/type_promotion_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:front_end/src/testing/id_testing_helper.dart';
1312
import 'package:front_end/src/testing/id_testing_utils.dart';
1413
import 'package:kernel/ast.dart' hide Variance;

pkg/front_end/test/id_tests/why_not_promoted_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import 'dart:io' show Directory, Platform;
99
import 'package:_fe_analyzer_shared/src/testing/id.dart' show ActualData, Id;
1010
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1111
show DataInterpreter, runTests;
12-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1312
import 'package:front_end/src/fasta/builder/member_builder.dart';
1413
import 'package:front_end/src/fasta/type_inference/type_inference_engine.dart';
1514
import 'package:front_end/src/testing/id_testing_helper.dart';

pkg/front_end/test/lint_suite.dart

-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import 'package:_fe_analyzer_shared/src/parser/listener.dart' show Listener;
1515

1616
import 'package:_fe_analyzer_shared/src/scanner/token.dart' show Token;
1717

18-
import 'package:_fe_analyzer_shared/src/scanner/token.dart';
19-
2018
import 'package:_fe_analyzer_shared/src/scanner/utf8_bytes_scanner.dart'
2119
show Utf8BytesScanner;
2220

pkg/front_end/test/predicates/predicate_test.dart

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:io' show Directory, Platform;
88
import 'package:_fe_analyzer_shared/src/testing/id.dart';
99
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart'
1010
show DataInterpreter, runTests;
11-
import 'package:_fe_analyzer_shared/src/testing/id_testing.dart';
1211
import 'package:_fe_analyzer_shared/src/testing/features.dart';
1312
import 'package:front_end/src/api_prototype/experimental_flags.dart';
1413
import 'package:front_end/src/base/nnbd_mode.dart';

pkg/front_end/tool/perf.dart

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import 'package:analyzer/src/dart/sdk/sdk.dart' show FolderBasedDartSdk;
2828
import 'package:analyzer/src/file_system/file_system.dart';
2929
import 'package:analyzer/src/generated/parser.dart';
3030
import 'package:analyzer/src/generated/source.dart';
31-
import 'package:analyzer/src/generated/source_io.dart';
3231
import 'package:analyzer/src/source/package_map_resolver.dart';
3332
import 'package:path/path.dart' as path;
3433

0 commit comments

Comments
 (0)