More testing of strict modes for extension types

Fixes #53982

Change-Id: Ie28c3ad80c8f9209551d336d49386236d26bc620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335280
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart

@@ -580,6 +580,7 @@ mixin WithStrictCastsMixin on PubPackageResolutionTest {
 
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictCasts: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart

@@ -800,6 +800,17 @@ main() {
 @reflectiveTest
 class ArgumentTypeNotAssignableWithStrictCastsTest
     extends PubPackageResolutionTest with WithStrictCastsMixin {
+  test_extensionTypePrimaryConstructor() async {
+    await assertErrorsWithStrictCasts('''
+extension type E(int i) {}
+
+dynamic a;
+var e = E(a);
+''', [
+      error(CompileTimeErrorCode.ARGUMENT_TYPE_NOT_ASSIGNABLE, 49, 1),
+    ]);
+  }
+
   test_functionCall() async {
     await assertErrorsWithStrictCasts('''
 void f(int i) {}

pkg/analyzer/test/src/diagnostics/inference_failure_on_collection_literal_test.dart

@@ -20,6 +20,7 @@ class InferenceFailureOnCollectionLiteralTest extends PubPackageResolutionTest {
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/inference_failure_on_function_invocation_test.dart

@@ -23,6 +23,7 @@ class InferenceFailureOnFunctionInvocationTest
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/inference_failure_on_generic_invocation_test.dart

@@ -22,6 +22,7 @@ class InferenceFailureOnGenericInvocationTest extends PubPackageResolutionTest {
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/inference_failure_on_instance_creation_test.dart

@@ -21,6 +21,7 @@ class InferenceFailureOnInstanceCreationTest extends PubPackageResolutionTest {
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );
@@ -83,6 +84,17 @@ void f() {
 ''');
   }
 
+  test_extensionType() async {
+    await assertErrorsInCode('''
+extension type E<T>(int i) {}
+void f() {
+  E(1);
+}
+''', [
+      error(WarningCode.INFERENCE_FAILURE_ON_INSTANCE_CREATION, 43, 1),
+    ]);
+  }
+
   test_genericMetadata_missingTypeArg() async {
     await assertErrorsInCode(r'''
 class C<T> {

pkg/analyzer/test/src/diagnostics/inference_failure_on_uninitialized_variable_test.dart

@@ -23,6 +23,7 @@ class InferenceFailureOnUninitializedVariableTest
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/inference_failure_on_untyped_parameter_test.dart

@@ -22,6 +22,7 @@ class InferenceFailureOnUntypedParameterTest extends PubPackageResolutionTest {
     super.setUp();
     writeTestPackageAnalysisOptionsFile(
       AnalysisOptionsFileConfig(
+        experiments: experiments,
         strictInference: true,
       ),
     );

pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart

@@ -1085,12 +1085,30 @@ class B<T> {
 @reflectiveTest
 class InvalidAssignmentWithStrictCastsTest extends PubPackageResolutionTest
     with WithStrictCastsMixin {
-  test_assignment() async {
+  test_functionType() async {
+    await assertErrorsWithStrictCasts('''
+dynamic a;
+void Function(int i) f = a;
+''', [
+      error(CompileTimeErrorCode.INVALID_ASSIGNMENT, 36, 1),
+    ]);
+  }
+
+  test_interfaceType() async {
     await assertErrorsWithStrictCasts('''
 dynamic a;
 int b = a;
 ''', [
       error(CompileTimeErrorCode.INVALID_ASSIGNMENT, 19, 1),
     ]);
   }
+
+  test_recordType() async {
+    await assertErrorsWithStrictCasts('''
+dynamic a;
+(int i, ) r = a;
+''', [
+      error(CompileTimeErrorCode.INVALID_ASSIGNMENT, 25, 1),
+    ]);
+  }
 }

pkg/analyzer/test/src/diagnostics/strict_raw_type_test.dart

@@ -90,23 +90,47 @@ void g(C a) {}
 extension type E<T>(int i) {}
 
 void f() {
-  var e = <List<E>>[];
+  <List<E>>[];
 }
 ''', [
-      error(WarningCode.UNUSED_LOCAL_VARIABLE, 48, 1),
-      error(WarningCode.STRICT_RAW_TYPE, 58, 1),
+      error(WarningCode.STRICT_RAW_TYPE, 50, 1),
     ]);
   }
 
   test_genericTypeArgument_extensionType_withTypeArg() async {
-    await assertErrorsInCode(r'''
+    await assertNoErrorsInCode(r'''
 extension type E<T>(int i) {}
 
 void f() {
-  var e = <List<E<int>>>[];
+  <List<E<int>>>[];
 }
+''');
+  }
+
+  test_genericTypeArgument_extensionTypeImplements_missingTypeArg() async {
+    await assertErrorsInCode(r'''
+extension type E(List<int> i) implements Iterable {}
+''', [
+      error(WarningCode.STRICT_RAW_TYPE, 41, 8),
+    ]);
+  }
+
+  test_genericTypeArgument_extensionTypeImplementsExtensionType_missingTypeArg() async {
+    await assertErrorsInCode(r'''
+
+extension type E<T>(Iterable<T> i) {}
+
+extension type F(List<int> j) implements E {}
+''', [
+      error(WarningCode.STRICT_RAW_TYPE, 81, 1),
+    ]);
+  }
+
+  test_genericTypeArgument_extensionTypeRepresentationType_missingTypeArg() async {
+    await assertErrorsInCode(r'''
+extension type E(List i) {}
 ''', [
-      error(WarningCode.UNUSED_LOCAL_VARIABLE, 48, 1),
+      error(WarningCode.STRICT_RAW_TYPE, 17, 4),
     ]);
   }