cleanup unneeded strictCast tracking

Follow-up from: https://dart-review.googlesource.com/c/sdk/+/341336

Change-Id: I09a142b00f10e44793b70b10b08920e1245770b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342088
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/lib/src/extensions.dart

@@ -153,7 +153,7 @@ extension ClassElementExtension on ClassElement {
   /// equal to another static const field with the same type as the class is not
   /// included. Such a field is assumed to be deprecated in favor of the field
   /// with equal value.
-  EnumLikeClassDescription? asEnumLikeClass({required bool strictCasts}) {
+  EnumLikeClassDescription? asEnumLikeClass() {
     // See discussion: https://github.com/dart-lang/linter/issues/2083.
 
     // Must be concrete.
@@ -204,8 +204,7 @@ extension ClassElementExtension on ClassElement {
   bool isClass(String otherName, String otherLibrary) =>
       name == otherName && library.name == otherLibrary;
 
-  bool isEnumLikeClass({required bool strictCasts}) =>
-      asEnumLikeClass(strictCasts: strictCasts) != null;
+  bool isEnumLikeClass() => asEnumLikeClass() != null;
 }
 
 extension ClassMemberListExtension on List<ClassMember> {

pkg/linter/lib/src/rules/avoid_redundant_argument_values.dart

@@ -5,7 +5,6 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 import 'package:collection/collection.dart';
 
 import '../analyzer.dart';
@@ -71,14 +70,8 @@ class AvoidRedundantArgumentValues extends LintRule {
 class _Visitor extends SimpleAstVisitor {
   final LintRule rule;
   final LinterContext context;
-  final bool strictCasts;
-
-  _Visitor(this.rule, this.context)
-      :
-        // TODO(pq): update when there's a better API to access strictCasts.
-        strictCasts =
-            // ignore: deprecated_member_use
-            (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
+
+  _Visitor(this.rule, this.context);
 
   void check(ArgumentList argumentList) {
     var arguments = argumentList.arguments;

pkg/linter/lib/src/rules/exhaustive_cases.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -93,21 +92,15 @@ class ExhaustiveCases extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    // TODO(pq): update when there's a better API to access strictCasts.
-    var strictCasts =
-        // ignore: deprecated_member_use
-        (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
-
-    var visitor = _Visitor(this, strictCasts: strictCasts);
+    var visitor = _Visitor(this);
     registry.addSwitchStatement(this, visitor);
   }
 }
 
 class _Visitor extends SimpleAstVisitor {
   final LintRule rule;
-  final bool strictCasts;
 
-  _Visitor(this.rule, {required this.strictCasts});
+  _Visitor(this.rule);
 
   @override
   void visitSwitchStatement(SwitchStatement statement) {
@@ -118,8 +111,7 @@ class _Visitor extends SimpleAstVisitor {
       if (interfaceElement is! ClassElement) {
         return;
       }
-      var enumDescription =
-          interfaceElement.asEnumLikeClass(strictCasts: strictCasts);
+      var enumDescription = interfaceElement.asEnumLikeClass();
       if (enumDescription == null) {
         return;
       }

pkg/linter/lib/src/rules/no_default_cases.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -70,21 +69,15 @@ class NoDefaultCases extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    // TODO(pq): update when there's a better API to access strictCasts.
-    var strictCasts =
-        // ignore: deprecated_member_use
-        (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
-
-    var visitor = _Visitor(this, strictCasts: strictCasts);
+    var visitor = _Visitor(this);
     registry.addSwitchStatement(this, visitor);
   }
 }
 
 class _Visitor extends SimpleAstVisitor {
   final LintRule rule;
-  final bool strictCasts;
 
-  _Visitor(this.rule, {required this.strictCasts});
+  _Visitor(this.rule);
 
   @override
   void visitSwitchStatement(SwitchStatement statement) {
@@ -95,7 +88,7 @@ class _Visitor extends SimpleAstVisitor {
           var interfaceElement = expressionType.element;
           if (interfaceElement is EnumElement ||
               interfaceElement is ClassElement &&
-                  interfaceElement.isEnumLikeClass(strictCasts: strictCasts)) {
+                  interfaceElement.isEnumLikeClass()) {
             rule.reportLint(member);
           }
           return;

pkg/linter/lib/src/rules/unreachable_from_main.dart

@@ -8,7 +8,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 import 'package:collection/collection.dart';
 import 'package:pub_semver/pub_semver.dart';
 
@@ -463,14 +462,8 @@ class _ReferenceVisitor extends RecursiveAstVisitor {
 class _Visitor extends SimpleAstVisitor<void> {
   final LintRule rule;
   final LinterContext context;
-  final bool strictCasts;
-
-  _Visitor(this.rule, this.context)
-      :
-        // TODO(pq): update when there's a better API to access strictCasts.
-        strictCasts =
-            // ignore: deprecated_member_use
-            (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
+
+  _Visitor(this.rule, this.context);
 
   @override
   void visitCompilationUnit(CompilationUnit node) {

pkg/linter/lib/src/rules/use_enums.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 
 import '../analyzer.dart';
 import '../ast.dart';
@@ -186,14 +185,8 @@ class _NonEnumVisitor extends _BaseVisitor {
 class _Visitor extends SimpleAstVisitor {
   final LintRule rule;
   final LinterContext context;
-  final bool strictCasts;
-
-  _Visitor(this.rule, this.context)
-      :
-        // TODO(pq): update when there's a better API to access strictCasts.
-        strictCasts =
-            // ignore: deprecated_member_use
-            (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
+
+  _Visitor(this.rule, this.context);
 
   @override
   visitClassDeclaration(ClassDeclaration node) {

pkg/linter/lib/src/rules/use_named_constants.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
-import 'package:analyzer/src/generated/engine.dart'; //ignore: implementation_imports
 
 import '../analyzer.dart';
 
@@ -54,16 +53,10 @@ class UseNamedConstants extends LintRule {
 
 class _Visitor extends SimpleAstVisitor<void> {
   final LintRule rule;
-  final bool strictCasts;
 
   final LinterContext context;
 
-  _Visitor(this.rule, this.context)
-      :
-        // TODO(pq): update when there's a better API to access strictCasts.
-        strictCasts =
-            // ignore: deprecated_member_use
-            (context.analysisOptions as AnalysisOptionsImpl).strictCasts;
+  _Visitor(this.rule, this.context);
 
   @override
   void visitInstanceCreationExpression(InstanceCreationExpression node) {