[dartdevc] make ImmutableSet private

Patch files should not add public members to the underlying library.

Siggi was hitting this when wiring up modular testing for DDC:
https://dart-review.googlesource.com/c/sdk/+/103680/3/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#544

The ddk builder appears to have be swallowing this error - not yet sure why.

Change-Id: I86098b25a344b2bb8b69fe3dc386d01f6f7cb309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103740
Reviewed-by: Nate Bosch <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Vijay Menon <[email protected]>

Author: vsmenon

pkg/dev_compiler/tool/input_sdk/patch/collection_patch.dart

@@ -303,8 +303,9 @@ class _HashSet<E> extends _InternalSet<E>
   }
 }
 
-class ImmutableSet<E> extends _HashSet<E> {
-  ImmutableSet.from(JSArray entries) {
+// Used for DDC const sets.
+class _ImmutableSet<E> extends _HashSet<E> {
+  _ImmutableSet.from(JSArray entries) {
     var map = _map;
     for (Object key in entries) {
       if (key == null) {
@@ -323,7 +324,7 @@ class ImmutableSet<E> extends _HashSet<E> {
   bool remove(Object key) => throw _unsupported();
 
   static Error _unsupported() =>
-      UnsupportedError("Cannot modify unmodifiable map");
+      UnsupportedError("Cannot modify unmodifiable set");
 }
 
 class _IdentityHashSet<E> extends _InternalSet<E>

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -548,6 +548,14 @@ Map<K, V> constMap<K, V>(JSArray elements) {
 }
 
 final constantSets = JS('', 'new Map()');
+var _immutableSetConstructor;
+
+// We cannot invoke private class constructors directly in Dart.
+Set<E> _createImmutableSet<E>(JSArray<E> elements) {
+  _immutableSetConstructor ??=
+      JS('', '#.#', getLibrary('dart:collection'), '_ImmutableSet\$');
+  return JS('', 'new (#(#)).from(#)', _immutableSetConstructor, E, elements);
+}
 
 Set<E> constSet<E>(JSArray<E> elements) {
   var count = elements.length;
@@ -557,7 +565,7 @@ Set<E> constSet<E>(JSArray<E> elements) {
   }
   var result = JS('', '#.get(#)', map, E);
   if (result != null) return result;
-  result = ImmutableSet<E>.from(elements);
+  result = _createImmutableSet<E>(elements);
   JS('', '#.set(#, #)', map, E, result);
   return result;
 }

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

@@ -155,26 +155,42 @@ void trackLibraries(
 }
 
 List<String> _libraries;
+Map<String, Object> _libraryObjects;
 Map<String, List<String>> _parts;
 
 _computeLibraryMetadata() {
   _libraries = [];
+  _libraryObjects = {};
   _parts = {};
   var modules = getModuleNames();
   for (var name in modules) {
     // Add libraries from each module.
     var module = getModuleLibraries(name);
-    _libraries.addAll(getOwnPropertyNames(module).cast());
+    var libraries = getOwnPropertyNames(module).cast<String>();
+    _libraries.addAll(libraries);
+    for (var library in libraries) {
+      _libraryObjects[library] = JS('', '#.#', module, library);
+    }
 
     // Add parts from each module.
     var partMap = getModulePartMap(name);
-    List<String> libraries = List.from(getOwnPropertyNames(partMap));
+    libraries = getOwnPropertyNames(partMap).cast<String>();
     for (var library in libraries) {
       _parts[library] = List.from(JS('List', '#.#', partMap, library));
     }
   }
 }
 
+/// Returns the JS library object for a given library [uri] or
+/// undefined / null if it isn't loaded.  Top-level types and
+/// methods are available on this object.
+Object getLibrary(String uri) {
+  if (_libraryObjects == null) {
+    _computeLibraryMetadata();
+  }
+  return _libraryObjects[uri];
+}
+
 /// Returns a JSArray of library uris (e.g,
 /// ['dart:core', 'dart:_internal', ..., 'package:foo/bar.dart', ... 'main.dart'])
 /// loaded in this application.

tests/compiler/dartdevc_native/libraries_test.dart

@@ -9,10 +9,12 @@ import 'dart:_runtime' as dart;
 part 'libraries_part.dart';
 
 void main() {
+  // Test getLibraries()
   var libraries = dart.getLibraries();
   Expect.isTrue(libraries.contains('dart:core'));
   Expect.isTrue(libraries.contains('package:expect/expect.dart'));
 
+  // Test getParts(...)
   var expectParts = dart.getParts('package:expect/expect.dart');
   Expect.isTrue(expectParts.isEmpty);
 
@@ -22,4 +24,9 @@ void main() {
   var testParts = dart.getParts(testLibraries.first);
   Expect.isTrue(testParts.length == 1);
   Expect.isTrue(testParts.first.endsWith('libraries_part.dart'));
+
+  // Test getLibrary(...)
+  var core = dart.getLibrary('dart:core');
+  var stackTraceType = dart.wrapType(JS('', '#.StackTrace', core));
+  Expect.equals(StackTrace, stackTraceType);
 }