Skip to content

Commit e9f5b85

Browse files
aartbikcommit-bot@chromium.org
authored andcommitted
[vm/bytecode] fixed typo in stack test
Rationale: We should test for *empty* stack. As written, we basically never generate OSR points for the bytecode path except for the cases we can' handle yet :-) #36421 Change-Id: Ie70a626f9fd24d63442e681ab120087f9d1b010b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98625 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Aart Bik <[email protected]>
1 parent da15746 commit e9f5b85

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

runtime/vm/compiler/frontend/bytecode_flow_graph_builder.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -666,9 +666,9 @@ void BytecodeFlowGraphBuilder::BuildCheckStack() {
666666
ASSERT(IsStackEmpty());
667667
code_ += B->CheckStackOverflowInPrologue(position_);
668668
} else {
669-
// Avoid OSR points inside block-expressions.
670-
// TODO(ajcbik): make sure OSR works inside BE too.
671-
if (!IsStackEmpty()) {
669+
// Avoid OSR points inside block-expressions with pending stack slots.
670+
// TODO(ajcbik): make sure OSR works for such cases too.
671+
if (IsStackEmpty()) {
672672
code_ += B->CheckStackOverflow(position_, loop_depth);
673673
}
674674
}

0 commit comments

Comments
 (0)