Skip to content

Commit f0da490

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
Avoid non-web integer literal in corelib_2/growable_list_test
dart2js will now fail with an unchecked ConcurrentModificationError. Change-Id: I54ddc4198538f4b9276ef0f4692fd74590a38135 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108240 Commit-Queue: Stephen Adams <[email protected]> Reviewed-by: Lasse R.H. Nielsen <[email protected]>
1 parent 7b13c45 commit f0da490

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

tests/corelib_2/corelib_2.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ double_floor_test/int64: CompileTimeError, OK # Error if web int literal cannot
2525
double_round_test/int64: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
2626
double_truncate_test/int64: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
2727
error_stack_trace1_test: RuntimeError # Issue 12399
28-
growable_list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
29-
growable_list_test: RuntimeError # Concurrent modifications test always runs
3028
int_from_environment_int64_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
3129
int_parse_radix_int64_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
3230
int_parse_radix_int64_test/02: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
@@ -183,7 +181,6 @@ symbol_reserved_word_test/03: RuntimeError # Issue 19972, new Symbol('void') sho
183181
[ $compiler == dart2js && $minified ]
184182
dynamic_nosuchmethod_test: RuntimeError
185183
error_stack_trace1_test: RuntimeError # Issue 12399
186-
growable_list_test: RuntimeError # Concurrent modifications test always runs
187184
hash_set_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(_CustomHashSet.#x), local(_CustomHashSet.#)) for j:closure_call(_CustomHashSet__CustomHashSet_closure.call).
188185
integer_to_radix_string_test/01: RuntimeError
189186
integer_to_radix_string_test/02: RuntimeError
@@ -299,7 +296,6 @@ double_floor_test/int64: CompileTimeError, OK # Error if web int literal cannot
299296
double_round_test/int64: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
300297
double_truncate_test/int64: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
301298
error_stack_trace_test/nullThrown: RuntimeError # .stackTrace not present for exception caught from 'throw null;'
302-
growable_list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
303299
hash_set_test/01: RuntimeError # Issue 29921
304300
int_from_environment_int64_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
305301
int_modulo_arith_test/none: RuntimeError # Issue 29921

tests/corelib_2/growable_list_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ void testConstructor() {
9090
testGrowable(new List<int>()..length = 5);
9191
testGrowable(new List<int>.filled(5, null, growable: true));
9292
Expect.throwsArgumentError(() => new List<int>(-1), "-1");
93-
// There must be limits. Fix this test if we ever allow 10^30 elements.
94-
Expect.throwsArgumentError(() => new List<int>(0x7fffffffffffffff), "bignum");
93+
// There must be limits. Fix this test if we ever allow 2^63 elements.
94+
Expect.throwsArgumentError(() => new List<int>(0x7ffffffffffff000), "bignum");
9595
Expect.throwsArgumentError(() => new List<int>(null), "null");
9696
testThrowsOrTypeError(
9797
() => new List([] as Object), // Cast to avoid warning.

0 commit comments

Comments
 (0)