[analyzer] Dot shorthands: Error - constructors with type parameters.

Add `WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR` for dot shorthand constructor invocations with type parameters.

Unit tests added and co19 tests + language tests such as `type_parameter_error_test.dart`.

Bug: #59835
Change-Id: Ie8314f1678248f168744646dc0c3d2622cf61551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426283
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -1671,6 +1671,8 @@ CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_ANONYMOUS_FUNCTION:
   since: 2.15
 CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR:
   status: hasFix
+CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR:
+  status: needsEvaluation
 CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_ENUM:
   status: noFix
   since: 2.17

pkg/analyzer/lib/src/dart/resolver/instance_creation_expression_resolver.dart

@@ -91,6 +91,19 @@ class InstanceCreationExpressionResolver {
           );
         }
       }
+
+      var typeArguments = node.typeArguments;
+      if (typeArguments != null) {
+        _resolver.errorReporter.atNode(
+          typeArguments,
+          CompileTimeErrorCode
+              .WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR,
+          arguments: [
+            dotShorthandContextType.getDisplayString(),
+            node.constructorName.name,
+          ],
+        );
+      }
     } else {
       _resolver.errorReporter.atNode(
         node,

pkg/analyzer/lib/src/dart/resolver/invocation_inferrer.dart

@@ -160,6 +160,16 @@ class DotShorthandConstructorInvocationInferrer
   @override
   TypeArgumentListImpl? get _typeArguments => node.typeArguments;
 
+  @override
+  void _reportWrongNumberOfTypeArguments(
+    TypeArgumentList typeArgumentList,
+    FunctionType rawType,
+    List<TypeParameterElement> typeParameters,
+  ) {
+    // Error reporting for dot shorthand constructor invocations is done
+    // within the [InstanceCreationExpressionResolver].
+  }
+
   @override
   List<FormalParameterElement>? _storeResult(
     List<DartType>? typeArgumentTypes,

pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart

@@ -1293,8 +1293,6 @@ class MethodInvocationResolver with ScopeHelpers {
     if (receiver.getNamedConstructor2(name)
         case ConstructorElementImpl2 element?
         when element.isAccessibleIn2(_resolver.definingLibrary)) {
-      // TODO(kallentu): Produce an error if there are type arguments for this
-      // constructor.
       var replacement = DotShorthandConstructorInvocationImpl(
         constKeyword: null,
         period: node.period,

pkg/analyzer/lib/src/error/codes.g.dart

@@ -5916,6 +5916,20 @@ class CompileTimeErrorCode extends DiagnosticCode {
         hasPublishedDocs: true,
       );
 
+  ///  Parameters:
+  ///  0: the name of the class being instantiated
+  ///  1: the name of the constructor being invoked
+  static const CompileTimeErrorCode
+  WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR = CompileTimeErrorCode(
+    'WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR',
+    "The constructor '{0}.{1}` doesn't have type parameters.",
+    correctionMessage:
+        "Try removing the type arguments, or adding a class name, followed by "
+        "the type arguments, then the constructor name.",
+    hasPublishedDocs: true,
+    uniqueName: 'WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR',
+  );
+
   ///  Parameters:
   ///  0: the number of type parameters that were declared
   ///  1: the number of type arguments provided

pkg/analyzer/lib/src/error/error_code_values.g.dart

@@ -587,6 +587,7 @@ const List<DiagnosticCode> errorCodeValues = [
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS,
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_ANONYMOUS_FUNCTION,
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR,
+  CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR,
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_ENUM,
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_EXTENSION,
   CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_FUNCTION,

pkg/analyzer/lib/src/fasta/ast_builder.dart

@@ -1620,7 +1620,6 @@ class AstBuilder extends StackListener {
     }
 
     var dotShorthand = pop() as DotShorthandInvocationImpl;
-    // TODO(kallentu): Report error if there are type arguments here.
     push(
       DotShorthandConstructorInvocationImpl(
         constKeyword: token,

pkg/analyzer/lib/src/generated/resolver.dart

@@ -4781,6 +4781,8 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
           nameNodeName is PrefixedIdentifier
               ? nameNodeName.identifier.name
               : '${nameNodeName.name}.new';
+    } else if (nameNode is DotShorthandConstructorInvocation) {
+      name = nameNode.constructorName.name;
     } else if (nameNode is DotShorthandInvocation) {
       name = nameNode.memberName.name;
     } else {

pkg/analyzer/messages.yaml

@@ -18392,6 +18392,15 @@ CompileTimeErrorCode:
       }
       C f() => C.named();
       ```
+  WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR:
+    sharedName: WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR
+    problemMessage: "The constructor '{0}.{1}` doesn't have type parameters."
+    correctionMessage: Try removing the type arguments, or adding a class name, followed by the type arguments, then the constructor name.
+    hasPublishedDocs: true
+    comment: |-
+      Parameters:
+      0: the name of the class being instantiated
+      1: the name of the constructor being invoked
   WRONG_NUMBER_OF_TYPE_ARGUMENTS_ENUM:
     problemMessage: The enum is declared with {0} type parameters, but {1} type arguments were given.
     correctionMessage: Try adjusting the number of type arguments.

pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart

@@ -519,4 +519,62 @@ DotShorthandConstructorInvocation
   staticType: C
 ''');
   }
+
+  test_typeParameters() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  C();
+}
+
+void main() {
+  C c = .new<int>();
+  print(c);
+}
+''',
+      [
+        error(
+          CompileTimeErrorCode
+              .WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR,
+          46,
+          5,
+        ),
+      ],
+    );
+  }
+
+  test_typeParameters_const() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  const C();
+}
+
+void main() {
+  C c = const .new<int>();
+  print(c);
+}
+''',
+      [
+        error(
+          CompileTimeErrorCode
+              .WRONG_NUMBER_OF_TYPE_ARGUMENTS_DOT_SHORTHAND_CONSTRUCTOR,
+          58,
+          5,
+        ),
+      ],
+    );
+  }
+
+  test_typeParameters_missingContext() async {
+    await assertErrorsInCode(
+      r'''
+void main() {
+  var c = const .new<int>();
+  print(c);
+}
+''',
+      [error(CompileTimeErrorCode.DOT_SHORTHAND_MISSING_CONTEXT, 24, 17)],
+    );
+  }
 }

tests/language/dot_shorthands/type_parameter/type_parameter_error_test.dart

@@ -18,37 +18,48 @@ extension type ET<T>(T v) {}
 
 void main() {
   StaticMember<int> s = .memberType<String, String>('s');
-  //                    ^
-  // [analyzer] unspecified
+  //                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.INVALID_ASSIGNMENT
   // [cfe] A value of type 'StaticMember<String>' can't be assigned to a variable of type 'StaticMember<int>'.
 
   // Constructors doesn't have type parameters.
   StaticMember<int> constructorTypeParameter = .constNamed<int>(1);
-  //                                            ^^^^^^^^^^
-  // [analyzer] unspecified
+  //                                            ^
   // [cfe] A dot shorthand constructor invocation can't have type arguments.
+  //                                                      ^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR
 
   // `.new<type-args>()` and `.new<type-args>` are a compile-time error.
   UnnamedConstructorTypeParameters typeParameters = .new<int>();
-  //                                                 ^^^
-  // [analyzer] unspecified
+  //                                                 ^
   // [cfe] A dot shorthand constructor invocation can't have type arguments.
+  //                                                    ^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR
 
   UnnamedConstructorTypeParameters Function() tearOff = .new<int>;
-  //                                                     ^^^
-  // [analyzer] unspecified
+  //                                                    ^^^^
+  // [analyzer] COMPILE_TIME_ERROR.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION
+  // [analyzer] COMPILE_TIME_ERROR.DOT_SHORTHAND_MISSING_CONTEXT
+  //                                                     ^
   // [cfe] The static getter or field 'new' isn't defined for the type 'UnnamedConstructorTypeParameters<dynamic> Function()'.
 
   C newTearoff = .new<int>;
-  //              ^^^
-  // [analyzer] unspecified
+  //             ^^^^^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.INVALID_ASSIGNMENT
+  //              ^
   // [cfe] A dot shorthand constructor invocation can't have type arguments.
+  //                 ^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.WRONG_NUMBER_OF_TYPE_ARGUMENTS_FUNCTION
   C namedTearoff = .new<int>;
-  //                ^^^
-  // [analyzer] unspecified
+  //               ^^^^^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.INVALID_ASSIGNMENT
+  //                ^
   // [cfe] A dot shorthand constructor invocation can't have type arguments.
+  //                   ^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.WRONG_NUMBER_OF_TYPE_ARGUMENTS_FUNCTION
   ET e = .new<int>;
-  //      ^^^
-  // [analyzer] unspecified
+  //     ^^^^
+  // [analyzer] COMPILE_TIME_ERROR.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION
+  //      ^
   // [cfe] A dot shorthand constructor invocation can't have type arguments.
 }