Skip to content

tests/lib/mirrors/mixin_test.dart is broken #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peter-ahe-google opened this issue Aug 14, 2013 · 12 comments
Closed

tests/lib/mirrors/mixin_test.dart is broken #12464

peter-ahe-google opened this issue Aug 14, 2013 · 12 comments
Assignees
@peter-ahe-google
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

The test doesn't work without @­MirrorsUsed.

The test assumes an anonymous mixin application is named 'M1(M2(Super))' but it should be 'Super with M2, M1'.

The test assumes constructors are members, but they are not.

The mixin is the owner of members, but not the constructor (which is explicitly copied down per the specification).
@peter-ahe-google
Copy link
Contributor Author

Marked this as blocking #6490.

@peter-ahe-google
Copy link
Contributor Author

Removing @­MixinUsed in https://codereview.chromium.org/22859016.

Added Started label.

@peter-ahe-google
Copy link
Contributor Author

https://codereview.chromium.org/23180004 implements 'Super with M2, M1'.

@peter-ahe-google
Copy link
Contributor Author

Since r26185, constructors are no longer members.

@peter-ahe-google
Copy link
Contributor Author

CL 23180004 landed in r27132.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@peter-ahe-google peter-ahe-google self-assigned this Aug 4, 2014
@peter-ahe-google peter-ahe-google mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Priority-Medium labels Mar 1, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @matanlurey @kasperl @peter-ahe-google