Skip to content

Hint when @protected members are used outside instances of subclasses. #25841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pq opened this issue Feb 23, 2016 · 10 comments
Closed

Hint when @protected members are used outside instances of subclasses. #25841

pq opened this issue Feb 23, 2016 · 10 comments
Assignees
Labels
customer-flutter devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Feb 23, 2016

See @protectedannotation definition here: https://codereview.chromium.org/1719353002/.

@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement legacy-area-analyzer Use area-devexp instead. devexp-warning Issues with the analyzer's Warning codes customer-flutter labels Feb 23, 2016
@pq pq self-assigned this Feb 23, 2016
@pq
Copy link
Member Author

pq commented Feb 25, 2016

Support for methods landed in 84f32fe.
Support for members, in general, landed in 212a058.

@pq pq changed the title Hint when @protected methods are used outside instance methods of subclasses. Hint when @protected members are used outside instance of subclasses. Feb 25, 2016
@pq pq changed the title Hint when @protected members are used outside instance of subclasses. Hint when @protected members are used outside instances of subclasses. Feb 25, 2016
@Hixie
Copy link
Contributor

Hixie commented Feb 26, 2016

qv #3193, #6119

@pq
Copy link
Member Author

pq commented Feb 26, 2016

meta package published. Closing out.

@donny-dont
Copy link

@pq is the analyzer package going to get a push as well with this? I didn't see the protected checks in 0.27.3-alpha.0

@bwilkerson
Copy link
Member

Eventually, yes. We're in the process of implementing several annotations and it might make sense to wait for more of them to be implemented rather than flooding the world with lots of extra versions.

Do you need it for something?

@donny-dont
Copy link

@bwilkerson I can certainly wait. Been waiting a long time for @protected so whats a little longer. Great work all around 👍

@bwilkerson
Copy link
Member

I guess the question really is, do you need a version of the analyzer package published to pub, or are you just waiting for a new build of the SDK with this support in it? (The two are not necessarily kept in sync.)

@donny-dont
Copy link

I have a library that will load a library through the analyzer then gather the metadata and then let you run queries against the data. I have support for deprecated and override and I was going to add support for instantiating @protected whenever that lands.

@bwilkerson
Copy link
Member

It isn't clear that you need a new version of the analyzer package. Analyzer doesn't need to understand an annotation to capture it (though it does have some utility methods for the annotations it knows about). And the annotation itself is defined in the 'meta' package (https://pub.dartlang.org/packages/meta), so you can start adding it to code today. You probably have enough to do what you want, although the utility methods would be helpful.

@donny-dont
Copy link

It was the utility methods ala isDeprecated that would be nice. No rush on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter devexp-warning Issues with the analyzer's Warning codes legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants