Skip to content

Analyzer should catch dangling [Foo] references in dartdocs #26158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Mar 31, 2016 · 8 comments
Closed

Analyzer should catch dangling [Foo] references in dartdocs #26158

Hixie opened this issue Mar 31, 2016 · 8 comments
Labels
customer-flutter devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@Hixie
Copy link
Contributor

Hixie commented Mar 31, 2016

No description provided.

@bwilkerson bwilkerson added legacy-area-analyzer Use area-devexp instead. devexp-warning Issues with the analyzer's Warning codes P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Mar 31, 2016
@scheglov
Copy link
Contributor

scheglov commented Apr 1, 2016

There is some work in progress, which was not actually finished.
https://codereview.chromium.org/1530993002

@pq
Copy link
Member

pq commented May 4, 2016

Given the possible (undesired) impact, maybe this should be a lint?

@pq
Copy link
Member

pq commented May 4, 2016

cc @bwilkerson : what do you think about migrating this to a lint?

@bwilkerson bwilkerson added devexp-linter Issues with the analyzer's support for the linter package and removed devexp-warning Issues with the analyzer's Warning codes labels May 4, 2016
@pq
Copy link
Member

pq commented May 11, 2016

@scheglov : how do you feel about us moving this over to a lint?

@bwilkerson
Copy link
Member

Sorry, I missed the earlier ping.

I think that, hint or lint, we need to clean up the false positives as much as possible first.

I don't remember: are we currently treating square brackets within code as references and trying to resolve them? I don't think we want to do that, whether for this rule or for anything else (like navigation or refactoring). So I think we should take care of that problem independent of what happens to this rule.

@scheglov
Copy link
Contributor

@bwilkerson We remove code blocks while resolving comments.

@Hixie
Copy link
Contributor Author

Hixie commented May 11, 2016

If it's a lint, it would actually help with removing false positives, since we could turn it on only when we're specifically looking at this.

@pq
Copy link
Member

pq commented May 12, 2016

Closing in favor of the lint request, in progress and tracked yonder: #57330.

@pq pq closed this as completed May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants