Skip to content

support covariant parameter overrides #27353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmesserly opened this issue Sep 14, 2016 · 5 comments
Closed

support covariant parameter overrides #27353

jmesserly opened this issue Sep 14, 2016 · 5 comments
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler

Comments

@jmesserly
Copy link

jmesserly commented Sep 14, 2016 •
edited
Loading

@checked for declaring a parameter as covariant was recently added to Analyzer, but we don't support this in DDC code generation, so it's a soundness problem until we fix it.

Note we also have a problem with generic types: #27259, however that one is a tad different. It is attempting to optimize covariant checks to only appear for parameters when necessary, but the optimization is what gets us into trouble.
@jmesserly jmesserly self-assigned this Sep 15, 2016
@jmesserly
Copy link
Author

https://codereview.chromium.org/2340463009/

@jmesserly jmesserly added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Sep 15, 2016
@jmesserly
Copy link
Author

oops, need to fix tear-offs as well

@jmesserly jmesserly reopened this Sep 15, 2016
@jmesserly
Copy link
Author

note: current behavior for tear-offs is sound, but more restrictive than it could be.

@jmesserly jmesserly added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Sep 20, 2016
@jmesserly jmesserly removed their assignment Oct 4, 2016
@jmesserly
Copy link
Author

Actually I'll open a different bug for tear off type.

@jmesserly jmesserly mentioned this issue Oct 4, 2016
Closed
@jmesserly
Copy link
Author

and that bug is #27484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesserly