Skip to content

Implement generic function type syntax in DDC #27971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
floitschG opened this issue Dec 2, 2016 · 8 comments
Closed

Implement generic function type syntax in DDC #27971

floitschG opened this issue Dec 2, 2016 · 8 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler
Milestone

Comments

@floitschG
Copy link
Contributor

This is the DDC-implementation issue for #27527.

At the moment we only really need the new syntax in typedefs. Eventually, we want to make this syntax usable for fields and locals, but it's not yet as high a priority. If you find the time to make it work there too, please guard it behind a (different) flag.

See #27969 for the analyzer issue.

@jmesserly
Copy link

FYI -- I'm not sure we will need to do any changes at all to DDC, as we already support universal function types, so fixing Analyzer side should give this to us for free.

@mit-mit
Copy link
Member

mit-mit commented Dec 15, 2016

Moving to 1.22 for implementation, informal spec i linked from the meta-issue #27527

@mit-mit mit-mit added this to the 1.22 milestone Dec 15, 2016
@vsmenon
Copy link
Member

vsmenon commented Dec 15, 2016

@floitschG are there tests for this?

Once #27969 is done, we should sanity check that those tests pass in DDC. I don't think there is anything else to do.

@jmesserly
Copy link

@vsmenon I just remembered we two bugs related to universal functions, however they exist with or without the explicit syntax support: #28105, #28079

@jmesserly jmesserly added the P2 A bug or feature request we're likely to work on label Jan 10, 2017
@kevmoo kevmoo added the status-blocked Blocked from making progress by another (referenced) issue label Jan 17, 2017
@floitschG floitschG modified the milestones: 1.23, 1.22 Jan 18, 2017
@vsmenon
Copy link
Member

vsmenon commented Mar 8, 2017

Marking this as done on the DDC side - I don't anticipate any work beyond the analyzer issue and the bugs Jen referenced.

@vsmenon vsmenon closed this as completed Mar 8, 2017
@jmesserly jmesserly reopened this Apr 10, 2017
@jmesserly jmesserly modified the milestones: 1.24, 1.23 Apr 10, 2017
@jmesserly
Copy link

Reopening. Discovered DDC does not support the syntax due to introduction of a new Analyzer AST node (rather than implement it purely using the existing types).
Unimplemented GenericTypeAliasImpl: typedef T2T = T Function<T>(T t)

@jmesserly jmesserly self-assigned this Apr 10, 2017
@jmesserly jmesserly removed the status-blocked Blocked from making progress by another (referenced) issue label Apr 10, 2017
@jmesserly
Copy link

I'm working on this now, though.

@jmesserly
Copy link

i've got a CL with syntax support working, however we still need proper runtime representation and subtype checks for strong mode (see #28079)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Development

No branches or pull requests

5 participants