Skip to content

Analyzer should warn if part-of URI doesn't match importing library. #28522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrhn opened this issue Jan 26, 2017 · 4 comments
Closed

Analyzer should warn if part-of URI doesn't match importing library. #28522

lrhn opened this issue Jan 26, 2017 · 4 comments
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@lrhn
Copy link
Member

lrhn commented Jan 26, 2017

When CL https://codereview.chromium.org/2640853005 lands, the analyzer needs to

  • report a warning if the URI of a part of declaration doesn't match the URI of the library file doing the part inclusion.
  • report a warning if the library name of a part of declaration doesn't match the name of the library doing the part inclusion. It already does this in some cases, but no longer does it in the case where the including library has no name (which previously prevented part inclusion and was handled at the part declaration).

The analyzer can also remove the enableUriInPartOf flag.

@bwilkerson bwilkerson added legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 26, 2017
@floitschG
Copy link
Contributor

Is this done?
When I tried it on the command line I got a warning.

@floitschG
Copy link
Contributor

ping

@lrhn
Copy link
Member Author

lrhn commented Jun 6, 2017

@bwilkerson

@bwilkerson
Copy link
Member

I don't currently have time to look at this, but would be happy to review a CL if that would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants